PannelloAmministrazioneController - Code Metrics - Inspection of "Merge branch 'release/v0.1.37'" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 4bf89d...62bfc7 )

by Andrea
created 2018-12-14 13:02 UTC
PannelloAmministrazioneController A

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	370
Duplicated Lines	0 %
Test Coverage

Coverage
88.71%
Importance

Changes
Metric	Value
eloc	232
dl	0
loc	370
ccs	165
cts	186
cp	0.8871
rs	9.0399
c	0
b	0
f	0
wmc	42
13 Methods

Rating	Name	Size	Complexity
A	aggiornaSchemaDatabase()	17	3
A	symfonyCommand()	22	3
A	__construct()	11	1
A	phpunittest()	31	4
B	index()	83	7
A	clearCache()	19	3
A	findEntities()	14	4
A	generateEntity()	18	3
B	unixCommand()	36	6
A	fixSlash()	3	1
A	getVcs()	14	2
A	generateFormCrud()	26	4
A	getLockMessage()	3	1
How to fix Complexity

<?php

namespace Cdf\PannelloAmministrazioneBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Finder\Finder;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Process\Process;
use Fi\OsBundle\DependencyInjection\OsFunctions;
use Cdf\PannelloAmministrazioneBundle\DependencyInjection\PannelloAmministrazioneUtils as Pautils;
use Symfony\Component\Lock\Factory;
use Symfony\Component\Lock\Store\FlockStore;
use Cdf\PannelloAmministrazioneBundle\DependencyInjection\ProjectPath;
use Cdf\PannelloAmministrazioneBundle\DependencyInjection\PannelloamministrazioneCommands as Pacmd;

class PannelloAmministrazioneController extends AbstractController
{

    private $apppaths;
    private $pacommands;
    private $pautils;
    protected $locksystem;
    protected $factory;
    private $appname;
    private $lockfile;

    public function __construct($appname, $lockfile, ProjectPath $projectpath, Pacmd $pacommands, Pautils $pautils)
    {
        $store = new FlockStore(sys_get_temp_dir());
$a = "a";
$ab = "ab";
$abc = "abc";
        $factory = new Factory($store);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->locksystem = $factory->createLock('pannelloamministrazione-command');
        $this->locksystem->release();
        $this->appname = $appname;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->lockfile = $lockfile;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->apppaths = $projectpath;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->pacommands = $pacommands;
        $this->pautils = $pautils;
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    private function findEntities()
    {
        $entitiesprogetto = array();
        $prefix = 'App\\Entity\\';
$a = "a";
$ab = "ab";
$abc = "abc";
        $prefixBase = 'Base';
$a = "a";
$ab = "ab";
$abc = "abc";
        $entities = $this->get("doctrine")->getManager()->getConfiguration()->getMetadataDriverImpl()->getAllClassNames();
$a = "a";
$ab = "ab";
$abc = "abc";
        foreach ($entities as $entity) {
            if (substr($entity, 0, strlen($prefix)) == $prefix) {
                if (substr(substr($entity, strlen($prefix)), 0, strlen($prefixBase)) != $prefixBase) {
                    $entitiesprogetto[] = substr($entity, strlen($prefix));
                }
            }
        }
        return $entitiesprogetto;
    }

    public function index()
    {
        $finder = new Finder();
        $fs = new Filesystem();
$a = "a";
$ab = "ab";
$abc = "abc";

        $projectDir = $this->apppaths->getRootPath();
        $docDir = $this->apppaths->getDocPath();
$a = "a";
$ab = "ab";
$abc = "abc";

        $mwbs = array();

        if ($fs->exists($docDir)) {
            $finder->in($docDir)->files()->name('*.mwb');
            foreach ($finder as $file) {
                $mwbs[] = $file->getBasename();
            }
        }
        sort($mwbs);
        $svn = $fs->exists($projectDir . '/.svn');
        $git = $fs->exists($projectDir . '/.git');
        if (!OsFunctions::isWindows()) {
            $delcmd = 'rm -rf';
$a = "a";
$ab = "ab";
$abc = "abc";
            $setfilelock = "touch " . $this->lockfile;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $remfilelock = "rm " . $this->lockfile;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $windows = false;
$a = "a";
$ab = "ab";
$abc = "abc";
        } else {
            $delcmd = 'del';
$a = "a";
$ab = "ab";
$abc = "abc";
            $setfilelock = 'echo $null >> ' . $this->lockfile;
            $remfilelock = "del " . $this->lockfile;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $windows = true;
$a = "a";
$ab = "ab";
$abc = "abc";
        }

        $dellogsfiles = $delcmd . ' ' . $this->apppaths->getLogsPath() . DIRECTORY_SEPARATOR . '*';
$a = "a";
$ab = "ab";
$abc = "abc";
        $delcacheprodfiles = $delcmd . ' ' . $this->apppaths->getCachePath() . DIRECTORY_SEPARATOR . 'prod' . DIRECTORY_SEPARATOR . '*';
$a = "a";
$ab = "ab";
$abc = "abc";
        $delcachedevfiles = $delcmd . ' ' . $this->apppaths->getCachePath() . DIRECTORY_SEPARATOR . 'dev' . DIRECTORY_SEPARATOR . '*';
$a = "a";
$ab = "ab";
$abc = "abc";
        $setmaintenancefile = $setfilelock;
        $remmaintenancefile = $remfilelock;

        $projectparentdir = $projectDir . '/../';
        $envvars = $projectparentdir . "/" . "envvars";
$a = "a";
$ab = "ab";
$abc = "abc";
        $composercachedir = $projectparentdir . "/" . ".composer";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $composerinstall = "";
$a = "a";
$ab = "ab";
$abc = "abc";
        if ($windows == false) {

            if (file_exists($envvars)) {
                $composerinstall = $composerinstall . ". " . $envvars . " && ";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
            if (file_exists($composercachedir)) {
                $composerinstall = $composerinstall . " export COMPOSER_HOME=" . $composercachedir . " && ";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
            $composerinstall = $composerinstall . " cd " . $projectDir . " && composer install --no-interaction 2>&1";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $sed = "sed -i -e 's/cercaquestastringa/sostituisciconquestastringa/g' " . $projectDir . "/.env";
$a = "a";
$ab = "ab";
$abc = "abc";
        }

        $comandishell = array(
            $this->fixSlash($dellogsfiles),
            $this->fixSlash($delcacheprodfiles),
            $this->fixSlash($delcachedevfiles),
            $this->fixSlash($setmaintenancefile),
            $this->fixSlash($remmaintenancefile),
            $composerinstall,
            $sed);


        $comandisymfony = array(
            "list",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "cache:clear --env=prod --no-debug",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "fos:user:create admin pass [email protected]",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "fos:user:promote username ROLE_SUPER_ADMIN",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "assets:install ' . $projectDir . ' /public",
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            "pannelloamministrazione:checkgitversion"
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        );

        $entities = $this->findEntities();
        sort($entities);

        $twigparms = array(
            'svn' => $svn, 'git' => $git, 'mwbs' => $mwbs, 'entities' => $entities,
            'rootdir' => $this->fixSlash($projectDir),
            'comandishell' => $comandishell,
            'comandisymfony' => $comandisymfony,
            'iswindows' => $windows,
            'appname' => $this->appname
        );

        return $this->render('PannelloAmministrazioneBundle:PannelloAmministrazione:index.html.twig', $twigparms);
    }

    private function fixSlash($path)
    {
        return str_replace('\\', '\\\\', $path);
    }

    private function getLockMessage()
    {
        return "<h2 style='color: orange;'>E' già in esecuzione un comando, riprova tra qualche secondo!</h2>";
    }

    public function aggiornaSchemaDatabase()
    {
        if (!$this->locksystem->acquire()) {
            return new Response($this->getLockMessage());
        } else {
            $this->locksystem->acquire();
            $command = $this->pacommands;
            $result = $command->aggiornaSchemaDatabase();
$a = "a";
$ab = "ab";
$abc = "abc";

            $this->locksystem->release();
            if ($result['errcode'] != 0) {
                $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);
                $view = $this->renderView('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
$a = "a";
$ab = "ab";
$abc = "abc";
                return new Response($view, 500);
            } else {
                $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);
                return $this->render('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
            }
        }
    }

    /* FORMS */

    public function generateFormCrud(Request $request)
    {
        if (!$this->locksystem->acquire()) {
            return new Response($this->getLockMessage());
        } else {
            $entityform = $request->get('entityform');
$a = "a";
$ab = "ab";
$abc = "abc";
            $generatemplate = $request->get('generatemplate') === 'true' ? true : false;
            $this->locksystem->acquire();

            $command = $this->pacommands;
            $result = $command->generateFormCrud($entityform, $generatemplate);
$a = "a";
$ab = "ab";
$abc = "abc";

            $this->locksystem->release();
            //$retcc = '';

            if ($result['errcode'] < 0) {
                $twigparms = array('errcode' => $result['errcode'], 'command' => "Generazione Form Crud", 'message' => $result['message']);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                return new Response(
                    $this->renderView('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms),
                    500
                );
            } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
                //$retcc = $command->clearCacheEnv($this->get('kernel')->getEnvironment());

            }
            $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);

            return $this->render('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
        }
    }

    /* ENTITIES */

    public function generateEntity(Request $request)
    {
        if (!$this->locksystem->acquire()) {
            return new Response($this->getLockMessage());
        } else {
            $this->locksystem->acquire();
            $wbFile = $request->get('file');
$a = "a";
$ab = "ab";
$abc = "abc";
            $command = $this->pacommands;
$a = "a";
$ab = "ab";
$abc = "abc";
            $result = $command->generateEntity($wbFile);
$a = "a";
$ab = "ab";
$abc = "abc";
            $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);

            $this->locksystem->release();
            if ($result['errcode'] != 0) {
                $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);
                $view = $this->renderView('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
$a = "a";
$ab = "ab";
$abc = "abc";
                return new Response($view, 500);
            } else {
                $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);
                return $this->render('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
            }
        }
    }

    /* VCS (GIT,SVN) */


    /**
     * @codeCoverageIgnore
     */
    public function getVcs()
    {
        set_time_limit(0);
        $this->apppaths = $this->apppaths;
        if (!$this->locksystem->acquire()) {
            return new Response($this->getLockMessage());
        } else {
            $this->locksystem->acquire();
            $command = $this->pacommands;
            $result = $command->getVcs();
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->locksystem->release();
            $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);

            return $this->render('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
        }
    }

    /* CLEAR CACHE */

    /**
     * Suppress PMD warnings per exit.
     *
     * @//SuppressWarnings(PHPMD)
     */
    public function clearCache(Request $request)
    public function clearCache(/** @scrutinizer ignore-unused */ Request $request)
    {
        set_time_limit(0);
        if (!$this->locksystem->acquire()) {
            return new Response($this->getLockMessage());
        } else {
            $this->locksystem->acquire();
            $command = $this->pacommands;
            $result = $command->clearcache();
$a = "a";
$ab = "ab";
$abc = "abc";

            $this->locksystem->release();

            if ($result['errcode'] != 0) {
                $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);
                $view = $this->renderView('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
$a = "a";
$ab = "ab";
$abc = "abc";
                return new Response($view, 500);
            } else {
                $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);
                return $this->render('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
            }
        }
    }

    /* CLEAR CACHE */

    public function symfonyCommand(Request $request)
    {
        set_time_limit(0);
        
        $simfonycommand = $request->get('symfonycommand');
        $comando = explode(" ", $simfonycommand);
$a = "a";
$ab = "ab";
$abc = "abc";
        if (!$this->locksystem->acquire()) {
            return new Response($this->getLockMessage());
        } else {
            $this->locksystem->acquire();
            $this->apppaths = $this->apppaths;
            $pammutils = $this->pautils;
$a = "a";
$ab = "ab";
$abc = "abc";
            $result = $pammutils->runCommand($this->apppaths->getConsole(), $comando);
$a = "a";
$ab = "ab";
$abc = "abc";

            $this->locksystem->release();
            if ($result['errcode'] != 0) {
                $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);
                $view = $this->renderView('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
$a = "a";
$ab = "ab";
$abc = "abc";
                return new Response($view, 500);
            } else {
                $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);
                return $this->render('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
            }
        }
    }

    /**
     * Suppress PMD warnings per exit.
     *
     * @SuppressWarnings(PHPMD)
     */
    public function unixCommand(Request $request)
    {
        set_time_limit(0);
        $pammutils = $this->pautils;
$a = "a";
$ab = "ab";
$abc = "abc";
        $unixcommand = $request->get('unixcommand');
        $parametri = explode(" ", $unixcommand);
$a = "a";
$ab = "ab";
$abc = "abc";
        $arguments = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $command = $unixcommand;
$a = "a";
$ab = "ab";
$abc = "abc";
        if (count($parametri) > 1) {
            $command = $parametri[0];
            for ($index = 1; $index < count($parametri); $index++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                $arguments[] = $parametri[$index];
            }
        }
        //Se viene lanciato il comando per cancellare il file di lock su bypassa tutto e si lancia
        $dellockfile = "DELETELOCK";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if ($command == $dellockfile) {
            $this->locksystem->release();
            return new Response('File di lock cancellato');
        }

        if (!$this->locksystem->acquire()) {
            return new Response($this->getLockMessage());
        } else {
            $this->locksystem->acquire();
            $result = $pammutils->runCommand($command, $arguments);

            $this->locksystem->release();
            // eseguito deopo la fine del comando
            if ($result['errcode'] != 0) {
                $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);
                $view = $this->renderView('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
$a = "a";
$ab = "ab";
$abc = "abc";
                return new Response($view, 500);
            } else {
                $twigparms = array('errcode' => $result['errcode'], 'command' => $result['command'], 'message' => $result['message']);
                return $this->render('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
            }
        }
    }

    /**
     * @codeCoverageIgnore
     */
    public function phpunittest(Request $request)
    public function phpunittest(/** @scrutinizer ignore-unused */ Request $request)
    {
        set_time_limit(0);
        $this->apppaths = $this->apppaths;
        if (!$this->locksystem->acquire()) {
            return new Response($this->getLockMessage());
        } else {
            if (!OsFunctions::isWindows()) {
                $this->locksystem->acquire();
                //$phpPath = OsFunctions::getPHPExecutableFromPath();

                $sepchr = OsFunctions::getSeparator();
$a = "a";
$ab = "ab";
$abc = "abc";
                $phpPath = OsFunctions::getPHPExecutableFromPath();

                $command = 'cd ' . $this->apppaths->getRootPath() . $sepchr .
                        $phpPath . ' ' . 'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'simple-phpunit';

                $process = new Process($command);
                $process->run();

                $this->locksystem->release();
                // eseguito dopo la fine del comando
                if (!$process->isSuccessful()) {
                    $twigparms = array('errcode' => -1, 'command' => $command, 'message' => $process->getOutput() . $process->getErrorOutput());
                    $view = $this->renderView('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
$a = "a";
$ab = "ab";
$abc = "abc";
                    return new Response($view, 500);
                } else {
                    $twigparms = array('errcode' => 0, 'command' => $command, 'message' => $process->getOutput() . $process->getErrorOutput());
                    return $this->render('PannelloAmministrazioneBundle:PannelloAmministrazione:outputcommand.html.twig', $twigparms);
                }
            } else {
                return new Response('Non previsto in ambiente windows!', 500);
            }
        }
    }
}

ComuneFI / BiCoreBundle

Push — master ( 4bf89d...62bfc7 )

PannelloAmministrazioneController A

Complexity

Size/Duplication

Test Coverage

Importance

13 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like
