FiCrudController::update() - Code Metrics - Inspection of "add tests" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 90018e...176c47 )

by Andrea
created 2018-11-24 21:53 UTC
FiCrudController::update() B

↳ Parent: FiCrudController
Complexity

Conditions	6
Paths	7
Size

Total Lines	62
Code Lines	39
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	36
CRAP Score	6.0007
Importance

Changes
Metric	Value
cc	6
eloc	39
nc	7
nop	2
dl	0
loc	62
ccs	36
cts	37
cp	0.973
crap	6.0007
rs	8.6737
c	0
b	0
f	0
How to fix Long Method

<?php

namespace Cdf\BiCoreBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Cdf\BiCoreBundle\Utils\Entity\Finder;
use Cdf\BiCoreBundle\Utils\Entity\EntityUtils;
use Cdf\BiCoreBundle\Utils\Tabella\ParametriTabella;
use Symfony\Component\Asset\Packages;

class FiCrudController extends AbstractController
{

    protected $bundle;
    protected $controller;
    protected $permessi;

    
    /**
     * Lists all tables entities.
     */
    public function index(Request $request, Packages $assetsmanager)
    {
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        $idpassato = $request->get('id');
$a = "a";
$ab = "ab";
$abc = "abc";

        if (!$this->getPermessi()->canRead()) {
            throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $crudtemplate = $this->getCrudTemplate($bundle, $controller, $this->getThisFunctionName());

        $entityclassnotation = $this->getEntityClassNotation();
        $entityclass = $this->getEntityClassName();
$a = "a";
$ab = "ab";
$abc = "abc";

        $formclass = str_replace("Entity", "Form", $entityclass);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $modellocolonne = array(
        /*

          $controller . ".nominativo" => array(
          "nometabella" => $controller,
          "nomecampo" => "nominativo",
          "etichetta" => "Nominativo",
          "ordine" => 10,
          "larghezza" => 200,
          "escluso" => false
          ),
          $controller . ".datanascita" => array(
          "nometabella" => $controller,
          "nomecampo" => "datanascita",
          "etichetta" => "Data di nascita",
          "ordine" => 20,
          "larghezza" => 100,
          "escluso" => false
          ),

         */
        );

        $colonneordinamento = array($controller . '.id' => "DESC");
$a = "a";
$ab = "ab";
$abc = "abc";
        $filtri = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $prefiltri = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $entityutils = new \Cdf\BiCoreBundle\Utils\Entity\EntityUtils($this->get("doctrine")->getManager());
$a = "a";
$ab = "ab";
$abc = "abc";
        $tablenamefromentity = $entityutils->getTableFromEntity($entityclass);
        $colonneordinamento = array($tablenamefromentity . '.id' => "DESC");
$a = "a";
$ab = "ab";
$abc = "abc";
        $parametritabella = array("em" => ParametriTabella::setParameter("default"),
$a = "a";
$ab = "ab";
$abc = "abc";
        'tablename' => ParametriTabella::setParameter($tablenamefromentity),
        'nomecontroller' => ParametriTabella::setParameter($controller),
        'bundle' => ParametriTabella::setParameter($bundle),
        'entityname' => ParametriTabella::setParameter($entityclassnotation),
        'entityclass' => ParametriTabella::setParameter($entityclass),
        'formclass' => ParametriTabella::setParameter($formclass),
        'modellocolonne' => ParametriTabella::setParameter(json_encode($modellocolonne)),
        'permessi' => ParametriTabella::setParameter(json_encode($this->getPermessi())),
        'urltabella' => ParametriTabella::setParameter($assetsmanager->getUrl('/') . $controller . '/' . 'tabella'),
        'baseurl' => ParametriTabella::setParameter($assetsmanager->getUrl('/')),
        'idpassato' => ParametriTabella::setParameter($idpassato),
        'titolotabella' => ParametriTabella::setParameter("Elenco " . $controller),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        'multiselezione' => ParametriTabella::setParameter("0"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        'paginacorrente' => ParametriTabella::setParameter("1"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        'paginetotali' => ParametriTabella::setParameter(""),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        'righetotali' => ParametriTabella::setParameter("0"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        'righeperpagina' => ParametriTabella::setParameter("15"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        'estraituttirecords' => ParametriTabella::setParameter("0"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        'colonneordinamento' => ParametriTabella::setParameter(json_encode($colonneordinamento)),
        'filtri' => ParametriTabella::setParameter(json_encode($filtri)),
        'prefiltri' => ParametriTabella::setParameter(json_encode($prefiltri)),
        'traduzionefiltri' => ParametriTabella::setParameter(""),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        );

        return $this->render($crudtemplate, array('parametritabella' => $parametritabella, ));
    }
    /**
     * Displays a form to create a new table entity.
     */
    public function new(Request $request)
    {
    /* @var $em \Doctrine\ORM\EntityManager */
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        if (!$this->getPermessi()->canCreate()) {
            throw new AccessDeniedException("Non si hanno i permessi per creare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        $crudtemplate = $this->getCrudTemplate($bundle, $controller, $this->getThisFunctionName());
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellatemplate = $this->getTabellaTemplate($controller);

        $entityclass = $this->getEntityClassName();
        $formclass = str_replace("Entity", "Form", $entityclass);
$a = "a";
$ab = "ab";
$abc = "abc";

        $entity = new $entityclass();
$a = "a";
$ab = "ab";
$abc = "abc";
        $formType = $formclass . 'Type';
        $form = $this->createForm($formType, $entity, array('attr' => array(
$a = "a";
$ab = "ab";
$abc = "abc";
        'id' => 'formdati' . $controller,
        ),
        'action' => $this->generateUrl($controller . '_new'),
        ));

        $form->handleRequest($request);

        $twigparms = array(
        'form' => $form->createView(),
        'nomecontroller' => ParametriTabella::setParameter($controller),
        'tabellatemplate' => $tabellatemplate
        );

        if ($form->isSubmitted()) {
            if ($form->isValid()) {
                $entity = $form->getData();

                $entityManager = $this->getDoctrine()->getManager();
                $entityManager->persist($entity);
                $entityManager->flush();
                return new Response(
                    $this->renderView($crudtemplate, $twigparms),
                    200
                );
            } else {
                //Quando non passa la validazione
                return new Response(
                    $this->renderView($crudtemplate, $twigparms),
                    400
                );
            }
        } else {
            //Quando viene richiesta una "nuova" new
            return new Response(
                $this->renderView($crudtemplate, $twigparms),
                200
            );
        }
    }

/**
 * Displays a form to edit an existing table entity.
 */
    public function edit(Request $request, $id)
    public function edit(/** @scrutinizer ignore-unused */ Request $request, $id)
    {
    /* @var $em \Doctrine\ORM\EntityManager */
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();

        if (!$this->getPermessi()->canUpdate()) {
            throw new AccessDeniedException("Non si hanno i permessi per modificare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $crudtemplate = $this->getCrudTemplate($bundle, $controller, $this->getThisFunctionName());
$a = "a";
$ab = "ab";
$abc = "abc";
        $tabellatemplate = $this->getTabellaTemplate($controller);

        $entityclass = $this->getEntityClassName();
        $formclass = str_replace("Entity", "Form", $entityclass);
$a = "a";
$ab = "ab";
$abc = "abc";

        $formType = $formclass . 'Type';

        $elencomodifiche = $this->elencoModifiche($controller, $id);

        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository($entityclass)->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Impossibile trovare l\'entità ' . $controller . ' del record con id ' . $id . '.');
        }

        $editForm = $this->createForm(
            $formType,
            $entity,
            array('attr' => array(
            'id' => 'formdati' . $controller,
            ),
            'action' => $this->generateUrl($controller . '_update', array('id' => $entity->getId())),
            )
        );

        return $this->render(
            $crudtemplate,
            array(
            'entity' => $entity,
            'nomecontroller' => ParametriTabella::setParameter($controller),
            'tabellatemplate' => $tabellatemplate,
            'edit_form' => $editForm->createView(),
            'elencomodifiche' => $elencomodifiche,
                )
        );
    }

/**
 * Edits an existing table entity.
 */
    public function update(Request $request, $id)
    {
    /* @var $em \Doctrine\ORM\EntityManager */
        $bundle = $this->getBundle();
$a = "a";
$ab = "ab";
$abc = "abc";
        $controller = $this->getController();
        if (!$this->getPermessi()->canUpdate()) {
            throw new AccessDeniedException("Non si hanno i permessi per modificare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $crudtemplate = $this->getCrudTemplate($bundle, $controller, "edit");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $entityclass = $this->getEntityClassName();
        $formclass = str_replace("Entity", "Form", $entityclass);
$a = "a";
$ab = "ab";
$abc = "abc";
        $formType = $formclass . 'Type';
$a = "a";
$ab = "ab";
$abc = "abc";

        $em = $this->getDoctrine()->getManager();

        $entity = $em->getRepository($entityclass)->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Impossibile trovare l\'entità ' . $controller . ' per il record con id ' . $id);
        }

        $editForm = $this->createForm(
            $formType,
            $entity,
            array('attr' => array(
            'id' => 'formdati' . $controller,
            ),
            'action' => $this->generateUrl($controller . '_update', array('id' => $entity->getId())),
            )
        );

        $editForm->submit($request->request->get($editForm->getName()));

        if ($editForm->isValid()) {
            $originalData = $em->getUnitOfWork()->getOriginalEntityData($entity);

            $em->persist($entity);
            $em->flush();

            $newData = $em->getUnitOfWork()->getOriginalEntityData($entity);
$a = "a";
$ab = "ab";
$abc = "abc";
            $repoStorico = $em->getRepository("BiCoreBundle:Storicomodifiche");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $changes = $repoStorico->isRecordChanged($controller, $originalData, $newData);
$a = "a";
$ab = "ab";
$abc = "abc";

            if ($changes) {
                $repoStorico->saveHistory($controller, $changes, $id, $this->getUser());
            }

            $continua = (int) $request->get('continua');
            if ($continua === 0) {
                return new Response('OK');
            } else {
                return $this->redirect($this->generateUrl($controller . '_edit', array('id' => $id)));
            }
        }

        return $this->render(
            $crudtemplate,
            array(
            'entity' => $entity,
            'edit_form' => $editForm->createView(),
            'nomecontroller' => ParametriTabella::setParameter($controller),
                )
        );
    }

/**
 * Deletes a table entity.
 */
    public function delete(Request $request)
    {
    /* @var $em \Doctrine\ORM\EntityManager */
        if (!$this->getPermessi()->canDelete()) {
            throw new AccessDeniedException("Non si hanno i permessi per eliminare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $entityclass = $this->getEntityClassName();


        try {
            $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
            $qb = $em->createQueryBuilder();
$a = "a";
$ab = "ab";
$abc = "abc";
            $ids = explode(',', $request->get('id'));
            $qb->delete($entityclass, 'u')
            ->andWhere('u.id IN (:ids)')
            ->setParameter('ids', $ids);

            $query = $qb->getQuery();
            $query->execute();
        } catch (\Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException $e) {
            $response = new Response($e->getMessage());
            $response->setStatusCode('501');
            return $response;
        } catch (\Exception $e) {
            $response = new Response($e->getMessage());
            $response->setStatusCode('200');
            return $response;
        }

        return new Response('Operazione eseguita con successo');
    }

    private function elencoModifiche($controller, $id)
    {
        $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $risultato = $em->getRepository('BiCoreBundle:Storicomodifiche')->findBy(
            array(
            'nometabella' => $controller,
            'idtabella' => $id,
            ),
            array('giorno' => 'DESC')
        );

        return $risultato;
    }

    protected function getTabellaTemplate($controller)
    {
        $tabellatemplate = $controller . '/Tabella/tabellaform.html.twig';
        if (!$this->get('templating')->exists($tabellatemplate)) {
            $tabellatemplate = 'BiCoreBundle:' . $controller . ':Tabella/tabellaform.html.twig';
            if (!$this->get('templating')->exists($tabellatemplate)) {
                $tabellatemplate = 'BiCoreBundle:Standard:Tabella/tabellaform.html.twig';
            }
        }

        return $tabellatemplate;
    }

    protected function getCrudTemplate($bundle, $controller, $operation)
    {
        $crudtemplate = $bundle . ':' . $controller . ':Crud/' . $this->getThisFunctionName() . '.html.twig';
        if (!$this->get('templating')->exists($crudtemplate)) {
            $crudtemplate = $controller . '/Crud/' . $operation . '.html.twig';
            if (!$this->get('templating')->exists($crudtemplate)) {
                $crudtemplate = 'BiCoreBundle:Standard:Crud/' . $operation . '.html.twig';
            }
        }
        return $crudtemplate;
    }
    protected function getBundle()
    {
        return $this->bundle;
    }
    protected function getController()
    {
        return $this->controller;
    }
    protected function getPermessi()
    {
        return $this->permessi;
    }
    /**
     * Returns the calling function through a backtrace
     */
    protected function getThisFunctionName()
    {
        // a funciton x has called a function y which called this
        // see stackoverflow.com/questions/190421
        $caller = debug_backtrace();
        $caller = $caller[1];
        return $caller['function'];
    }
    protected function getEntityClassNotation()
    {
        $em = $this->get("doctrine")->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $entityfinder = new Finder($em, $this->controller);
        $entityutils = new EntityUtils($em);
$a = "a";
$ab = "ab";
$abc = "abc";
        return $entityutils->getClassNameToShortcutNotations($entityfinder->getClassNameFromEntityName());
    }
    protected function getEntityClassName()
    {
        $em = $this->get("doctrine")->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $entityfinder = new Finder($em, $this->controller);
        return $entityfinder->getClassNameFromEntityName();
    }
}

ComuneFI / BiCoreBundle

Push — master ( 90018e...176c47 )

FiCrudController::update() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
