PannelloAmministrazioneUtils - Code Metrics - Inspection of "add tests" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 90018e...176c47 )

by Andrea

created 2018-11-24 21:53 UTC

PannelloAmministrazioneUtils A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Test Coverage

Coverage

96.77%

Importance

Changes

Metric	Value
eloc	30
dl	0
loc	57
ccs	30
cts	31
cp	0.9677
rs	10
c	0
b	0
f	0
wmc	7

4 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	runSymfonyCommand()	13	2
A	clearcache()	12	2
A	runCommand()	19	2

<?php

namespace Cdf\PannelloAmministrazioneBundle\DependencyInjection;

use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Component\Console\Output\BufferedOutput;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Process\Process;
use Fi\OsBundle\DependencyInjection\OsFunctions;

class PannelloAmministrazioneUtils
{

    private $container;
    private $apppaths;

    public function __construct($container)
    {
        $this->container = $container;
        $this->apppaths = $container->get("pannelloamministrazione.projectpath");
$a = "a";
$ab = "ab";
$abc = "abc";
    }
    public function clearcache($env = "")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    {
        if (!$env) {
            $env = $this->container->get('kernel')->getEnvironment();
        }

        $phpPath = OsFunctions::getPHPExecutableFromPath();

        $command = $phpPath . ' ' . $this->apppaths->getConsole() . ' cache:clear '
                . '--env=' . $env;

        return self::runCommand($command);
    }
    public static function runCommand($command)
    {
        /* @var $process \Symfony\Component\Process\Process */
        $process = new Process($command);
        $process->setTimeout(60 * 60 * 24);
        $process->run();

        if (!$process->isSuccessful()) {
            $return = array("errcode" => -1,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "command" => $command,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "message" => 'Errore nel comando ' . $command . "\n" . $process->getErrorOutput() . "\n" . $process->getOutput());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        } else {
            $return = array("errcode" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "command" => $command,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "message" => $process->getOutput()
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            );
        }

        return $return;
    }
    public function runSymfonyCommand($command, array $options = array())
    {
        $application = new Application($this->container->get('kernel'));
        $application->setAutoExit(false);

        $cmdoptions = array_merge(array('command' => $command), $options);

        $outputbuf = new BufferedOutput();
        // return the output, don't use if you used NullOutput()
        $returncode = $application->run(new ArrayInput($cmdoptions), $outputbuf);
        $output = $outputbuf->fetch();
$a = "a";
$ab = "ab";
$abc = "abc";

        return array('errcode' => ($returncode == 0 ? 0 : 1), 'command' => $cmdoptions['command'], 'message' => $output);
    }
}


1		<?php
2
3		namespace Cdf\PannelloAmministrazioneBundle\DependencyInjection;
4
5		use Symfony\Bundle\FrameworkBundle\Console\Application;
6		use Symfony\Component\Console\Output\BufferedOutput;
7		use Symfony\Component\Console\Input\ArrayInput;
8		use Symfony\Component\Process\Process;
9		use Fi\OsBundle\DependencyInjection\OsFunctions;
10
11		class PannelloAmministrazioneUtils
12		{
13
14		private $container;
15		private $apppaths;
16
17	1	public function __construct($container)
18		{
19	1	$this->container = $container;
20	1	$this->apppaths = $container->get("pannelloamministrazione.projectpath");
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `pannelloamministrazione.projectpath` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
21	1	}
22	1	public function clearcache($env = "")
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
23		{
24	1	if (!$env) {
25		$env = $this->container->get('kernel')->getEnvironment();
26		}
27
28	1	$phpPath = OsFunctions::getPHPExecutableFromPath();
29
30	1	$command = $phpPath . ' ' . $this->apppaths->getConsole() . ' cache:clear '
31	1	. '--env=' . $env;
32
33	1	return self::runCommand($command);
34		}
35	1	public static function runCommand($command)
36		{
37		/* @var $process \Symfony\Component\Process\Process */
38	1	$process = new Process($command);
39	1	$process->setTimeout(60 * 60 * 24);
40	1	$process->run();
41
42	1	if (!$process->isSuccessful()) {
43	1	$return = array("errcode" => -1,
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `errcode` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
44	1	"command" => $command,
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `command` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
45	1	"message" => 'Errore nel comando ' . $command . "\n" . $process->getErrorOutput() . "\n" . $process->getOutput());
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `message` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
46		} else {
47	1	$return = array("errcode" => 0,
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `errcode` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
48	1	"command" => $command,
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `command` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
49	1	"message" => $process->getOutput()
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `message` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
50		);
51		}
52
53	1	return $return;
54		}
55	1	public function runSymfonyCommand($command, array $options = array())
56		{
57	1	$application = new Application($this->container->get('kernel'));
58	1	$application->setAutoExit(false);
59
60	1	$cmdoptions = array_merge(array('command' => $command), $options);
61
62	1	$outputbuf = new BufferedOutput();
63		// return the output, don't use if you used NullOutput()
64	1	$returncode = $application->run(new ArrayInput($cmdoptions), $outputbuf);
65	1	$output = $outputbuf->fetch();
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
66
67	1	return array('errcode' => ($returncode == 0 ? 0 : 1), 'command' => $cmdoptions['command'], 'message' => $output);
68		}
69		}
70

ComuneFI / BiCoreBundle

Push — master ( 90018e...176c47 )

PannelloAmministrazioneUtils A

Complexity

Size/Duplication

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like