AssetExtension::assetExists() - Code Metrics - Inspection of "Merge branch 'release/v0.1.7'" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b45e96...d0c0b5 )

by Andrea

created 2018-11-23 11:05 UTC

AssetExtension::assetExists() A

↳ Parent: AssetExtension

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.4746

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	3
nop	1
dl	0
loc	16
ccs	5
cts	8
cp	0.625
crap	3.4746
rs	10
c	0
b	0
f	0

<?php

namespace Cdf\BiCoreBundle\Twig\Extension;

use Symfony\Component\HttpKernel\KernelInterface;
use Doctrine\Common\Persistence\ObjectManager;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;

class AssetExtension extends \Twig_Extension
{

    private $kernel;

    public function __construct(KernelInterface $kernel)
    {
        $this->kernel = $kernel;
    }

    public function getFunctions()
    {
        return [new \Twig_SimpleFunction('asset_exists', [$this, 'assetExists'], ['is_safe' => ['html']])];
    }

    public function assetExists($path)
    {
        $publicRoot = realpath($this->kernel->getRootDir() . '/../public/') . DIRECTORY_SEPARATOR;
        $toCheck = realpath($publicRoot . $path);
$a = "a";
$ab = "ab";
$abc = "abc";
        
        // check if the file exists
        if (!is_file($toCheck)) {
            return false;
        }

        // check if file is well contained in web/ directory (prevents ../ in paths)
        if (strncmp($publicRoot, $toCheck, strlen($publicRoot)) !== 0) {
            return false;
        }

        return true;
    }

    public function getName()
    {
        return 'asset_exists';
    }
}


1		<?php
2
3		namespace Cdf\BiCoreBundle\Twig\Extension;
4
5		use Symfony\Component\HttpKernel\KernelInterface;
6		use Doctrine\Common\Persistence\ObjectManager;
7		use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
8		use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
9
10		class AssetExtension extends \Twig_Extension
11		{
12
13		private $kernel;
14
15	14	public function __construct(KernelInterface $kernel)
16		{
17	14	$this->kernel = $kernel;
18	14	}
19
20		public function getFunctions()
21		{
22		return [new \Twig_SimpleFunction('asset_exists', [$this, 'assetExists'], ['is_safe' => ['html']])];
23		}
24
25	7	public function assetExists($path)
26		{
27	7	$publicRoot = realpath($this->kernel->getRootDir() . '/../public/') . DIRECTORY_SEPARATOR;
28	7	$toCheck = realpath($publicRoot . $path);
		0 ignored issues – show Coding Style introduced 2018-11-23 11:19 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29
30		// check if the file exists
31	7	if (!is_file($toCheck)) {
32	7	return false;
33		}
34
35		// check if file is well contained in web/ directory (prevents ../ in paths)
36		if (strncmp($publicRoot, $toCheck, strlen($publicRoot)) !== 0) {
37		return false;
38		}
39
40		return true;
41		}
42
43		public function getName()
44		{
45		return 'asset_exists';
46		}
47		}
48

ComuneFI / BiCoreBundle

Push — master ( b45e96...d0c0b5 )

AssetExtension::assetExists() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like