FiTabellaController::aggiorna() - Code Metrics - Inspection of "endiinline" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 75e02f...5245b1 )

by Andrea

created 2018-11-30 17:06 UTC

FiTabellaController::aggiorna() B

↳ Parent: FiTabellaController

Complexity

Conditions	11
Paths	37

Size

Total Lines	66
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	132

Importance

Changes

Metric	Value
cc	11
eloc	45
nc	37
nop	2
dl	0
loc	66
ccs	0
cts	41
cp	0
crap	132
rs	7.3166
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Cdf\BiCoreBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Cdf\BiCoreBundle\Utils\Export\TabellaXls;
use Cdf\BiCoreBundle\Utils\Tabella\Tabella;
use Cdf\BiCoreBundle\Utils\Tabella\ParametriTabella;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

class FiTabellaController extends FiCrudController
{

    public function tabella(Request $request)
    {
        if (!$this->permessi->canRead()) {
            throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $doctrine = $this->get("doctrine");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        //$em = $doctrine->getManager();


        $parametripassati = array_merge($request->get("parametri"), array('user' => $this->getUser()));
$a = "a";
$ab = "ab";
$abc = "abc";
        $parametriform = isset($parametripassati["parametriform"]) ?
$a = "a";
$ab = "ab";
$abc = "abc";
                json_decode(ParametriTabella::getParameter($parametripassati["parametriform"]), true) : array();
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $configurazionetabella = new Tabella($doctrine, $parametripassati);
        $parametritabella = array(
$a = "a";
$ab = "ab";
$abc = "abc";
            'parametritabella' => $configurazionetabella->getConfigurazionecolonnetabella(),
            'recordstabella' => $configurazionetabella->getRecordstabella(),
            'paginacorrente' => $configurazionetabella->getPaginacorrente(),
            'paginetotali' => $configurazionetabella->getPaginetotali(),
            'righetotali' => $configurazionetabella->getRighetotali(),
            'traduzionefiltri' => $configurazionetabella->getTraduzionefiltri(),
        );
        $classbundle = ParametriTabella::getParameter($parametripassati["entityclass"]);
$a = "a";
$ab = "ab";
$abc = "abc";
        //$formbundle = $namespace . '\\' . $bundle . 'Bundle' . '\\Form\\' . $controller;
        $formbundle = ParametriTabella::getParameter($parametripassati["formclass"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $formType = $formbundle . 'Type';
$a = "a";
$ab = "ab";
$abc = "abc";

        $entity = new $classbundle();
        //$tablename = ParametriTabella::getParameter($parametripassati["tablename"]);

        $controller = ParametriTabella::getParameter($parametripassati["nomecontroller"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $form = $this->createForm(
$a = "a";
$ab = "ab";
$abc = "abc";
            $formType,
            $entity,
            array('attr' => array(
                'id' => 'formdati' . $controller,
                ),
                'action' => $this->generateUrl($controller . '_new'),
                "parametriform" => $parametriform
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                )
        );

        $parametri = array_merge($parametripassati, $parametritabella);
$a = "a";
$ab = "ab";
$abc = "abc";
        $parametri["form"] = $form->createView();
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $template = $controller . '/Tabella/tabellacontainer.html.twig';
$a = "a";
$ab = "ab";
$abc = "abc";
        $templatelocation = $controller . "/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if (!$this->get('templating')->exists($template)) {
            $template = "BiCoreBundle:" . $controller . ':Tabella/tabellacontainer.html.twig';
$a = "a";
$ab = "ab";
$abc = "abc";
            $templatelocation = "BiCoreBundle:" . $controller . ":";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            if (!$this->get('templating')->exists($template)) {
                $templatelocation = 'BiCoreBundle:Standard:';
                $template = $templatelocation . 'Tabella/tabellacontainer.html.twig';
$a = "a";
$ab = "ab";
$abc = "abc";
            }
        }
        $parametri["templatelocation"] = $templatelocation;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        return $this->render(
            $template,
            array(
                    'parametri' => $parametri
                        )
        );
    }

    public function exportXls(Request $request)
    {
        $doctrine = $this->get("doctrine");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        try {
            $parametripassati = array_merge($request->get("parametri"), array('user' => $this->getUser()));
$a = "a";
$ab = "ab";
$abc = "abc";
            $parametripassati["estraituttirecords"] = ParametriTabella::setParameter("1");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $configurazionetabella = new Tabella($doctrine, $parametripassati);
$a = "a";
$ab = "ab";
$abc = "abc";
            $parametritabella = array(
$a = "a";
$ab = "ab";
$abc = "abc";
                'parametritabella' => $configurazionetabella->getConfigurazionecolonnetabella(),
                'recordstabella' => $configurazionetabella->getRecordstabella(),
                'paginacorrente' => $configurazionetabella->getPaginacorrente(),
                'paginetotali' => $configurazionetabella->getPaginetotali(),
                'righetotali' => $configurazionetabella->getRighetotali(),
                'traduzionefiltri' => $configurazionetabella->getTraduzionefiltri(),
                'nomecontroller' => ParametriTabella::getParameter($parametripassati["nomecontroller"]),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            );
            $xls = new TabellaXls($this->container);
$a = "a";
$ab = "ab";
$abc = "abc";
            $filexls = $xls->esportaexcel($parametritabella);
$a = "a";
$ab = "ab";
$abc = "abc";
            if (file_exists($filexls)) {
                $response = array(
                    'status' => '200',
                    'file' => "data:application/vnd.ms-excel;base64," . base64_encode(file_get_contents($filexls))
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                );
                @unlink($filexls);
            } else {
                $response = array(
                    'status' => '501',
                    'file' => "Impossibile generare il file excel"
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                );
            }
        } catch (\Exception $exc) {
            $response = array(
                'status' => '500',
                'file' => $exc->getFile() . " -> Riga: " . $exc->getLine() . " -> " . $exc->getMessage()
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            );
        }

        return new JsonResponse($response);
    }

    private function checkAggiornaRight($id)
    {
        if ($id === 0) {
            if (!$this->getPermessi()->canCreate()) {
                throw new AccessDeniedException("Non si hanno i permessi per creare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
        } else {
            if (!$this->getPermessi()->canUpdate()) {
                throw new AccessDeniedException("Non si hanno i permessi per modificare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
        }
    }

    /**
     * Inline existing table entity.
     */
    public function aggiorna(Request $request, $id)
    {
        $this->checkAggiornaRight($id);

        /* @var $em \Doctrine\ORM\EntityManager */
        $controller = $this->getController();
$a = "a";
$ab = "ab";
$abc = "abc";
        $entityclass = $this->getEntityClassName();
        $this->checkAggiornaRight($id);
        $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $queryBuilder = $em->createQueryBuilder();
        $insert = ($id === 0);
$a = "a";
$ab = "ab";
$abc = "abc";

        if ($insert) {
            //Insert
            $entity = new $entityclass();
            $queryBuilder
                    ->insert($entityclass)
            ;
        } else {
            //Update
            $entity = $em->getRepository($entityclass)->find($id);
            if (!$entity) {
                throw $this->createNotFoundException('Impossibile trovare l\'entità ' . $controller . ' per il record con id ' . $id);
            }
            $queryBuilder
                    ->update($entityclass, "u")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    ->where("u.id = :id")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    ->setParameter("id", $id);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $values = $request->get("values");
$a = "a";
$ab = "ab";
$abc = "abc";
        $querydaeseguire = false;

        foreach ($values as $value) {
            $fieldpieces = explode(".", $value["fieldname"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $table = $fieldpieces[0];
$a = "a";
$ab = "ab";
$abc = "abc";
            //Si prende in considerazione solo i campi strettamente legati a questa entity
            if ($table == $controller && count($fieldpieces) == 2) {
                $field = $fieldpieces[1];
$a = "a";
$ab = "ab";
$abc = "abc";
                $subfieldpieces = explode("_", $field);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                if ($insert) {
                    $queryBuilder->setValue($field, ':' . $field);
                    $queryBuilder->setParameter($field, $value["fieldvalue"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $querydaeseguire = true;
                } else {
                    /**/
                    $nomefunzioneget = "get";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    foreach ($subfieldpieces as $field4get) {
                        $nomefunzioneget .= ucfirst($field4get);
                    }
                    if (method_exists($entity, $nomefunzioneget)) {
                        if ($entity->$nomefunzioneget() != $value["fieldvalue"]) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                            $querydaeseguire = true;
                            $queryBuilder->set("u." . $field, ':' . $field);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                            $queryBuilder->setParameter($field, $value["fieldvalue"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                        }
                    }
                }
            } else {
                continue;
            }
        }
        if ($querydaeseguire) {
            $queryBuilder->getQuery()->execute();
        }

        return new \Symfony\Component\HttpFoundation\JsonResponse(array("errcode" => 0, "message" => "Registrazione eseguita"));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
}


1		<?php
2
3		namespace Cdf\BiCoreBundle\Controller;
4
5		use Symfony\Component\HttpFoundation\Request;
6		use Cdf\BiCoreBundle\Utils\Export\TabellaXls;
7		use Cdf\BiCoreBundle\Utils\Tabella\Tabella;
8		use Cdf\BiCoreBundle\Utils\Tabella\ParametriTabella;
9		use Symfony\Component\HttpFoundation\JsonResponse;
10		use Symfony\Component\Security\Core\Exception\AccessDeniedException;
11
12		class FiTabellaController extends FiCrudController
13		{
14
15	8	public function tabella(Request $request)
16		{
17	8	if (!$this->permessi->canRead()) {
18	1	throw new AccessDeniedException("Non si hanno i permessi per visualizzare questo contenuto");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-24 17:17 UTC by Report Bug Copy Issue Report The string literal `Non si hanno i permessi ...izzare questo contenuto` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
19		}
20	7	$doctrine = $this->get("doctrine");
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `doctrine` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
21		//$em = $doctrine->getManager();
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
22
23	7	$parametripassati = array_merge($request->get("parametri"), array('user' => $this->getUser()));
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report The string literal `parametri` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
24	7	$parametriform = isset($parametripassati["parametriform"]) ?
		0 ignored issues – show Coding Style introduced 2018-11-28 14:18 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2018-11-28 14:18 UTC by Report Bug Copy Issue Report The string literal `parametriform` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
25	7	json_decode(ParametriTabella::getParameter($parametripassati["parametriform"]), true) : array();
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-28 14:18 UTC by Report Bug Copy Issue Report The string literal `parametriform` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
26	7	$configurazionetabella = new Tabella($doctrine, $parametripassati);
27		$parametritabella = array(
		0 ignored issues – show Coding Style introduced 2018-11-17 22:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
28	7	'parametritabella' => $configurazionetabella->getConfigurazionecolonnetabella(),
29	7	'recordstabella' => $configurazionetabella->getRecordstabella(),
30	7	'paginacorrente' => $configurazionetabella->getPaginacorrente(),
31	7	'paginetotali' => $configurazionetabella->getPaginetotali(),
32	7	'righetotali' => $configurazionetabella->getRighetotali(),
33	7	'traduzionefiltri' => $configurazionetabella->getTraduzionefiltri(),

ComuneFI / BiCoreBundle

Push — develop ( 75e02f...5245b1 )

FiTabellaController::aggiorna() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like