View GitHub Repository BiCoreBundle

Schedule Inspection
Subscribe
Passed
Push — master ( 1d619d...8f091f )
by Andrea
16:20
created

Finder   A

↳ Parent: Project

Complexity

Total Complexity 5

Size/Duplication

Total Lines 23
Duplicated Lines 0 %

Test Coverage

Coverage 92.31%

Importance

Changes 0
Metric Value
eloc 12
dl 0
loc 23
ccs 12
cts 13
cp 0.9231
rs 10
c 0
b 0
f 0
wmc 5

2 Methods

Rating   Name   Duplication   Size   Complexity  
A getClassNameFromEntityName() 0 14 4
A __construct() 0 3 1
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Cdf\BiCoreBundle\Utils\Entity;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
use Cdf\BiCoreBundle\Utils\Entity\EntityUtils;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
use Doctrine\Common\Persistence\ObjectManager;

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                

            


            
                                                                        
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
class Finder

            


            
                                                                        
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
{

            


            
                                                                        
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                

            


            
                                                                        
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
    private $em;

            


            
                                                                        
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                

            


            
                                                                        
                            
            
                                    
            
            

                
                    13
                

                                    
                             15                         
                
                
                
    public function __construct(ObjectManager $em)

            


            
                                                                        
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
    {

            


            
                                                                        
                            
            
                                    
            
            

                
                    15
                

                                    
                             15                         
                
                
                
        $this->em = $em;

            


            
                                                                        
                            
            
                                    
            
            

                
                    16
                

                                    
                             15                         
                
                
                
    }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                             15                         
                
                
                
    public function getClassNameFromEntityName($entityname)

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
    {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    19
                

                                    
                             15                         
                
                
                
        $entities = $this->em->getConfiguration()->getMetadataDriverImpl()->getAllClassNames();

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                                                                        
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
The method getConfiguration() does not exist on Doctrine\Common\Persistence\ObjectManager. It seems like you code against a sub-type of said class. However, the method does not exist in Doctrine\Common\Persistence\ObjectManagerDecorator. Are you sure you never get one of those?
                                                                                   (
                                     Ignorable by Annotation
                                )
                                

                                    
 If this is a false-positive, you can also ignore this issue in your code via the ignore-call   annotation

                                    

                                        

                                            19
                                            
                                                
        $entities = $this->em->/** @scrutinizer ignore-call */ getConfiguration()->getMetadataDriverImpl()->getAllClassNames();

                                        

                                                                            

                                

                                                                                                                                                                                                                                    

                    
                                                    

                     Loading history...
                

                    


    




                                                                                            




    

        
            Coding Style
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space
                                                                                                                                                    

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for multiple assignments in successive lines of code.
It will report an issue if the operators are not in a straight line.


To visualize


$a = "a";
$ab = "ab";
$abc = "abc";





will produce issues in the first and second line, while this second example


$a   = "a";
$ab  = "ab";
$abc = "abc";





will produce no issues.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                            
            
                                    
            
            

                
                    20
                

                                    
                             15                         
                
                
                
        $entityclassname = "";

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Comprehensibility
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The string literal  does not require double quotes, as per coding-style, please use single quotes.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
PHP provides two ways to mark string literals. Either with single quotes 'literal' or with
double quotes "literal". The difference between these is that string literals in double quotes
may contain variables with are evaluated at run-time as well as escape sequences.


String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself (\') and the
backslash (\\). Every other character is displayed as is.


Double quoted string literals may contain other variables or more complex escape sequences.


<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;





will print an indented: Single is Value


If your string literal does not contain variables or escape sequences, it should be defined
using single quotes to make that fact clear.


For more information on PHP string literals and available escape sequences see the PHP core
documentation.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                            
            
                                    
            
            

                
                    21
                

                                    
                             15                         
                
                
                
        foreach ($entities as $entity) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    22
                

                                    
                             15                         
                
                
                
            $parti = explode("\\", $entity);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Comprehensibility
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The string literal \\ does not require double quotes, as per coding-style, please use single quotes.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
PHP provides two ways to mark string literals. Either with single quotes 'literal' or with
double quotes "literal". The difference between these is that string literals in double quotes
may contain variables with are evaluated at run-time as well as escape sequences.


String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself (\') and the
backslash (\\). Every other character is displayed as is.


Double quoted string literals may contain other variables or more complex escape sequences.


<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;





will print an indented: Single is Value


If your string literal does not contain variables or escape sequences, it should be defined
using single quotes to make that fact clear.


For more information on PHP string literals and available escape sequences see the PHP core
documentation.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                            
            
                                    
            
            

                
                    23
                

                                    
                             15                         
                
                
                
            if ($parti[count($parti) - 1] == $entityname) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    24
                

                                    
                             15                         
                
                
                
                $entityclassname = $entity;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
            }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
        }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    27
                

                                    
                             15                         
                
                
                
        if (!$entityclassname) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
            throw new \Exception("Non riesco a trovare l'entità '" . $entityname . "', è stata generata?");

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
        }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    30
                

                                    
                             15                         
                
                
                
        return $entityclassname;

            


            
                                                                        
                                                                
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
    }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    33