FiCoreCrudInlineControllerTrait::updateinline() - Code Metrics - Inspection of "Upgrade yarn v3" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — develop ( 51f67e...bde052 )

by Andrea
created 2022-02-09 15:39 UTC
FiCoreCrudInlineControllerTrait::updateinline() B

↳ Parent: FiCoreCrudInlineControllerTrait
Complexity

Conditions	8
Paths	13
Size

Total Lines	50
Code Lines	32
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	29
CRAP Score	8.017
Importance

Changes
Metric	Value
cc	8
eloc	32
nc	13
nop	3
dl	0
loc	50
ccs	29
cts	31
cp	0.9355
crap	8.017
rs	8.1635
c	0
b	0
f	0
<?php

namespace Cdf\BiCoreBundle\Controller;

use Cdf\BiCoreBundle\Utils\Entity\EntityUtils;
use Cdf\BiCoreBundle\Utils\Entity\Finder;

use function count;

use DateTime;
use Doctrine\ORM\EntityManager;
use Exception;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\PropertyAccess\PropertyAccess;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

trait FiCoreCrudInlineControllerTrait
{

    /**
     *
     * @param string $id
     * @param string $token
     * @throws AccessDeniedException
     */
    private function checkAggiornaRight($id, $token): void
    {
        if (0 === (int) $id) {
            if (!$this->getPermessi()->canCreate($this->getController())) {
            if (!$this->/** @scrutinizer ignore-call */ getPermessi()->canCreate($this->getController())) {
                throw new AccessDeniedException('Non si hanno i permessi per creare questo contenuto');
            }
        } else {
            if (!$this->getPermessi()->canUpdate($this->getController())) {
                throw new AccessDeniedException('Non si hanno i permessi per modificare questo contenuto');
            }
        }
        $isValidToken = $this->isCsrfTokenValid($this->getController(), $token) || $this->isCsrfTokenValid($id, $token);
        $isValidToken = $this->/** @scrutinizer ignore-call */ isCsrfTokenValid($this->getController(), $token) || $this->isCsrfTokenValid($id, $token);

        if (!$isValidToken) {
            throw $this->createNotFoundException('Token non valido');
            throw $this->/** @scrutinizer ignore-call */ createNotFoundException('Token non valido');
        }
    }

    /**
     * Inline existing table entity.
     * @param string $id
     * @param string $token
     */
    public function aggiorna(Request $request, $id, $token): JsonResponse
    {
        $this->checkAggiornaRight($id, $token);
        $values = $request->get('values');

        if (0 == $id) {
            $risultato = $this->insertinline($values, $token);
        } else {
            $risultato = $this->updateinline($id, $values, $token);
        }
        return $risultato;
    }

    /**
     *
     * @param mixed[] $values fileds
     * @param string $token CSRF token
     * @return JsonResponse
     * @throws Exception
     */
    protected function insertinline($values, $token): JsonResponse
    {
        $this->checkAggiornaRight("0", $token);

        /* @var $this->em EntityManager */
        $controller = $this->getController();
        $entityclass = $this->getEntityClassName();
        $entityclass = $this->getEntityClassName();

        //Insert
        $entity = new $entityclass();

        $accessor = PropertyAccess::createPropertyAccessor();
        foreach ($values as $value) {
            $fieldpieces = explode('.', $value['fieldname']);
            $table = $fieldpieces[0];
            //Si prende in considerazione solo i campi strettamente legati a questa entity
            if ($table == $controller && 2 == count($fieldpieces)) {
                $field = ucfirst($fieldpieces[1]);
                $fieldvalue = $this->getValueAggiorna($value);
                if ('join' == $value['fieldtype']) {
                    $entityfinder = new Finder($this->em);
                    $joinclass = $entityfinder->getClassNameFromEntityName($field);
                    /** @var class-string $joinclass */
                    $fieldvalue = $this->em->getRepository($joinclass)->find($fieldvalue);
                }

                if ($accessor->isWritable($entity, $field)) {
                    $accessor->setValue($entity, $field, $fieldvalue);
                } else {
                    throw new Exception($field . ' non modificabile');
                }
            } else {
                continue;
            }
        }
        $this->em->persist($entity);
        $this->em->flush();
        $this->em->clear();

        return new JsonResponse(['errcode' => 0, 'message' => 'Registrazione eseguita']);
    }

    /**
     *
     * @param string $id
     * @param mixed[] $values fileds
     * @param string $token
     * @return JsonResponse
     */
    protected function updateinline($id, $values, $token): JsonResponse
    {
        $this->checkAggiornaRight($id, $token);

        /* @var $this->em EntityManager */
        $controller = $this->getController();
        $entityclass = $this->getEntityClassName();

        $queryBuilder = $this->em->createQueryBuilder();

        //Update
        /** @var class-string $entityclass */
        $entity = $this->em->getRepository($entityclass)->find($id);
        if (!$entity) {
            throw $this->createNotFoundException('Impossibile trovare l\'entità ' . $controller . ' per il record con id ' . $id);
        }
        $queryBuilder
                ->update($entityclass, 'u')
                ->where('u.id = :id')
                ->setParameter('id', $id);

        $querydaeseguire = false;

        foreach ($values as $value) {
            $fieldpieces = explode('.', $value['fieldname']);
            $table = $fieldpieces[0];
            //Si prende in considerazione solo i campi strettamente legati a questa entity
            if ($table == $controller && 2 == count($fieldpieces)) {
                $field = $fieldpieces[1];
                if ('join' == $value['fieldtype']) {
                    $field = lcfirst($field . '_id');
                }
                $entityutils = new EntityUtils($this->em);
                $property = $entityutils->getEntityProperties($field, $entity);
                $nomefunzioneget = $property['get'];
                if ($nomefunzioneget != $value['fieldvalue']) {
                    $querydaeseguire = true;
                    $fieldvalue = $this->getValueAggiorna($value);
                    $queryBuilder->set('u.' . $field, ':' . $field);
                    $queryBuilder->setParameter($field, $fieldvalue);
                }
            } else {
                continue;
            }
        }
        if ($querydaeseguire) {
            $queryBuilder->getQuery()->execute();
        }

        return new JsonResponse(['errcode' => 0, 'message' => 'Registrazione eseguita']);
    }

    /**
     *
     * @param string[] $field
     * @return mixed
     * @throws Exception
     */
    private function getValueAggiorna($field)
    {
        $fieldvalue = $field['fieldvalue'];
        if ('' == $fieldvalue) {
            $fieldvalue = null;
        } else {
            $fieldtype = $field['fieldtype'];
            if ('boolean' == $fieldtype) {
                $fieldvalue = !('false' === $field['fieldvalue']);
            }
            if ('date' == $fieldtype) {
                $fieldvalue = DateTime::createFromFormat('d/m/Y', $field['fieldvalue']);
                if (false === $fieldvalue) {
                    throw new Exception('Formato data non valido');
                }
            }
            if ('datetime' == $fieldtype) {
                $fieldvalue = DateTime::createFromFormat('d/m/Y H:i', $field['fieldvalue']);
                if (false === $fieldvalue) {
                    throw new Exception('Formato data ora non valido');
                }
            }
        }

        return $fieldvalue;
    }
}

ComuneFI / BiCoreBundle

Push — develop ( 51f67e...bde052 )

FiCoreCrudInlineControllerTrait::updateinline() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
