FiCoreCrudInlineControllerTrait::insertinline() - Code Metrics - Inspection of "Merge branch 'release/v0.1.35'" - ComuneFI/BiCoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 9e253e...de67a0 )

by Andrea
created 2018-12-12 14:32 UTC
FiCoreCrudInlineControllerTrait::insertinline() B

↳ Parent: FiCoreCrudInlineControllerTrait
Complexity

Conditions	8
Paths	11
Size

Total Lines	55
Code Lines	32
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	72
Importance

Changes
Metric	Value
cc	8
eloc	32
nc	11
nop	2
dl	0
loc	55
ccs	0
cts	31
cp	0
crap	72
rs	8.1635
c	0
b	0
f	0
How to fix Long Method

<?php

namespace Cdf\BiCoreBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Cdf\BiCoreBundle\Utils\Entity\EntityUtils;
use Symfony\Component\PropertyAccess\PropertyAccess;
use Cdf\BiCoreBundle\Utils\Entity\Finder;

trait FiCoreCrudInlineControllerTrait
{

    private function checkAggiornaRight($id)
    {
        if ($id === 0) {
            if (!$this->getPermessi()->canCreate()) {
            if (!$this->/** @scrutinizer ignore-call */ getPermessi()->canCreate()) {
                throw new AccessDeniedException("Non si hanno i permessi per creare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
        } else {
            if (!$this->getPermessi()->canUpdate()) {
                throw new AccessDeniedException("Non si hanno i permessi per modificare questo contenuto");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
        }
    }

    /**
     * Inline existing table entity.
     */
    public function aggiorna(Request $request, $id, $token)
    {
        $this->checkAggiornaRight($id);
        $values = $request->get("values");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        if ($id == 0) {
            $risultato = $this->insertinline($values, $token);
        } else {
            $risultato = $this->updateinline($id, $values, $token);
        }

        return $risultato;
    }

    protected function insertinline($values, $token)
    {

        $this->checkAggiornaRight(0);

        /* @var $em \Doctrine\ORM\EntityManager */
        $controller = $this->getController();
        $controller = $this->getController();
        $entityclass = $this->getEntityClassName();
        $entityclass = $this->getEntityClassName();

        $em = $this->getDoctrine()->getManager();
        $em = $this->/** @scrutinizer ignore-call */ getDoctrine()->getManager();

        //Insert
        $entity = new $entityclass();


        $isValidToken = $this->isCsrfTokenValid(0, $token);
        $isValidToken = $this->isCsrfTokenValid(0, $token);

        if (!$isValidToken) {
            throw $this->createNotFoundException('Token non valido');
            throw $this->/** @scrutinizer ignore-call */ createNotFoundException('Token non valido');
        }

        $querydaeseguire = false;
        $accessor = PropertyAccess::createPropertyAccessor();
$a = "a";
$ab = "ab";
$abc = "abc";
        foreach ($values as $value) {
            $fieldpieces = explode(".", $value["fieldname"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $table = $fieldpieces[0];
$a = "a";
$ab = "ab";
$abc = "abc";
            //Si prende in considerazione solo i campi strettamente legati a questa entity
            if ($table == $controller && count($fieldpieces) == 2) {
                $field = ucfirst($fieldpieces[1]);
$a = "a";
$ab = "ab";
$abc = "abc";
                $fieldvalue = $this->getValueAggiorna($value);
                if ($value["fieldtype"] == 'join') {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $entityfinder = new Finder($em, $field);
                    $joinclass = $entityfinder->getClassNameFromEntityName();
$a = "a";
$ab = "ab";
$abc = "abc";
                    $fieldvalue = $em->getRepository($joinclass)->find($fieldvalue);
$a = "a";
$ab = "ab";
$abc = "abc";
                }


                if ($accessor->isWritable($entity, $field)) {
                    $accessor->setValue($entity, $field, $fieldvalue);
                } else {
                    throw new \Exception($field . ' non modificabile');
                }

                $querydaeseguire = true;
            } else {
                continue;
            }
        }
        if ($querydaeseguire) {
            $em->persist($entity);
            $em->flush();
            $em->clear();
        }

        return new \Symfony\Component\HttpFoundation\JsonResponse(array("errcode" => 0, "message" => "Registrazione eseguita"));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }

    protected function updateinline($id, $values, $token)
    {

        $this->checkAggiornaRight($id);

        /* @var $em \Doctrine\ORM\EntityManager */
        $controller = $this->getController();
$a = "a";
$ab = "ab";
$abc = "abc";
        $entityclass = $this->getEntityClassName();

        $em = $this->getDoctrine()->getManager();
$a = "a";
$ab = "ab";
$abc = "abc";
        $queryBuilder = $em->createQueryBuilder();

        //Update
        $entity = $em->getRepository($entityclass)->find($id);
        if (!$entity) {
            throw $this->createNotFoundException('Impossibile trovare l\'entità ' . $controller . ' per il record con id ' . $id);
        }
        $queryBuilder
                ->update($entityclass, "u")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                ->where("u.id = :id")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                ->setParameter("id", $id);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $isValidToken = $this->isCsrfTokenValid($id, $token);

        if (!$isValidToken) {
            throw $this->createNotFoundException('Token non valido');
        }

        $querydaeseguire = false;

        foreach ($values as $value) {
            $fieldpieces = explode(".", $value["fieldname"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $table = $fieldpieces[0];
$a = "a";
$ab = "ab";
$abc = "abc";
            //Si prende in considerazione solo i campi strettamente legati a questa entity
            if ($table == $controller && count($fieldpieces) == 2) {
                $field = $fieldpieces[1];
                if ($value["fieldtype"] == 'join') {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $field = lcfirst($field . "_id");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }
                $entityutils = new EntityUtils($em);
$a = "a";
$ab = "ab";
$abc = "abc";
                $property = $entityutils->getEntityProperties($field, $entity);
$a = "a";
$ab = "ab";
$abc = "abc";
                $nomefunzioneget = $property["get"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                if ($nomefunzioneget != $value["fieldvalue"]) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $querydaeseguire = true;
                    $fieldvalue = $this->getValueAggiorna($value);
$a = "a";
$ab = "ab";
$abc = "abc";
                    $queryBuilder->set("u." . $field, ':' . $field);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    $queryBuilder->setParameter($field, $fieldvalue);
                }
            } else {
                continue;
            }
        }
        if ($querydaeseguire) {
            $queryBuilder->getQuery()->execute();
        }

        return new \Symfony\Component\HttpFoundation\JsonResponse(array("errcode" => 0, "message" => "Registrazione eseguita"));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }

    private function getValueAggiorna($field)
    {
        $fieldvalue = $field["fieldvalue"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if ($fieldvalue == '') {
            $fieldvalue = null;
        } else {
            $fieldtype = $field["fieldtype"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            if ($fieldtype == "date") {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            }
            if ($fieldtype == "date") {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $fieldvalue = \DateTime::createFromFormat("d/m/Y", $field["fieldvalue"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                if ($fieldvalue === false) {
                    throw new \Exception("Formato data non valido");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }
            }
            if ($fieldtype == "datetime") {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $fieldvalue = \DateTime::createFromFormat("d/m/Y H:i", $field["fieldvalue"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                if ($fieldvalue === false) {
                    throw new \Exception("Formato data ora non valido");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }
            }
        }
        return $fieldvalue;
    }
}

ComuneFI / BiCoreBundle

Push — master ( 9e253e...de67a0 )

FiCoreCrudInlineControllerTrait::insertinline() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
