Cdf\BiCoreBundle\Controller\FiCoreCrudControllerTrait

Complexity

Total Complexity

20

Size/Duplication

Total Lines	273
Duplicated Lines	0 %

Test Coverage

Coverage

96.15%

Importance

Changes	2
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	delete()	0	36	5
A	elencoModifiche()	0	11	1
A	new()	0	58	5
B	update()	0	72	6
A	edit()	0	46	3

<?php

namespace Cdf\BiCoreBundle\Controller;

use Cdf\BiCoreBundle\Utils\Tabella\ParametriTabella;
use Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException;
use Doctrine\ORM\EntityManager;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Cdf\BiCoreBundle\Entity\Storicomodifiche;

trait FiCoreCrudControllerTrait
{
    use FiCoreCrudInlineControllerTrait;

    /**
     * Displays a form to create a new table entity.
     *
     * @param Request $request
     * @return Response
     * @throws AccessDeniedException
     *
     */
    public function new(Request $request): Response
    {
        /* @var $em EntityManager */
        $bundle = $this->getBundle();

It seems like getBundle() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $controller = $this->getController();

It seems like getController() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (!$this->getPermessi()->canCreate($this->getController())) {

It seems like getPermessi() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            throw new AccessDeniedException('Non si hanno i permessi per creare questo contenuto');
        }

        $crudtemplate = $this->getCrudTemplate($bundle, $controller, $this->getThisFunctionName());

It seems like getCrudTemplate() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like getThisFunctionName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $tabellatemplate = $this->getTabellaTemplate($controller);

It seems like getTabellaTemplate() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $parametriform = $request->get('parametriform') ? json_decode($request->get('parametriform'), true) : [];

It seems like $request->get('parametriform') can also be of type null; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

        $entityclass = $this->getEntityClassName();

It seems like getEntityClassName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $formclass = str_replace('Entity', 'Form', $entityclass);

        $entity = new $entityclass();
        $formType = $formclass . 'Type';
        $form = $this->createForm($formType, $entity, ['attr' => [

It seems like createForm() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                'id' => 'formdati' . $controller,
            ],
            'action' => $this->generateUrl($controller . '_new'), 'parametriform' => $parametriform,

It seems like generateUrl() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        ]);

        $form->handleRequest($request);

        $twigparms = [
            'form' => $form->createView(),
            'nomecontroller' => ParametriTabella::setParameter($controller),
            'tabellatemplate' => $tabellatemplate,
            'permessi' => ParametriTabella::setParameter(json_encode($this->getPermessi()->toJson($controller))),
        ];

        if ($form->isSubmitted()) {
            if ($form->isValid()) {
                $entity = $form->getData();

                $entityManager = $this->em;
                $entityManager->persist($entity);
                $entityManager->flush();

                return new Response(
                    $this->renderView($crudtemplate, $twigparms),

It seems like renderView() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                    200
                );
            } else {
                //Quando non passa la validazione
                return new Response(
                    $this->renderView($crudtemplate, $twigparms),
                    400
                );
            }
        } else {
            //Quando viene richiesta una "nuova" new
            return new Response(
                $this->renderView($crudtemplate, $twigparms),
                200
            );
        }
    }

    /**
     * Displays a form to edit an existing table entity.
     *
     * @param Request $request
     * @param string|int $id
     * @return Response
     * @throws AccessDeniedException
     *
     */
    public function edit(Request $request, $id): Response

The parameter $request is not used and could be removed.

    {
        /* @var $this->em EntityManager */
        $bundle = $this->getBundle();
        $controller = $this->getController();

        if (!$this->getPermessi()->canRead($this->getController())) {
            throw new AccessDeniedException('Non si hanno i permessi per modificare questo contenuto');
        }
        $crudtemplate = $this->getCrudTemplate($bundle, $controller, $this->getThisFunctionName());
        $tabellatemplate = $this->getTabellaTemplate($controller);

        $entityclass = $this->getEntityClassName();
        $formclass = str_replace('Entity', 'Form', $entityclass);

        $formType = $formclass . 'Type';

        $elencomodifiche = $this->elencoModifiche($controller, $id);

        /** @var class-string $entityclass */
        /** @var mixed $entity */
        $entity = $this->em->getRepository($entityclass)->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Impossibile trovare l\'entità ' . $controller . ' del record con id ' . $id . '.');

It seems like createNotFoundException() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
        
        $editForm = $this->createForm(
            $formType,
            $entity,
            ['attr' => [
                        'id' => 'formdati' . $controller,
                    ],
                    'action' => $this->generateUrl($controller . '_update', ['id' => $entity->getId()]),
                ]
        );

        return $this->render(

It seems like render() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $crudtemplate,
            [
                            'entity' => $entity,
                            'nomecontroller' => ParametriTabella::setParameter($controller),
                            'tabellatemplate' => $tabellatemplate,
                            'edit_form' => $editForm->createView(),
                            'elencomodifiche' => $elencomodifiche,
                            'permessi' => ParametriTabella::setParameter(json_encode($this->getPermessi()->toJson($controller))),
                        ]
        );
    }

    /**
     * Update an existing table entity.
     *
     * @param Request $request
     * @param int $id
     * @return Response
     * @throws AccessDeniedException
     */
    public function update(Request $request, $id): Response
    {
        /* @var $ EntityManager */
        $bundle = $this->getBundle();
        $controller = $this->getController();
        if (!$this->getPermessi()->canUpdate($this->getController())) {
            throw new AccessDeniedException('Non si hanno i permessi per modificare questo contenuto');
        }
        $crudtemplate = $this->getCrudTemplate($bundle, $controller, 'edit');
        $tabellatemplate = $this->getTabellaTemplate($controller);
        $elencomodifiche = $this->elencoModifiche($controller, $id);

        $entityclass = $this->getEntityClassName();
        $formclass = str_replace('Entity', 'Form', $entityclass);
        $formType = $formclass . 'Type';

        /** @var class-string $entityclass */
        /** @var mixed $entity */
        $entity = $this->em->getRepository($entityclass)->find($id);

        if (!$entity) {
            throw $this->createNotFoundException('Impossibile trovare l\'entità ' . $controller . ' per il record con id ' . $id);
        }
        
        $editForm = $this->createForm(
            $formType,
            $entity,
            ['attr' => [
                        'id' => 'formdati' . $controller,
                    ],
                    'action' => $this->generateUrl($controller . '_update', ['id' => $entity->getId()]),
                ]
        );
        
        /** @phpstan-ignore-next-line */
        $editForm->submit($request->request->get($editForm->getName()));

        if ($editForm->isValid()) {
            $originalData = $this->em->getUnitOfWork()->getOriginalEntityData($entity);

            $this->em->persist($entity);
            $this->em->flush();

            $newData = $this->em->getUnitOfWork()->getOriginalEntityData($entity);
            /** @var \Cdf\BiCoreBundle\Repository\StoricomodificheRepository $repoStorico */
            $repoStorico = $this->em->getRepository(Storicomodifiche::class);
            $changes = $repoStorico->isRecordChanged($controller, $originalData, $newData);

            if ($changes) {

The expression $changes of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                /** @var \Cdf\BiCoreBundle\Entity\Operatori $currentUser */
                $currentUser = $this->getUser();

It seems like getUser() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $repoStorico->saveHistory($controller, $changes, $id, $currentUser);
            }

            $continua = (int) $request->get('continua');
            if (0 === $continua) {
                return new Response('OK');
            } else {
                return $this->redirect($this->generateUrl($controller . '_edit', ['id' => $id]));

It seems like redirect() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        }

        return new Response($this->renderView(
            $crudtemplate,
            [
                            'entity' => $entity,
                            'edit_form' => $editForm->createView(),
                            'nomecontroller' => ParametriTabella::setParameter($controller),
                            'tabellatemplate' => $tabellatemplate,
                            'elencomodifiche' => $elencomodifiche,
                        ]
        ), 400);
    }

    /**
     * Deletes a table entity.
     */
    public function delete(Request $request, string $token): Response
    {
        /* @var $this->em EntityManager */
        if (!$this->getPermessi()->canDelete($this->getController())) {
            throw new AccessDeniedException('Non si hanno i permessi per eliminare questo contenuto');
        }
        $entityclass = $this->getEntityClassName();

        $isValidToken = $this->isCsrfTokenValid($this->getController(), $token);

It seems like isCsrfTokenValid() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (!$isValidToken) {
            throw $this->createNotFoundException('Token non valido:' . $this->getController() . " " . $token);
        }

        try {
            $qb = $this->em->createQueryBuilder();
            $ids = explode(',', $request->get('id'));

It seems like $request->get('id') can also be of type null; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

            $qb->delete($entityclass, 'u')
                    ->andWhere('u.id IN (:ids)')
                    ->setParameter('ids', $ids);

            $query = $qb->getQuery();
            $query->execute();
        } catch (ForeignKeyConstraintViolationException $e) {
            $response = new Response($e->getMessage());
            $response->setStatusCode(501);

            return $response;
        } catch (\Exception $e) {
            $response = new Response($e->getMessage());
            $response->setStatusCode(200);

            return $response;
        }

        return new Response('Operazione eseguita con successo');
    }

    /**
     *
     * @param string $controller
     * @param string|int $id
     * @return array<Storicomodifiche>
     */
    public function elencoModifiche(string $controller, $id): array
    {
        $risultato = $this->em->getRepository(Storicomodifiche::class)->findBy(
            [
                    'nometabella' => $controller,
                    'idtabella' => $id,
                ],
            ['giorno' => 'DESC']
        );

        return $risultato;
    }
}