Linq::condition() - Code Metrics - Inspection of "Add LINQ Class" - Compolomus/Collection - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ea6089...acdef9 )

by compolom

created 2019-10-05 11:56 UTC

Linq::condition() B

↳ Parent: Linq

Complexity

Conditions	7
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
dl	0
loc	25
ccs	0
cts	15
cp	0
rs	8.5866
c	0
b	0
f	0
cc	7
nc	7
nop	3
crap	56

<?php declare(strict_types=1);

namespace Compolomus\Collection;

use InvalidArgumentException;

class Linq
{
    private $collection;

    private const CONDITIONS_TYPES = [
        '=',
        '!=',
        '>',
        '<',
        '<=',
        '>=',
    ];

    public function __construct(Collection $collection)
    {
        $this->collection = $collection;
    }

    public function where(string $query): self
    {
        $pattern = '#(?P<field>.*)?(?P<condition>' . implode('|', self::CONDITIONS_TYPES) . ')(?P<value>.*)#is';

        preg_match($pattern, $query, $matches);

        $count = count($matches);

        if (!$count || $count < 4) {
            throw new InvalidArgumentException('Not matches ' . '<pre>' . print_r($matches, true) . '</pre>');
        }
        $args = array_map('trim', $matches);

        $array = [
            '=' => '===',
            '!=' => '!==',
        ];

        return $this->prepare($args['field'],
            (in_array($args['condition'], $array, true) ? $array[$args['condition']] : $args['condition']),
            $args['value']);
    }
    
    private function condition($valFirst, string $condition, $valSecond): bool
    {
        switch ($condition) {
            case '=':
                return $valFirst === $valSecond;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case '!=':
                return $valFirst !== $valSecond;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case '>':
                return $valFirst > $valSecond;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case '<':
                return $valFirst < $valSecond;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case '>=':
                return $valFirst >= $valSecond;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case '<=':
                return $valFirst <= $valSecond;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                throw new InvalidArgumentException('Condition not set');
        }
    }

    public function prepare(string $field, string $condition, $value): self
    {
        $new = new Collection($this->collection->getGeneric());

        foreach ($this->collection->get() as $val) {
            !$this->condition($val->$field, $condition, $value) ?: $new->addOne($val);
        }

        $this->collection = $new;

        return $this;
    }


    public function get(): array
    {
        return $this->collection->get();
    }
}


1			<?php declare(strict_types=1);
2
3			namespace Compolomus\Collection;
4
5			use InvalidArgumentException;
6
7			class Linq
8			{
9			private $collection;
10
11			private const CONDITIONS_TYPES = [
12			'=',
13			'!=',
14			'>',
15			'<',
16			'<=',
17			'>=',
18			];
19
20			public function __construct(Collection $collection)
21			{
22			$this->collection = $collection;
23			}
24
25			public function where(string $query): self
26			{
27			$pattern = '#(?P<field>.)?(?P<condition>' . implode('\|', self::CONDITIONS_TYPES) . ')(?P<value>.)#is';
28
29			preg_match($pattern, $query, $matches);
30
31			$count = count($matches);
32
33			if (!$count \|\| $count < 4) {
34			throw new InvalidArgumentException('Not matches ' . '<pre>' . print_r($matches, true) . '</pre>');
35			}
36			$args = array_map('trim', $matches);
37
38			$array = [
39			'=' => '===',
40			'!=' => '!==',
41			];
42
43			return $this->prepare($args['field'],
44			(in_array($args['condition'], $array, true) ? $array[$args['condition']] : $args['condition']),
45			$args['value']);
46			}
47
48			private function condition($valFirst, string $condition, $valSecond): bool
49			{
50			switch ($condition) {
51			case '=':
52			return $valFirst === $valSecond;
53			break;
			0 ignored issues – show Unused Code introduced 2019-10-05 11:59 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
54			case '!=':
55			return $valFirst !== $valSecond;
56			break;
			0 ignored issues – show Unused Code introduced 2019-10-05 11:59 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
57			case '>':
58			return $valFirst > $valSecond;
59			break;
			0 ignored issues – show Unused Code introduced 2019-10-05 11:59 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
60			case '<':
61			return $valFirst < $valSecond;
62			break;
			0 ignored issues – show Unused Code introduced 2019-10-05 11:59 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
63			case '>=':
64			return $valFirst >= $valSecond;
65			break;
			0 ignored issues – show Unused Code introduced 2019-10-05 11:59 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
66			case '<=':
67			return $valFirst <= $valSecond;
68			break;
			0 ignored issues – show Unused Code introduced 2019-10-05 11:59 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
69			default:
70			throw new InvalidArgumentException('Condition not set');
71			}
72			}
73
74			public function prepare(string $field, string $condition, $value): self
75			{
76			$new = new Collection($this->collection->getGeneric());
77
78			foreach ($this->collection->get() as $val) {
79			!$this->condition($val->$field, $condition, $value) ?: $new->addOne($val);
80			}
81
82			$this->collection = $new;
83
84			return $this;
85			}
86
87
88			public function get(): array
89			{
90			return $this->collection->get();
91			}
92			}
93

Compolomus / Collection

Push — master ( ea6089...acdef9 )

Linq::condition() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like