ssg._checks

Complexity

Total Complexity

6

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes

0

3 Functions

Rating	Name	Duplication	Size	Complexity
A	get_content_ref_if_exists_and_not_remote()	0	16	3
A	is_cce_valid()	0	10	1
A	is_content_href_remote()	0	17	2

import re

This module should have a docstring.

from ssg._constants import *

The usage of wildcard imports like ssg._constants should generally be avoided.

datetime was imported with wildcard, but is not used.

os was imported with wildcard, but is not used.

JINJA_MACROS_DEFINITIONS was imported with wildcard, but is not used.

xml_version was imported with wildcard, but is not used.

datastream_namespace was imported with wildcard, but is not used.

ocil_namespace was imported with wildcard, but is not used.

oval_footer was imported with wildcard, but is not used.

oval_namespace was imported with wildcard, but is not used.

ocil_cs was imported with wildcard, but is not used.

xccdf_header was imported with wildcard, but is not used.

xccdf_footer was imported with wildcard, but is not used.

bash_system was imported with wildcard, but is not used.

ansible_system was imported with wildcard, but is not used.

puppet_system was imported with wildcard, but is not used.

anaconda_system was imported with wildcard, but is not used.

cce_uri was imported with wildcard, but is not used.

stig_ns was imported with wildcard, but is not used.

ssg_version_uri was imported with wildcard, but is not used.

OSCAP_VENDOR was imported with wildcard, but is not used.

OSCAP_DS_STRING was imported with wildcard, but is not used.

OSCAP_GROUP was imported with wildcard, but is not used.

OSCAP_GROUP_PCIDSS was imported with wildcard, but is not used.

OSCAP_GROUP_VAL was imported with wildcard, but is not used.

OSCAP_GROUP_NON_PCI was imported with wildcard, but is not used.

XCCDF12_NS was imported with wildcard, but is not used.

min_ansible_version was imported with wildcard, but is not used.

ansible_version_requirement_pre_task_name was imported with wildcard, but is not used.

oval_header was imported with wildcard, but is not used.

timestamp was imported with wildcard, but is not used.

PKG_MANAGER_TO_SYSTEM was imported with wildcard, but is not used.

disa_cciuri was imported with wildcard, but is not used.

disa_srguri was imported with wildcard, but is not used.

def get_content_ref_if_exists_and_not_remote(check):

The name get_content_ref_if_exists_and_not_remote does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    """
    Given an OVAL check element, examine the ``xccdf_ns:check-content-ref``

    If it exists and it isn't remote, pass it as the return value.
    Otherwise, return None.

    ..see-also:: is_content_href_remote
    """
    checkcontentref = check.find("./{%s}check-content-ref" % XCCDF11_NS)

The variable XCCDF11_NS does not seem to be defined.

    if checkcontentref is None:
        return None
    if is_content_href_remote(checkcontentref):

Unnecessary "else" after "return"

        return None
    else:
        return checkcontentref


def is_content_href_remote(check_content_ref):
    """
    Given an OVAL check-content-ref element, examine the 'href' attribute.

    If it starts with 'http://' or 'https://', return True, otherwise
    return False.

    Raises RuntimeError if the ``href`` element doesn't exist.
    """
    hrefattr = check_content_ref.get("href")
    if hrefattr is None:
        # @href attribute of <check-content-ref> is required by XCCDF standard
        msg = "Invalid OVAL <check-content-ref> detected - missing the " \
              "'href' attribute!"
        raise RuntimeError(msg)

    return hrefattr.startswith("http://") or hrefattr.startswith("https://")


def is_cce_valid(cceid):
    """
    IF CCE ID IS IN VALID FORM (either 'CCE-XXXX-X' or 'CCE-XXXXX-X'
    where each X is a digit, and the final X is a check-digit)
    based on Requirement A17:

    http://people.redhat.com/swells/nist-scap-validation/scap-val-requirements-1.2.html
    """
    match = re.match(r'^CCE-\d{4,5}-\d$', cceid)
    return match is not None