Conditions | 1 |
Total Lines | 59 |
Code Lines | 52 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | """create tables |
||
19 | def upgrade() -> None: |
||
20 | op.create_table( |
||
21 | 'schools', |
||
22 | sa.Column('school', sa.TEXT, unique=True, nullable=False), |
||
23 | sa.Column('region', sa.TEXT, nullable=False), |
||
24 | sa.Column('color', sa.INTEGER, nullable=False), |
||
25 | sa.Column('id', sa.BIGINT, nullable=False), |
||
26 | sa.Column('added_by', sa.TEXT, nullable=False), |
||
27 | sa.Column('added_by_id', sa.BIGINT, nullable=False), |
||
28 | sa.PrimaryKeyConstraint('school') |
||
29 | ) |
||
30 | op.create_table( |
||
31 | 'bot_admins', |
||
32 | sa.Column('id', sa.BIGINT, unique=True, nullable=False), |
||
33 | sa.Column('name', sa.TEXT, nullable=False), |
||
34 | sa.PrimaryKeyConstraint('user_id') |
||
35 | ) |
||
36 | op.create_table( |
||
37 | 'admin_channels', |
||
38 | sa.Column('id', sa.BIGINT, unique=True, nullable=False), |
||
39 | sa.Column('guild_id', sa.BIGINT, nullable=False), |
||
40 | sa.Column('log', sa.Boolean, default=False), |
||
41 | sa.PrimaryKeyConstraint('id') |
||
42 | ) |
||
43 | op.create_table( |
||
44 | 'regions', |
||
45 | sa.Column('name', sa.TEXT, unique=True, nullable=False), |
||
46 | sa.Column('id', sa.BIGINT, nullable=False), |
||
47 | sa.PrimaryKeyConstraint('name') |
||
48 | ) |
||
49 | op.create_table( |
||
50 | 'errors', |
||
51 | sa.Column('id', sa.BIGINT, unique=True, nullable=False), |
||
52 | sa.Column('command', sa.TEXT, nullable=False), |
||
53 | sa.Column('message', sa.TEXT, nullable=False), |
||
54 | sa.Column('error', sa.TEXT, nullable=False), |
||
55 | sa.Column('time', sa.TIMESTAMP, nullable=False), |
||
56 | sa.Column('ack', sa.Boolean, nullable=False, default=False), |
||
57 | sa.PrimaryKeyConstraint('id') |
||
58 | ) |
||
59 | op.create_table( |
||
60 | 'keys', |
||
61 | sa.Column('key', sa.TEXT, unique=True, nullable=False), |
||
62 | sa.Column('value', sa.TEXT, nullable=False), |
||
63 | ) |
||
64 | op.create_table( |
||
65 | 'messages', |
||
66 | sa.Column('name', sa.TEXT, unique=True, nullable=False), |
||
67 | sa.Column('message', sa.TEXT, nullable=False), |
||
68 | sa.PrimaryKeyConstraint('name') |
||
69 | ) |
||
70 | op.create_table( |
||
71 | 'reports', |
||
72 | sa.Column('id', sa.BIGINT, unique=True, nullable=False), |
||
73 | sa.Column('name', sa.TEXT, nullable=False), |
||
74 | sa.Column('name_id', sa.BIGINT, nullable=False), |
||
75 | sa.Column('message', sa.TEXT, nullable=False), |
||
76 | sa.Column('time', sa.TIMESTAMP, nullable=False), |
||
77 | sa.PrimaryKeyConstraint('id') |
||
78 | ) |
||
89 |