Issues in Application.php (master) - Issues in master - Codexshaper/wpb-foundation - Measure and Improve Code Quality continuously with Scrutinizer

Issues (57)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Application.php (6 issues)

Labels

Severity

CodexShaper 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace CodexShaper\WP;

use CodexShaper\App\User;
use CodexShaper\Database\Database;
use CodexShaper\Database\Facades\DB;
use CodexShaper\WP\Support\Facades\Config;
use Illuminate\Container\Container;
use Illuminate\Contracts\Container\Container as ContainerInterface;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Facade;

class Application
{
    /**
     * @var app
     */
    protected $app = null;

    /**
     * @var config
     */
    protected $config;

    /**
     * @var db
     */
    protected $db;

    /**
     * @var options
     */
    protected $options;

    /**
     * @var root
     */
    protected $root;

    public function __construct($options = [], ContainerInterface $container = null)
    {
        $this->options = $options;
        
        $this->app = $container;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        if (is_null($this->app)) {
            $this->app = new Container();

            Facade::setFacadeApplication($this->app);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->app->instance(ContainerInterface::class, $this->app);
        }

        $this->app['app'] = $this->app;

        $this->root = __DIR__ . '/../../../../';

        if (! empty($this->options) && isset($this->options['paths']['root'])) {
            $this->root = rtrim($this->options['paths']['root'], "/") . '/';
        }

        if (!isset($this->app['root'])) {
            $this->app['root'] = $this->root;
        }

        $this->config = new Config($this->options);

        $this->setupEnv();
        $this->registerConfig();
        $this->setupDatabase();
        $this->registerProviders();
        $this->registerRequest();
        $this->registerRouter();
        $this->loadRoutes();
    }

    public function getInstance()
    {
        if (!$this->app) {
            return new self();
        }

        return $this->app;
    }

    protected function setupEnv()
    {
        $this->app['env'] = $this->config->get('app.env');
    }

    protected function registerConfig()
    {
        $this->app->bind('config', function () {
            return [
                'app'           => $this->config->get('app'),
                'view.paths'    => $this->config->get('view.paths'),
                'view.compiled' => $this->config->get('view.compiled'),
            ];
        }, true);
    }

    protected function setupDatabase()
    {
        global $wpdb;

        $this->db = new Database([

            'driver'            => 'mysql',
            'host'               => $wpdb->dbhost,
            'database'        => $wpdb->dbname,
            'username'        => $wpdb->dbuser,
            'password'        => $wpdb->dbpassword,
            'prefix'          => $wpdb->prefix,
            'charset'            => $wpdb->charset,
            'collation'     => $wpdb->collate,
        ]);

        $this->db->run();

        $this->app->singleton('db', function () {
            return $this->db;
        });
    }

    protected function registerProviders()
    {
        $providers = $this->config->get('app.providers');

        if( $providers && count($providers) > 0) {
            foreach ($providers as $provider) {
                with(new $provider($this->app))->register();
            }
        }
    }

    protected function registerRequest()
    {
        $this->app->bind(Request::class, function ($app) {

            $request = Request::capture();

            if ($wp_user = wp_get_current_user()) {
                $user = User::find($wp_user->ID);
                $request->merge(['user' => $user]);
                $request->setUserResolver(function () use ($user) {
                    return $user;
                });
            }

            return $request;
        });
    }

    protected function registerRouter()
    {
        if(isset($this->app['router'])) {
            $this->app->instance(\Illuminate\Routing\Router::class, $this->app['router']);
        }  
        $this->app->alias('Route', \CodexShaper\WP\Support\Facades\Route::class);
    }

    protected function loadRoutes($dir = null)

    {
        foreach ( get_option('active_plugins') as $activate_plugin) {
            $dir = $this->root.'../'.dirname($activate_plugin);
           if(is_dir($dir.'/routes')) {
                foreach (glob($dir.'/routes/*.php') as $route) {
                    require_once $route;
                }
            }
        }
    //     if (!$dir) {
    //         $dir = $this->root . 'routes/';
    //     }

    //     if(isset($this->app['router'])) {
            
    //         // $app['router']->group(['middleware' => ['web']], function(){
    //         require $dir.'web.php';
    //         // });

    //         $this->app['router']->group(['prefix' => 'api'], function () use ($dir) {
    //             require $dir.'api.php';
    //         });

    //         $this->app['router']->group(['prefix' => 'wp-admin'], function () use ($dir) {
    //             require $dir.'admin.php';
    //         });
    //     }
    }
}


1			<?php
2
3			namespace CodexShaper\WP;
4
5			use CodexShaper\App\User;
6			use CodexShaper\Database\Database;
7			use CodexShaper\Database\Facades\DB;
8			use CodexShaper\WP\Support\Facades\Config;
9			use Illuminate\Container\Container;
10			use Illuminate\Contracts\Container\Container as ContainerInterface;
11			use Illuminate\Http\Request;
12			use Illuminate\Support\Facades\Facade;
13
14			class Application
15			{
16			/**
17			* @var app
18			*/
19			protected $app = null;
20
21			/**
22			* @var config
23			*/
24			protected $config;
25
26			/**
27			* @var db
28			*/
29			protected $db;
30
31			/**
32			* @var options
33			*/
34			protected $options;
35
36			/**
37			* @var root
38			*/
39			protected $root;
40
41			public function __construct($options = [], ContainerInterface $container = null)
42			{
43			$this->options = $options;
44
45			$this->app = $container;
			0 ignored issues – show Documentation Bug introduced 2020-06-18 07:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$container` can also be of type `object<Illuminate\Contracts\Container\Container>`. However, the property `$app` is declared as type `object<CodexShaper\WP\app>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
46
47			if (is_null($this->app)) {
48			$this->app = new Container();
			0 ignored issues – show Documentation Bug introduced 2020-06-18 07:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new \Illuminate\Container\Container()` of type `object<Illuminate\Container\Container>` is incompatible with the declared type `object<CodexShaper\WP\app>` of property `$app`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
49			Facade::setFacadeApplication($this->app);
			0 ignored issues – show Documentation introduced 2020-06-18 07:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->app` is of type `object<Illuminate\Container\Container>`, but the function expects a `object<Illuminate\Contra...Foundation\Application>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50			$this->app->instance(ContainerInterface::class, $this->app);
51			}
52
53			$this->app['app'] = $this->app;
54
55			$this->root = __DIR__ . '/../../../../';
56
57			if (! empty($this->options) && isset($this->options['paths']['root'])) {
58			$this->root = rtrim($this->options['paths']['root'], "/") . '/';
59			}
60
61			if (!isset($this->app['root'])) {
62			$this->app['root'] = $this->root;
63			}
64
65			$this->config = new Config($this->options);
66
67			$this->setupEnv();
68			$this->registerConfig();
69			$this->setupDatabase();
70			$this->registerProviders();
71			$this->registerRequest();
72			$this->registerRouter();
73			$this->loadRoutes();
74			}
75
76			public function getInstance()
77			{
78			if (!$this->app) {
79			return new self();
80			}
81
82			return $this->app;
83			}
84
85			protected function setupEnv()
86			{
87			$this->app['env'] = $this->config->get('app.env');
88			}
89
90			protected function registerConfig()
91			{
92			$this->app->bind('config', function () {
93			return [
94			'app' => $this->config->get('app'),
95			'view.paths' => $this->config->get('view.paths'),
96			'view.compiled' => $this->config->get('view.compiled'),
97			];
98			}, true);
99			}
100
101			protected function setupDatabase()
102			{
103			global $wpdb;
104
105			$this->db = new Database([
			0 ignored issues – show Documentation Bug introduced 2020-06-18 07:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new \CodexShaper\Databas...on' => $wpdb->collate))` of type `object<CodexShaper\Database\Database>` is incompatible with the declared type `object<CodexShaper\WP\db>` of property `$db`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
106			'driver' => 'mysql',
107			'host' => $wpdb->dbhost,
108			'database' => $wpdb->dbname,
109			'username' => $wpdb->dbuser,
110			'password' => $wpdb->dbpassword,
111			'prefix' => $wpdb->prefix,
112			'charset' => $wpdb->charset,
113			'collation' => $wpdb->collate,
114			]);
115
116			$this->db->run();
117
118			$this->app->singleton('db', function () {
119			return $this->db;
120			});
121			}
122
123			protected function registerProviders()
124			{
125			$providers = $this->config->get('app.providers');
126
127			if( $providers && count($providers) > 0) {
128			foreach ($providers as $provider) {
129			with(new $provider($this->app))->register();
130			}
131			}
132			}
133
134			protected function registerRequest()
135			{
136			$this->app->bind(Request::class, function ($app) {
			0 ignored issues – show Unused Code introduced 2020-06-18 07:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
137			$request = Request::capture();
138
139			if ($wp_user = wp_get_current_user()) {
140			$user = User::find($wp_user->ID);
141			$request->merge(['user' => $user]);
142			$request->setUserResolver(function () use ($user) {
143			return $user;
144			});
145			}
146
147			return $request;
148			});
149			}
150
151			protected function registerRouter()
152			{
153			if(isset($this->app['router'])) {
154			$this->app->instance(\Illuminate\Routing\Router::class, $this->app['router']);
155			}
156			$this->app->alias('Route', \CodexShaper\WP\Support\Facades\Route::class);
157			}
158
159			protected function loadRoutes($dir = null)
			0 ignored issues – show Unused Code introduced 2020-06-24 17:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$dir` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
160			{
161			foreach ( get_option('active_plugins') as $activate_plugin) {
162			$dir = $this->root.'../'.dirname($activate_plugin);
163			if(is_dir($dir.'/routes')) {
164			foreach (glob($dir.'/routes/*.php') as $route) {
165			require_once $route;
166			}
167			}
168			}
169			// if (!$dir) {
170			// $dir = $this->root . 'routes/';
171			// }
172
173			// if(isset($this->app['router'])) {
174
175			// // $app['router']->group(['middleware' => ['web']], function(){
176			// require $dir.'web.php';
177			// // });
178
179			// $this->app['router']->group(['prefix' => 'api'], function () use ($dir) {
180			// require $dir.'api.php';
181			// });
182
183			// $this->app['router']->group(['prefix' => 'wp-admin'], function () use ($dir) {
184			// require $dir.'admin.php';
185			// });
186			// }
187			}
188			}
189

Codexshaper / wpb-foundation

Issues (57)

Security Analysis not enabled

src/Application.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like