Issues in Manager.php (master) - Issues in master - Codexshaper/oauth2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (39)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Manager.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace CodexShaper\OAuth2\Server;

use CodexShaper\OAuth2\Server\Repositories\AccessTokenRepository;
use CodexShaper\OAuth2\Server\Repositories\AuthCodeRepository;
use CodexShaper\OAuth2\Server\Repositories\ClientRepository;
use CodexShaper\OAuth2\Server\Repositories\RefreshTokenRepository;
use CodexShaper\OAuth2\Server\Repositories\ScopeRepository;
use CodexShaper\OAuth2\Server\Repositories\UserRepository;
use DateInterval;
use Defuse\Crypto\Key;
use League\OAuth2\Server\AuthorizationServer;
use League\OAuth2\Server\CryptKey;
use League\OAuth2\Server\Grant\AuthCodeGrant;
use League\OAuth2\Server\Grant\ClientCredentialsGrant;
use League\OAuth2\Server\Grant\ImplicitGrant;
use League\OAuth2\Server\Grant\PasswordGrant;
use League\OAuth2\Server\Grant\RefreshTokenGrant;
use League\OAuth2\Server\ResourceServer;
use phpseclib\Crypt\RSA;

class Manager
{
    /**
     * Authorization server.
     *
     * @var string
     */
    protected $server;

    /**
     * All scopes.
     *
     * @var string
     */
    protected static $scopes = [];

    /**
     * Default scope.
     *
     * @var string
     */
    protected static $defaultScope;

    /**
     * Enable or didable implicit grant.
     *
     * @var string
     */
    protected static $isEnableImplicitGrant = false;

    /**
     * Refresh token expire at.
     *
     * @var string
     */
    protected static $refreshTokensExpireAt = 'P1Y';

    /**
     * token exipre at.
     *
     * @var string
     */
    protected static $tokensExpireAt = 'P1Y';

    /**
     * Create RSA authorisation keys.
     *
     * @return void
     */
    public static function keys($dir = null)
    {
        if (!$dir) {
            $dir = __DIR__.'/../storage/rsa';
        }

        if (!is_dir($dir)) {
            mkdir($dir, 0777, true);
        }

        $publicKey = $dir.'/oauth-public.key';
        $privateKey = $dir.'/oauth-private.key';
        $rsa = new RSA();
        $keys = $rsa->createKey(4096);

        file_put_contents($publicKey, $keys['publickey']);
        file_put_contents($privateKey, $keys['privatekey']);
    }

    /**
     * Add New scopes.
     *
     * @return void
     */
    public static function setScopes(array $scopes = [])
    {
        if (empty($scopes)) {
            return;
        }

        static::$scopes = array_merge(static::$scopes, $scopes);

    }

    /**
     * Get all available scopes.
     *
     * @return array
     */
    public static function getScopes()
    {
        return static::$scopes;
    }

    /**
     * Given a client, grant type and optional user identifier validate the set of scopes requested are valid and optionally
     * append additional scopes or remove requested scopes.
     *
     * @param \League\OAuth2\Server\Entities\ScopeEntityInterface[] $scopes
     * @param string                                                $grantType
     * @param \League\OAuth2\Server\Entities\ClientEntityInterface  $clientEntity
     * @param null|string                                           $userIdentifier
     *
     * @return \League\OAuth2\Server\Entities\ScopeEntityInterface[]
     */
    public static function filterScopes($scopes, $grantType)
    {
        if (!in_array($grantType, ['password', 'personal_access', 'client_credentials'])) {
            $scopes = array_filter($scopes, function ($scope) {
                return trim($scope->getIdentifier()) !== '*';
            });
        }

        return array_filter($scopes, function ($scope) {
            return static::hasScope($scope->getIdentifier());
        });
    }

    /**
     * Check scope exists or not.
     *
     * @param string $identifier
     *
     * @return bool
     */
    public static function hasScope($identifier)
    {
        return trim($identifier) === '*' || array_key_exists($identifier, array_flip(static::$scopes));
    }

    /**
     * Check is isset a scope or not.
     *
     * @param string $identifier
     *
     * @return bool
     */
    public static function isValidateScope($identifier)
    {
        return array_key_exists($identifier, array_flip(static::$scopes));
    }

    /**
     * Make the authorization service instance.
     *
     * @return \League\OAuth2\Server\AuthorizationServer
     */
    public function makeAuthorizationServer()
    {
        $encryptionKey = 'def00000069ceedc03a1f91fd51a49ce08ebb8580d688f4fbc3774c86aaa4df516eea0f72c1f62e3e577ec9f0c83c773b890222966bf93ac22e84a9eca55638be310665b';

        $this->server = new AuthorizationServer(

            new ClientRepository(),
            new AccessTokenRepository(),
            new ScopeRepository(),
            $this->makeCryptKey('private'),
            Key::loadFromAsciiSafeString($encryptionKey)
        );

        $this->server->setDefaultScope(static::$defaultScope);
        $this->enableGrantTypes();

        return $this->server;
    }

    /**
     * Enable All grant types.
     *
     * @return void
     */
    protected function enableGrantTypes()
    {
        $this->server->enableGrantType(
            new ClientCredentialsGrant(),
            new DateInterval(static::$tokensExpireAt) // access tokens will expire after 1 hour
        );

        $this->enableAuthCodeGrant();
        $this->enablePasswordGrant();
        $this->enableRefreshTokenGrant();

        if (static::$isEnableImplicitGrant) {
            $this->server->enableGrantType(
                new ImplicitGrant(new DateInterval(static::$tokensExpireAt)),
                new DateInterval(static::$tokensExpireAt) // access tokens will expire after 1 hour
            );
        }
    }

    /**
     * Enable Authorization code Grant.
     *
     * @return void
     */
    protected function enableAuthCodeGrant()
    {
        $authCodeGrant = new AuthCodeGrant(
            new AuthCodeRepository(),
            new RefreshTokenRepository(),
            new DateInterval('PT10M')
        );

        $authCodeGrant->setRefreshTokenTTL(new DateInterval(static::$refreshTokensExpireAt));

        $this->server->enableGrantType(
            $authCodeGrant,
            new DateInterval(static::$tokensExpireAt)
        );
    }

    /**
     * Enable Password Grant.
     *
     * @return void
     */
    protected function enablePasswordGrant()
    {
        $passwordGrant = new PasswordGrant(
            new UserRepository(),
            new RefreshTokenRepository()
        );

        $passwordGrant->setRefreshTokenTTL(new DateInterval(static::$refreshTokensExpireAt)); // refresh tokens will expire after 1 month

        // Enable the password grant on the server
        $this->server->enableGrantType(
            $passwordGrant,
            new DateInterval(static::$tokensExpireAt) // access tokens will expire after 1 hour
        );
    }

    /**
     * Enable Refresh token Grant.
     *
     * @return void
     */
    protected function enableRefreshTokenGrant()
    {
        $refreshTokenGrant = new RefreshTokenGrant(new RefreshTokenRepository());
        $refreshTokenGrant->setRefreshTokenTTL(new \DateInterval(static::$refreshTokensExpireAt)); // new refresh tokens will expire after 1 month

        // Enable the refresh token grant on the server
        $this->server->enableGrantType(
            $refreshTokenGrant,
            new \DateInterval(static::$tokensExpireAt) // new access tokens will expire after an hour
        );
    }

    /**
     * Enable Implicit Grant.
     *
     * @param bool $isImplicit
     *
     * @return void
     */
    public static function enableImplicitGrantType($isImplicit = true)
    {
        static::$isEnableImplicitGrant = $isImplicit;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * Create a resource server for validation.
     *
     * @return \League\OAuth2\Server\ResourServer
     */
    public function getResourceServer()
    {
        return new ResourceServer(
            new AccessTokenRepository(),
            $this->makeCryptKey('public')
        );
    }

    /**
     * Create a CryptKey instance without permissions check.
     *
     * @param string $key
     *
     * @return \League\OAuth2\Server\CryptKey
     */
    protected function makeCryptKey($type)
    {
        $key = __DIR__.'/../storage/rsa/oauth-'.$type.'.key';

        return new CryptKey($key, null, false);
    }

    public function validateUserForRequest($request)
    {
        $token = Model::instance('tokenModel')->find($request->getAttribute('oauth_access_token_id'));
        $client = Model::instance('clientModel')->find($request->getAttribute('oauth_client_id'));

        if (!$token || !$client) {
            return null;
        }

        if (!$token->user_id && !$client->user_id) {
            return null;
        }

        if ($token->user_id != null) {
            return $token->user_id;
        }

        return $client->user_id;
    }

    /**
     * Load all routes.
     *
     * @return void
     */
    public static function routes()
    {
        require __DIR__.'/../routes/oauth.php';
    }

    /**
     * Migrate tables.
     *
     * @param string $dir
     *
     * @return void
     */
    public static function migrate($dir = null)
    {
        if (is_null($dir)) {
            $dir = __DIR__.'/../database/migrations';
        }

        foreach (glob($dir.'/*.php') as $file) {
            require_once $file;
            $table = pathinfo($file)['filename'];
            (new $table())->up();
        }
    }

    /**
     * Drop tables.
     *
     * @param string $dir
     *
     * @return void
     */
    public static function rollback($dir = null)
    {
        if (is_null($dir)) {
            $dir = __DIR__.'/../database/migrations';
        }

        foreach (glob($dir.'/*.php') as $file) {
            require_once $file;
            $table = pathinfo($file)['filename'];
            (new $table())->down();
        }
    }

    /**
     * Drop and migrate fresh tables.
     *
     * @param string $dir
     *
     * @return void
     */
    public static function refresh($dir = null)
    {
        if (is_null($dir)) {
            $dir = __DIR__.'/../database/migrations';
        }

        static::rollback($dir);
        static::migrate($dir);
    }
}


1		<?php
2
3		namespace CodexShaper\OAuth2\Server;
4
5		use CodexShaper\OAuth2\Server\Repositories\AccessTokenRepository;
6		use CodexShaper\OAuth2\Server\Repositories\AuthCodeRepository;
7		use CodexShaper\OAuth2\Server\Repositories\ClientRepository;
8		use CodexShaper\OAuth2\Server\Repositories\RefreshTokenRepository;
9		use CodexShaper\OAuth2\Server\Repositories\ScopeRepository;
10		use CodexShaper\OAuth2\Server\Repositories\UserRepository;
11		use DateInterval;
12		use Defuse\Crypto\Key;
13		use League\OAuth2\Server\AuthorizationServer;
14		use League\OAuth2\Server\CryptKey;
15		use League\OAuth2\Server\Grant\AuthCodeGrant;
16		use League\OAuth2\Server\Grant\ClientCredentialsGrant;
17		use League\OAuth2\Server\Grant\ImplicitGrant;
18		use League\OAuth2\Server\Grant\PasswordGrant;
19		use League\OAuth2\Server\Grant\RefreshTokenGrant;
20		use League\OAuth2\Server\ResourceServer;
21		use phpseclib\Crypt\RSA;
22
23		class Manager
24		{
25		/**
26		* Authorization server.
27		*
28		* @var string
29		*/
30		protected $server;
31
32		/**
33		* All scopes.
34		*
35		* @var string
36		*/
37		protected static $scopes = [];
38
39		/**
40		* Default scope.
41		*
42		* @var string
43		*/
44		protected static $defaultScope;
45
46		/**
47		* Enable or didable implicit grant.
48		*
49		* @var string
50		*/
51		protected static $isEnableImplicitGrant = false;
52
53		/**
54		* Refresh token expire at.
55		*
56		* @var string
57		*/
58		protected static $refreshTokensExpireAt = 'P1Y';
59
60		/**
61		* token exipre at.
62		*
63		* @var string
64		*/
65		protected static $tokensExpireAt = 'P1Y';
66
67		/**
68		* Create RSA authorisation keys.
69		*
70		* @return void
71		*/
72		public static function keys($dir = null)
73		{
74		if (!$dir) {
75		$dir = __DIR__.'/../storage/rsa';
76		}
77
78		if (!is_dir($dir)) {
79		mkdir($dir, 0777, true);
80		}
81
82		$publicKey = $dir.'/oauth-public.key';
83		$privateKey = $dir.'/oauth-private.key';
84		$rsa = new RSA();
85		$keys = $rsa->createKey(4096);
86
87		file_put_contents($publicKey, $keys['publickey']);
88		file_put_contents($privateKey, $keys['privatekey']);
89		}
90
91		/**
92		* Add New scopes.
93		*
94		* @return void
95		*/
96		public static function setScopes(array $scopes = [])
97		{
98		if (empty($scopes)) {
99		return;
100		}
101
102		static::$scopes = array_merge(static::$scopes, $scopes);
		0 ignored issues – show Documentation Bug introduced 2020-06-18 07:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `array_merge(static::$scopes, $scopes)` of type `array` is incompatible with the declared type `string` of property `$scopes`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
103		}
104
105		/**
106		* Get all available scopes.
107		*
108		* @return array
109		*/
110		public static function getScopes()
111		{
112		return static::$scopes;
113		}
114
115		/**
116		* Given a client, grant type and optional user identifier validate the set of scopes requested are valid and optionally
117		* append additional scopes or remove requested scopes.
118		*
119		* @param \League\OAuth2\Server\Entities\ScopeEntityInterface[] $scopes
120		* @param string $grantType
121		* @param \League\OAuth2\Server\Entities\ClientEntityInterface $clientEntity
122		* @param null\|string $userIdentifier
123		*
124		* @return \League\OAuth2\Server\Entities\ScopeEntityInterface[]
125		*/
126		public static function filterScopes($scopes, $grantType)
127		{
128		if (!in_array($grantType, ['password', 'personal_access', 'client_credentials'])) {
129		$scopes = array_filter($scopes, function ($scope) {
130		return trim($scope->getIdentifier()) !== '*';
131		});
132		}
133
134		return array_filter($scopes, function ($scope) {
135		return static::hasScope($scope->getIdentifier());
136		});
137		}
138
139		/**
140		* Check scope exists or not.
141		*
142		* @param string $identifier
143		*
144		* @return bool
145		*/
146		public static function hasScope($identifier)
147		{
148		return trim($identifier) === '*' \|\| array_key_exists($identifier, array_flip(static::$scopes));
149		}
150
151		/**
152		* Check is isset a scope or not.
153		*
154		* @param string $identifier
155		*
156		* @return bool
157		*/
158		public static function isValidateScope($identifier)
159		{
160		return array_key_exists($identifier, array_flip(static::$scopes));
161		}
162
163		/**
164		* Make the authorization service instance.
165		*
166		* @return \League\OAuth2\Server\AuthorizationServer
167		*/
168		public function makeAuthorizationServer()
169		{
170		$encryptionKey = 'def00000069ceedc03a1f91fd51a49ce08ebb8580d688f4fbc3774c86aaa4df516eea0f72c1f62e3e577ec9f0c83c773b890222966bf93ac22e84a9eca55638be310665b';
171
172		$this->server = new AuthorizationServer(
		0 ignored issues – show Documentation Bug introduced 2020-06-18 07:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new \League\OAuth2\Serve...String($encryptionKey))` of type `object<League\OAuth2\Server\AuthorizationServer>` is incompatible with the declared type `string` of property `$server`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
173		new ClientRepository(),
174		new AccessTokenRepository(),
175		new ScopeRepository(),
176		$this->makeCryptKey('private'),
177		Key::loadFromAsciiSafeString($encryptionKey)
178		);
179
180		$this->server->setDefaultScope(static::$defaultScope);
181		$this->enableGrantTypes();
182
183		return $this->server;
184		}
185
186		/**
187		* Enable All grant types.
188		*
189		* @return void
190		*/
191		protected function enableGrantTypes()
192		{
193		$this->server->enableGrantType(
194		new ClientCredentialsGrant(),
195		new DateInterval(static::$tokensExpireAt) // access tokens will expire after 1 hour
196		);
197
198		$this->enableAuthCodeGrant();
199		$this->enablePasswordGrant();
200		$this->enableRefreshTokenGrant();
201
202		if (static::$isEnableImplicitGrant) {
203		$this->server->enableGrantType(
204		new ImplicitGrant(new DateInterval(static::$tokensExpireAt)),
205		new DateInterval(static::$tokensExpireAt) // access tokens will expire after 1 hour
206		);
207		}
208		}
209
210		/**
211		* Enable Authorization code Grant.
212		*
213		* @return void
214		*/
215	View Code Duplication	protected function enableAuthCodeGrant()
216		{
217		$authCodeGrant = new AuthCodeGrant(
218		new AuthCodeRepository(),
219		new RefreshTokenRepository(),
220		new DateInterval('PT10M')
221		);
222
223		$authCodeGrant->setRefreshTokenTTL(new DateInterval(static::$refreshTokensExpireAt));
224
225		$this->server->enableGrantType(
226		$authCodeGrant,
227		new DateInterval(static::$tokensExpireAt)
228		);
229		}
230
231		/**
232		* Enable Password Grant.
233		*
234		* @return void
235		*/
236	View Code Duplication	protected function enablePasswordGrant()
237		{
238		$passwordGrant = new PasswordGrant(
239		new UserRepository(),
240		new RefreshTokenRepository()
241		);
242
243		$passwordGrant->setRefreshTokenTTL(new DateInterval(static::$refreshTokensExpireAt)); // refresh tokens will expire after 1 month
244
245		// Enable the password grant on the server
246		$this->server->enableGrantType(
247		$passwordGrant,
248		new DateInterval(static::$tokensExpireAt) // access tokens will expire after 1 hour
249		);
250		}
251
252		/**
253		* Enable Refresh token Grant.
254		*
255		* @return void
256		*/
257	View Code Duplication	protected function enableRefreshTokenGrant()
258		{
259		$refreshTokenGrant = new RefreshTokenGrant(new RefreshTokenRepository());
260		$refreshTokenGrant->setRefreshTokenTTL(new \DateInterval(static::$refreshTokensExpireAt)); // new refresh tokens will expire after 1 month
261
262		// Enable the refresh token grant on the server
263		$this->server->enableGrantType(
264		$refreshTokenGrant,
265		new \DateInterval(static::$tokensExpireAt) // new access tokens will expire after an hour
266		);
267		}
268
269		/**
270		* Enable Implicit Grant.
271		*
272		* @param bool $isImplicit
273		*
274		* @return void
275		*/
276		public static function enableImplicitGrantType($isImplicit = true)
277		{
278		static::$isEnableImplicitGrant = $isImplicit;
		0 ignored issues – show Documentation Bug introduced 2020-07-07 04:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$isEnableImplicitGrant` was declared of type `string`, but `$isImplicit` is of type `boolean`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
279		}
280
281		/**
282		* Create a resource server for validation.
283		*
284		* @return \League\OAuth2\Server\ResourServer
285		*/
286		public function getResourceServer()
287		{
288		return new ResourceServer(
289		new AccessTokenRepository(),
290		$this->makeCryptKey('public')
291		);
292		}
293
294		/**
295		* Create a CryptKey instance without permissions check.
296		*
297		* @param string $key
298		*
299		* @return \League\OAuth2\Server\CryptKey
300		*/
301		protected function makeCryptKey($type)
302		{
303		$key = __DIR__.'/../storage/rsa/oauth-'.$type.'.key';
304
305		return new CryptKey($key, null, false);
306		}
307
308		public function validateUserForRequest($request)
309		{
310		$token = Model::instance('tokenModel')->find($request->getAttribute('oauth_access_token_id'));
311		$client = Model::instance('clientModel')->find($request->getAttribute('oauth_client_id'));
312
313		if (!$token \|\| !$client) {
314		return null;
315		}
316
317		if (!$token->user_id && !$client->user_id) {
318		return null;
319		}
320
321		if ($token->user_id != null) {
322		return $token->user_id;
323		}
324
325		return $client->user_id;
326		}
327
328		/**
329		* Load all routes.
330		*
331		* @return void
332		*/
333		public static function routes()
334		{
335		require __DIR__.'/../routes/oauth.php';
336		}
337
338		/**
339		* Migrate tables.
340		*
341		* @param string $dir
342		*
343		* @return void
344		*/
345	View Code Duplication	public static function migrate($dir = null)
346		{
347		if (is_null($dir)) {
348		$dir = __DIR__.'/../database/migrations';
349		}
350
351		foreach (glob($dir.'/*.php') as $file) {
352		require_once $file;
353		$table = pathinfo($file)['filename'];
354		(new $table())->up();
355		}
356		}
357
358		/**
359		* Drop tables.
360		*
361		* @param string $dir
362		*
363		* @return void
364		*/
365	View Code Duplication	public static function rollback($dir = null)
366		{
367		if (is_null($dir)) {
368		$dir = __DIR__.'/../database/migrations';
369		}
370
371		foreach (glob($dir.'/*.php') as $file) {
372		require_once $file;
373		$table = pathinfo($file)['filename'];
374		(new $table())->down();
375		}
376		}
377
378		/**
379		* Drop and migrate fresh tables.
380		*
381		* @param string $dir
382		*
383		* @return void
384		*/
385		public static function refresh($dir = null)
386		{
387		if (is_null($dir)) {
388		$dir = __DIR__.'/../database/migrations';
389		}
390
391		static::rollback($dir);
392		static::migrate($dir);
393		}
394		}
395

Codexshaper / oauth2

Issues (39)

Security Analysis no request data

src/Manager.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like