Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | View Code Duplication | class Term extends BaseModel |
|
|
|||
8 | { |
||
9 | protected $endpoint; |
||
10 | |||
11 | /** |
||
12 | * Retrieve all Items. |
||
13 | * |
||
14 | * @param integer $attribute_id |
||
15 | * @param array $options |
||
16 | * |
||
17 | * @return array |
||
18 | */ |
||
19 | protected function all($attribute_id, $options = []) |
||
23 | |||
24 | /** |
||
25 | * Retrieve single Item. |
||
26 | * |
||
27 | * @param int $attribute_id |
||
28 | * @param int $id |
||
29 | * @param array $options |
||
30 | * |
||
31 | * @return object |
||
32 | */ |
||
33 | protected function find($attribute_id, $id, $options = []) |
||
37 | |||
38 | /** |
||
39 | * Create new Item. |
||
40 | * |
||
41 | * @param int $attribute_id |
||
42 | * @param array $data |
||
43 | * |
||
44 | * @return object |
||
45 | */ |
||
46 | protected function create($attribute_id, $data) |
||
50 | |||
51 | /** |
||
52 | * Update Existing Item. |
||
53 | * |
||
54 | * @param int $attribute_id |
||
55 | * @param int $id |
||
56 | * @param array $data |
||
57 | * |
||
58 | * @return object |
||
59 | */ |
||
60 | protected function update($attribute_id, $id, $data) |
||
64 | |||
65 | /** |
||
66 | * Destroy Item. |
||
67 | * |
||
68 | * @param int $attribute_id |
||
69 | * @param int $id |
||
70 | * @param array $options |
||
71 | * |
||
72 | * @return object |
||
73 | */ |
||
74 | protected function delete($attribute_id, $id, $options = []) |
||
78 | |||
79 | /** |
||
80 | * Batch Update. |
||
81 | * |
||
82 | * @param int $attribute_id |
||
83 | * @param array $data |
||
84 | * |
||
85 | * @return object |
||
86 | */ |
||
87 | protected function batch($attribute_id, $data) |
||
91 | } |
||
92 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.