CodexShaper\PWA\PWA

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	routes()	0	4	1
A	assets()	0	28	4

<?php

namespace CodexShaper\PWA;

use Illuminate\Support\Facades\File;
use Illuminate\Support\Facades\Response;

class PWA
{
    public function routes()
    {
        require __DIR__.'/../routes/pwa.php';
    }

    /**
     * Load assests.
     *
     * @param string $path
     *
     * @return \Illuminate\Http\Response
     */
    public function assets($path)
    {
        $file = base_path(trim(config('pwa.resources_path'), '/').'/'.urldecode($path));

        if (File::exists($file)) {
            switch ($extension = pathinfo($file, PATHINFO_EXTENSION)) {

$extension is not used, you could remove the assignment.

                case 'js':
                    $mimeType = 'text/javascript';
                    break;
                case 'css':
                    $mimeType = 'text/css';
                    break;
                default:
                    $mimeType = File::mimeType($file);
                    break;
            }

            $response = Response::make(File::get($file), 200);
            $response->header('Content-Type', $mimeType);

It seems like $mimeType defined by \Illuminate\Support\Facades\File::mimeType($file) on line 35 can also be of type false; however, Illuminate\Http\ResponseTrait::header() does only seem to accept array|string, did you maybe forget to handle an error condition?

            $response->setSharedMaxAge(31536000);
            $response->setMaxAge(31536000);
            $response->setExpires(new \DateTime('+1 year'));

            return $response;
        }

        return response('', 404);

The expression response('', 404); of type Illuminate\Http\Response|Illuminate\Contracts\Routing\ResponseFactory adds the type Illuminate\Contracts\Routing\ResponseFactory to the return on line 48 which is incompatible with the return type documented by CodexShaper\PWA\PWA::assets of type Illuminate\Http\Response.

    }
}