UserController::generateError() - Code Metrics - Inspection of "Fixed display message for login validation, Remove..." - Codexshaper/laravel-database-manager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0b4fd8...dc5510 )

by CodexShaper

created 2020-01-14 08:56 UTC

UserController::generateError() A

↳ Parent: UserController

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	4
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	6
ccs	0
cts	6
cp	0
crap	2
rs	10

<?php

namespace CodexShaper\DBM\Http\Controllers;

use CodexShaper\DBM\Facades\Manager as DBM;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Config;
use Illuminate\Support\Facades\Response;
use Illuminate\Support\Facades\Validator;

class UserController extends Controller
{
    /**
     * Show login form
     *
     * @return \Illuminate\View\View|\Illuminate\Contracts\View\Factory
     */
    public function showLoginForm()
    {
        return view('dbm::admin');
    }
    /**
     * Login User for API
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function login(Request $request)
    {
        if ($request->ajax()) {
            try {
                $validator = Validator::make($request->data, [
                    'email'    => 'required|email',
                    'password' => 'required',

                ]);

                if ($validator->fails()) {
                    $errors = [];
                    foreach ($validator->errors()->all() as $error) {
                        $errors[] = $error;
                    }
                    return $this->generateError($errors);
                }
                $credentials = [
                    'email'    => $request->data['email'],
                    'password' => $request->data['password'],
                ];

                if (!Auth::attempt($credentials)) {
                    return $this->generateError(["Email and password combination doesn't match"]);
                }

                $user   = Auth::user();
                $expiry = Config::get('dbm.auth.token.expiry');
                if (count($user->tokens) > 0) {

                    $user->tokens()->delete();
                }
                return response()->json([
                    'success' => true,
                    'user'    => $user,
                    'token'   => $user->createToken('DBM')->accessToken,
                    'expiry'  => $expiry,
                ]);

            } catch (\Exception $e) {
                $this->generateError([$e->getMessage()]);
            }
        }
        return response()->json(["success" => false, "error" => "Unauthorised"], 401);

    }
    /**
     * Generate errors and return response
     *
     * @param array $errors
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function generateError($errors)
    {
        return response()->json([
            'success' => false,
            'errors'  => $errors,
        ], 400);
    }
}


1			<?php
2
3			namespace CodexShaper\DBM\Http\Controllers;
4
5			use CodexShaper\DBM\Facades\Manager as DBM;
6			use Illuminate\Http\Request;
7			use Illuminate\Support\Facades\Auth;
8			use Illuminate\Support\Facades\Config;
9			use Illuminate\Support\Facades\Response;
10			use Illuminate\Support\Facades\Validator;
11
12			class UserController extends Controller
13			{
14			/**
15			* Show login form
16			*
17			* @return \Illuminate\View\View\|\Illuminate\Contracts\View\Factory
18			*/
19			public function showLoginForm()
20			{
21			return view('dbm::admin');
22			}
23			/**
24			* Login User for API
25			*
26			* @return \Illuminate\Http\JsonResponse
27			*/
28			public function login(Request $request)
29			{
30			if ($request->ajax()) {
31			try {
32			$validator = Validator::make($request->data, [
33			'email' => 'required\|email',
34			'password' => 'required',
35
36			]);
37
38			if ($validator->fails()) {
39			$errors = [];
40			foreach ($validator->errors()->all() as $error) {
41			$errors[] = $error;
42			}
43			return $this->generateError($errors);
44			}
45			$credentials = [
46			'email' => $request->data['email'],
47			'password' => $request->data['password'],
48			];
49
50			if (!Auth::attempt($credentials)) {
51			return $this->generateError(["Email and password combination doesn't match"]);
52			}
53
54			$user = Auth::user();
55			$expiry = Config::get('dbm.auth.token.expiry');
56			if (count($user->tokens) > 0) {
			0 ignored issues – show Bug introduced 2020-01-06 23:49 UTC by Report Bug Copy Issue Report Accessing `tokens` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
57			$user->tokens()->delete();
58			}
59			return response()->json([
60			'success' => true,
61			'user' => $user,
62			'token' => $user->createToken('DBM')->accessToken,
63			'expiry' => $expiry,
64			]);
65
66			} catch (\Exception $e) {
67			$this->generateError([$e->getMessage()]);
68			}
69			}
70			return response()->json(["success" => false, "error" => "Unauthorised"], 401);
71
72			}
73			/**
74			* Generate errors and return response
75			*
76			* @param array $errors
77			*
78			* @return \Illuminate\Http\JsonResponse
79			*/
80			public function generateError($errors)
81			{
82			return response()->json([
83			'success' => false,
84			'errors' => $errors,
85			], 400);
86			}
87			}
88

Codexshaper / laravel-database-manager

Push — master ( 0b4fd8...dc5510 )

UserController::generateError() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like