App\Service\Admin\SettingsService

Complexity

Total Complexity

11

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	updateSettings()	0	5	1
A	uploadImage()	0	14	2
A	isImageValid()	0	14	2
A	resetImage()	0	14	4
A	deleteImage()	0	9	1

<?php

declare(strict_types=1);

namespace App\Service\Admin;

use App\Repository\SettingsRepository;
use App\Service\AbstractService;
use App\Service\FileUploader;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\Session\SessionInterface;
use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface;
use Symfony\Component\Validator\ConstraintViolation;

final class SettingsService extends AbstractService
{
    /**
     * @var SettingsRepository
     */
    private $repository;

    /**
     * @var FileUploader
     */
    private $fileUploader;

    public function __construct(
        CsrfTokenManagerInterface $tokenManager,
        SessionInterface $session,
        SettingsRepository $repository,
        FileUploader $fileUploader
    ) {
        parent::__construct($tokenManager, $session);
        $this->repository = $repository;
        $this->fileUploader = $fileUploader;
    }

    /**
     * Update settings in database.
     */
    public function updateSettings(array $formData): void
    {
        $this->repository->updateSettings($formData);
        $this->addFlash('success', 'message.updated');
    }

    /**
     * Upload custom header image.
     *
     * @param string  $type
     * @param Request $request
     *
     * @return Response
     * @throws \Exception
     */
    public function uploadImage(string $type = 'header_image', Request $request): Response
    {
        /** @var UploadedFile $uploadedFile */
        $uploadedFile = $request->files->get('file');

        if (!$this->isImageValid($uploadedFile)) {
            return new JsonResponse(['status' => 'error']);
        }

        $fileName = $this->fileUploader->upload($uploadedFile);
        $this->repository->updateSetting($type, $fileName);

        return new JsonResponse(['status' => 'ok']);
    }

    /**
     * Validate header image.
     */
    private function isImageValid(UploadedFile $uploadedFile): bool
    {
        $violations = $this->fileUploader->validate($uploadedFile);

        if ($violations->count() > 0) {
            /** @var ConstraintViolation $violation */
            $violation = $violations[0];
            $this->addFlash('danger', $violation->getMessage());

It seems like $violation->getMessage() targeting Symfony\Component\Validator\ConstraintViolation::getMessage() can also be of type object<Stringable>; however, App\Service\AbstractService::addFlash() does only seem to accept string, maybe add an additional type check?

            return false;
        }

        return true;
    }

    /**
     * Reset a header image to the default image.
     *
     * @param string  $type
     * @param Request $request
     */
    public function resetImage(string $type = 'header_image', Request $request): void
    {
        $setting = $this->repository->findOneBy(['setting_name' => $type]);

        if ($setting && $this->isCsrfTokenValid('delete', $request->request->get('token'))) {
            // Find filename
            $filename = $setting->getSettingValue();

            if ($filename) {
                // Delete
                $this->deleteImage($filename, $type);
            }
        }
    }

    /**
     * Delete header image.
     *
     * @param string $filename
     * @param string $type
     */
    private function deleteImage(string $filename, string $type = 'header_image'): void
    {
        // Delete file from folder
        $this->fileUploader->remove($filename);
        // Delete from db
        $this->repository->updateSetting($type, '');
        // Add flash message
        $this->addFlash('success', 'message.deleted');
    }
}