SimilarRepository::findByArea() - Code Metrics - Coderberg/ResidenceCMS - Measure and Improve Code Quality continuously with Scrutinizer

SimilarRepository::findByArea() A
last analyzed 2022-07-21 00:40 UTC

↳ Parent: SimilarRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	10
c	1
b	0
f	0
nc	2
nop	2
dl	0
loc	15
rs	9.9332

<?php

declare(strict_types=1);

namespace App\Repository;

use App\Entity\Property;

final class SimilarRepository extends PropertyRepository
{
    public const NUM_ITEMS = 6;

    public function findSimilarProperties(Property $property): array
    {
        if (!$this->isModuleEnabled()) {
            return [];
        }

        if ($property->getNeighborhood()) {
            // Find in a small area
            $result = $this->findByArea($property, 'neighborhood');

            if (empty($result) && $property->getDistrict()) {
                // Find in a larger area
                $result = $this->findByArea($property);
            }

            return $result;
        } elseif ($property->getDistrict()) {
            return $this->findByArea($property);
        }

        return [];
    }

    private function findByArea(Property $property, string $area = 'district'): array
    {
        $qb = $this->createQueryBuilder('p')
            ->where("p.state = 'published'")
            ->andWhere('p.id != '.(int) ($property->getId()))
            ->andWhere('p.deal_type = '.(int) ($property->getDealType()->getId()))
            ->andWhere('p.category = '.(int) ($property->getCategory()->getId()));

        if ('neighborhood' === $area) {
            $qb->andWhere('p.neighborhood = '.(int) ($property->getNeighborhood()->getId()));
        } else {
            $qb->andWhere('p.district = '.(int) ($property->getDistrict()->getId()));
        }

        return $qb->getQuery()->setMaxResults(self::NUM_ITEMS)->getResult();

    }

    private function isModuleEnabled(): bool
    {
        $repository = $this->getEntityManager()->getRepository('App:Settings');
        $state = $repository->findOneBy(['setting_name' => 'show_similar_properties']);

        return '1' === $state->getSettingValue();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace App\Repository;
6
7			use App\Entity\Property;
8
9			final class SimilarRepository extends PropertyRepository
10			{
11			public const NUM_ITEMS = 6;
12
13			public function findSimilarProperties(Property $property): array
14			{
15			if (!$this->isModuleEnabled()) {
16			return [];
17			}
18
19			if ($property->getNeighborhood()) {
20			// Find in a small area
21			$result = $this->findByArea($property, 'neighborhood');
22
23			if (empty($result) && $property->getDistrict()) {
24			// Find in a larger area
25			$result = $this->findByArea($property);
26			}
27
28			return $result;
29			} elseif ($property->getDistrict()) {
30			return $this->findByArea($property);
31			}
32
33			return [];
34			}
35
36			private function findByArea(Property $property, string $area = 'district'): array
37			{
38			$qb = $this->createQueryBuilder('p')
39			->where("p.state = 'published'")
40			->andWhere('p.id != '.(int) ($property->getId()))
41			->andWhere('p.deal_type = '.(int) ($property->getDealType()->getId()))
42			->andWhere('p.category = '.(int) ($property->getCategory()->getId()));
43
44			if ('neighborhood' === $area) {
45			$qb->andWhere('p.neighborhood = '.(int) ($property->getNeighborhood()->getId()));
46			} else {
47			$qb->andWhere('p.district = '.(int) ($property->getDistrict()->getId()));
48			}
49
50			return $qb->getQuery()->setMaxResults(self::NUM_ITEMS)->getResult();
			0 ignored issues – show Bug Best Practice introduced 2021-08-18 07:40 UTC by Report Bug Copy Issue Report The expression `return $qb->getQuery()->...NUM_ITEMS)->getResult()` could return the type `integer` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
51			}
52
53			private function isModuleEnabled(): bool
54			{
55			$repository = $this->getEntityManager()->getRepository('App:Settings');
56			$state = $repository->findOneBy(['setting_name' => 'show_similar_properties']);
57
58			return '1' === $state->getSettingValue();
59			}
60			}
61

Coderberg / ResidenceCMS

SimilarRepository::findByArea() A last analyzed 2022-07-21 00:40 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SimilarRepository::findByArea() A
last analyzed 2022-07-21 00:40 UTC