Currency::__toString() - Code Metrics - Code-Mine-Development/valueobjects - Measure and Improve Code Quality continuously with Scrutinizer

Currency::__toString() A
last analyzed 2018-01-24 14:05 UTC

↳ Parent: Currency

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

namespace ValueObjects\Money;

use Money\Currency as BaseCurrency;
use ValueObjects\Util\Util;
use ValueObjects\ValueObjectInterface;

class Currency implements ValueObjectInterface
{
    /** @var BaseCurrency */
    protected $currency;

    /** @var CurrencyCode  */
    protected $code;

    /**
     * Returns a new Currency object from native string currency code
     *
     * @param  string $code Currency code
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return static
     */
    public static function fromNative()
    {
        $code = CurrencyCode::get(func_get_arg(0));

        return new static($code);
    }

    public function __construct(CurrencyCode $code)
    {
        $this->code     = $code;
        $this->currency = new BaseCurrency($code->toNative());
    }

    /**
     * Tells whether two Currency are equal by comparing their names
     *
     * @param  ValueObjectInterface $currency
     * @return bool
     */
    public function sameValueAs(ValueObjectInterface $currency)
    {
        if (false === Util::classEquals($this, $currency)) {
            return false;
        }

        return $this->getCode()->toNative() == $currency->getCode()->toNative();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * Returns currency code
     *
     * @return CurrencyCode
     */
    public function getCode()
    {
        return $this->code;
    }

    /**
     * Returns string representation of the currency
     *
     * @return string
     */
    public function __toString()
    {
        return $this->getCode()->toNative();

    }

    function jsonSerialize()

    {
        return $this->code;
    }


}


1		<?php
2
3		namespace ValueObjects\Money;
4
5		use Money\Currency as BaseCurrency;
6		use ValueObjects\Util\Util;
7		use ValueObjects\ValueObjectInterface;
8
9		class Currency implements ValueObjectInterface
10		{
11		/** @var BaseCurrency */
12		protected $currency;
13
14		/** @var CurrencyCode */
15		protected $code;
16
17		/**
18		* Returns a new Currency object from native string currency code
19		*
20		* @param string $code Currency code
		0 ignored issues – show Bug introduced 2016-04-25 08:47 UTC by Report Bug Copy Issue Report There is no parameter named `$code`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
21		* @return static
22		*/
23	2	public static function fromNative()
24		{
25	2	$code = CurrencyCode::get(func_get_arg(0));
26
27	2	return new static($code);
28		}
29
30	13	public function __construct(CurrencyCode $code)
31		{
32	13	$this->code = $code;
33	13	$this->currency = new BaseCurrency($code->toNative());
34	13	}
35
36		/**
37		* Tells whether two Currency are equal by comparing their names
38		*
39		* @param ValueObjectInterface $currency
40		* @return bool
41		*/
42	4	public function sameValueAs(ValueObjectInterface $currency)
43		{
44	4	if (false === Util::classEquals($this, $currency)) {
45	1	return false;
46		}
47
48	4	return $this->getCode()->toNative() == $currency->getCode()->toNative();
		0 ignored issues – show Bug introduced 2016-04-25 08:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ValueObjects\ValueObjectInterface` as the method `getCode()` does only exist in the following implementations of said interface: `ValueObjects\Geography\Country`, `ValueObjects\Money\Currency`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
49		}
50
51		/**
52		* Returns currency code
53		*
54		* @return CurrencyCode
55		*/
56	13	public function getCode()
57		{
58	13	return $this->code;
59		}
60
61		/**
62		* Returns string representation of the currency
63		*
64		* @return string
65		*/
66	1	public function __toString()
67		{
68	1	return $this->getCode()->toNative();
		0 ignored issues – show Bug Compatibility introduced 2016-04-25 08:47 UTC by Report Bug Copy Issue Report The expression `$this->getCode()->toNative();` of type `null\|boolean\|integer\|double\|string` adds the type `boolean` to the return on line 68 which is incompatible with the return type declared by the interface `ValueObjects\ValueObjectInterface::__toString` of type `string`. Loading history...
69		}
70
71		function jsonSerialize()
		0 ignored issues – show Best Practice introduced 2016-04-25 08:47 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Comprehensibility Best Practice introduced 2016-04-25 08:47 UTC by Report Bug Copy Issue Report It is recommend to declare an explicit visibility for `jsonSerialize`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
72		{
73		return $this->code;
74		}
75
76
77		}
78

Code-Mine-Development / valueobjects

Currency::__toString() A last analyzed 2018-01-24 14:05 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

Currency::__toString() A
last analyzed 2018-01-24 14:05 UTC