CodeMine\ConfluenceImporter\Service\Confluence

Complexity

Total Complexity

15

Size/Duplication

Total Lines	196
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	4
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	createNewPage()	0	48	5
B	getPageId()	0	46	4
A	getBase64Credentials()	0	10	1
A	getHeaders()	0	9	1
B	getBody()	0	28	2
A	getRequest()	0	5	1

<?php

namespace CodeMine\ConfluenceImporter\Service;

use CodeMine\ConfluenceImporter\Documentation\PageInterface;
use CodeMine\ConfluenceImporter\Service\Confluence\InstanceInterface;
use GuzzleHttp\ClientInterface;
use GuzzleHttp\Exception\BadResponseException;
use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Psr7\Request;
use GuzzleHttp\Psr7\Stream;

/**
 * Class Confluence
 *
 * @package CodeMine\ConfluenceImporter\Service
 */
class Confluence
{
    const ADD_PAGE = 'rest/api/content';

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

    const SEARCH_PAGE = 'rest/api/content/search?cql=title="%s" and space="%s"';

    /**
     * @var \GuzzleHttp\ClientInterface
     */
    private $client;
    /**
     * @var \CodeMine\ConfluenceImporter\Service\InstanceInterface
     */
    private $confluenceInstance;

    /**
     * Confluence constructor.
     *
     * @param \GuzzleHttp\ClientInterface $client
     * @param \CodeMine\ConfluenceImporter\Service\Confluence\InstanceInterface $confluenceInstance
     */
    public function __construct(ClientInterface $client, InstanceInterface $confluenceInstance)
    {
        $this->client = $client;

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

        $this->confluenceInstance = $confluenceInstance;

It seems like $confluenceInstance of type object<CodeMine\ConfluenceImporter\Service\Confluence\InstanceInterface> is incompatible with the declared type object<CodeMine\ConfluenceImporter\Service\InstanceInterface> of property $confluenceInstance.

    }

    public function createNewPage(string $key, PageInterface $page, PageInterface $parentPage = NULL)
    {

        $body = $this->getBody($key, $page, $parentPage);

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $headers = $this->getHeaders();



        try {
            $request = $this->getRequest($headers, $body);

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

            $response = $this->client->send($request); //TODO: find solution for exception on same page name

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

            $pageChildren = $page->children();
            if (null !== $pageChildren){
                var_dump('1');

var_dump('1'); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

                var_dump(urlencode('"sda sd"'));die;

The method createNewPage() contains an exit expression.

It is generally recommended to place each PHP statement on a line by itself.

                foreach($pageChildren as $pageChild){

foreach ($pageChildren as $pageChild) { var_dump('2'); $childBody = $this->getBody($key, $pageChild, $page); var_dump('child body'); $childRequest = $this->getRequest($headers, $pageChild); try { var_dump('3'); $this->client->send($request); } catch (\Exception $e) { var_dump($e->getMessage()); } } does not seem to be reachable.

                    var_dump('2');

                    $childBody = $this->getBody($key, $pageChild, $page);

$childBody is not used, you could remove the assignment.

                    var_dump('child body');
                    $childRequest = $this->getRequest($headers, $pageChild);

$childRequest is not used, you could remove the assignment.

                    try {
                        var_dump('3');

                        $this->client->send($request);
                    }catch(\Exception $e){
                        var_dump($e->getMessage());
                    }
                }

                var_dump(urlencode('"sda sd"'));die;

The method createNewPage() contains an exit expression.

It is generally recommended to place each PHP statement on a line by itself.

            }
//            var_dump($response->);

72% of this comment could be valid code. Did you maybe forget this after debugging?

        }catch(ClientException $e){

            echo 'ERROR!';
            var_dump($e->getMessage());
            echo 'ERROR!!!';

            return FALSE;
        }
        $returnBody = $response->getBody();
        $stdBody = json_decode($returnBody->getContents());

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $pageId = (string)$stdBody->id;

$pageId is not used, you could remove the assignment.

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

        return TRUE;
    }

    public function getPageId(string $key, PageInterface $page) //TODO::Change for private method
    {
        $headers = [
            'Authorization' => 'Basic ' . $this->getBase64Credentials(),
        ];

        $url = sprintf(Confluence::SEARCH_PAGE, $page->title(), $key);

As per coding style, self should be used for accessing local static members.

        var_dump($url);

var_dump($url); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

        var_dump('ID');
        $request = new Request('GET', $url, $headers);

        try {
            var_dump('try');
//var_dump($request);die;

86% of this comment could be valid code. Did you maybe forget this after debugging?

            $response = $this->client->send($request);
        }catch(\Exception $e){
            var_dump('EEEEEEEEEEEEEEEERRRROOOOOOOOOOOOR');
            var_dump($e->getMessage());
            die;

The method getPageId() contains an exit expression.

        }
var_dump($response->getBody());die;

The method getPageId() contains an exit expression.

It is generally recommended to place each PHP statement on a line by itself.

        /** @var Stream $returnBody */
        $returnBody = $response->getBody();

/** @var Stream $returnBody */ $returnBody = $response->getBody(); does not seem to be reachable.

        $returnBody->
        $e = $response->getHeaders();

Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space

        $stdBody = json_decode($returnBody->getContents());

//        var_dump($stdBody);

61% of this comment could be valid code. Did you maybe forget this after debugging?

//        var_dump($response->getStatusCode());
//        var_dump(count($stdBody->results));
//        var_dump($stdBody->results);

        if ($response->getStatusCode() == 200 && count($stdBody->results) == 1){

The variable $response seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

The variable $stdBody seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

            $id = (string)$stdBody->results[0]->id;

            return $id;

        }

        throw new \Exception('ERROR!!!!');

    }

    /**
     * @return string
     */
    private function getBase64Credentials()
    {
        $base64Credentials = base64_encode(
            $this->confluenceInstance->username() .
            ':' .
            $this->confluenceInstance->password()
        );

        return $base64Credentials;
    }

    /**
     * @return array

Consider making the return type a bit more specific; maybe use array<string,string>.

     */
    private function getHeaders()
    {
        $headers = [
            'Authorization' => 'Basic ' . $this->getBase64Credentials(),
            'Content-Type' => 'application/json'
        ];

        return $headers;
    }

    /**
     * @param string $key
     * @param PageInterface $page
     * @param PageInterface|NULL $parentPage
     * @return string<json>

The doc-type string<json> could not be parsed: Expected "|" or "end of type", but got "<" at position 6. (view supported doc-types)

     * @throws \Exception
     */
    private function getBody(string $key, PageInterface $page, PageInterface $parentPage = NULL)
    {
        $bodyArray = [
            'type' => 'page',
            'title' => $page->title(),
            'space' => [
                'key' => $key
            ],
            'body' => [
                'storage' => [
                    'value' => $page->content(),
                    'representation' => 'storage'
                ]
            ]
        ];

        if (isset($parentPage)) {
            $parentPageId = $this->getPageId($key, $parentPage);

            $bodyArray['ancestors'] = [
                ['id' => $parentPageId]
            ];
        }

        $body = json_encode($bodyArray);

        return $body;
    }

    /**
     * @param $headers
     * @param $body
     * @return Request
     */
    private function getRequest($headers, $body)
    {
        $request = new Request('POST', Confluence::ADD_PAGE, $headers, $body);

As per coding style, self should be used for accessing local static members.

        return $request;
    }
}
/*
curl -u admin:admin -X POST -H 'Content-Type: application/json' -d'
{"type":"page",
"title":"new page",
 ancestors:[{"id":456}], "space":{"key":"TST"},"body":{"storage":{"value":"<p>This is a new page</p>",
"representation":"storage"}}}' http://localhost:8080/confluence/rest/api/content/ | python -mjson.tool
*/