Performance - Code Metrics - Inspection of "FIx error on Performance" - CloudFramework-io/CFCore - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bd55da...3ee42d )

by Fran

created 2016-01-19 08:39 UTC

Performance A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	99
Duplicated Lines	12.12 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

13.24%

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
wmc	33
c	2
b	1
f	0
lcom	1
cbo	1
dl	12
loc	99
ccs	9
cts	68
cp	0.1324
rs	9.3999

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
F	add()	8	44	17
A	init()	0	6	1
A	end()	0	7	2
C	getLog()	4	21	12

How to fix Duplicated Code

<?php


namespace CloudFramework\Tool;

use CloudFramework\CloudFrameworkApp;
use CloudFramework\Patterns\Singleton;

class Performance extends Singleton
{

    var $data;
class A {
    var $property;
}

    function __construct()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // Performance Vars
        $this->data['initMicrotime'] = microtime(TRUE);
        $this->data['lastMicrotime'] = $this->data['initMicrotime'];
        $this->data['initMemory'] = memory_get_usage() / (1024 * 1024);
        $this->data['lastMemory'] = $this->data['initMemory'];
        $this->data['lastIndex'] = 1;
        $this->data['info'][] = 'File: ' . str_replace($_SERVER['DOCUMENT_ROOT'], '', __FILE__);
        $this->data['info'][] = 'Init Memory Usage: ' . number_format(round($this->data['initMemory'], 4), 4) . 'Mb';
    }

    function add($title, $file = '', $type = 'all')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // Hidding full path (security)
        $file = str_replace($_SERVER['DOCUMENT_ROOT'], '', $file);


        if ($type == 'note') $line = "[$type";
        else $line = $this->data['lastIndex'] . ' [';

        if (strlen($file)) $file = " ($file)";

        $_mem = memory_get_usage() / (1024 * 1024) - $this->data['lastMemory'];
        if ($type == 'all' || $type == 'endnote' || $type == 'memory' || $_GET['data'] == $this->data['lastIndex']) {

            $line .= number_format(round($_mem, 3), 3) . ' Mb';
            $this->data['lastMemory'] = memory_get_usage() / (1024 * 1024);
        }

        $_time = microtime(TRUE) - $this->data['lastMicrotime'];
        if ($type == 'all' || $type == 'endnote' || $type == 'time' || $_GET['data'] == $this->data['lastIndex']) {

            $line .= (($line == '[') ? '' : ', ') . (round($_time, 3)) . ' secs';
            $this->data['lastMicrotime'] = microtime(TRUE);
        }
        $line .= '] ' . $title;
        $line = (($type != 'note') ? '[' . number_format(round(memory_get_usage() / (1024 * 1024), 3), 3) . ' Mb, '
                . (round(microtime(TRUE) - $this->data['initMicrotime'], 3))
                . ' secs] / ' : '') . $line . $file;
        if ($type == 'endnote') $line = "[$type] " . $line;
        $this->data['info'][] = $line;

        if ($title) {
            $this->data['titles'][$title]['mem'] = $_mem;
            $this->data['titles'][$title]['time'] += $_time;
            $this->data['titles'][$title]['lastIndex'] = $this->data['lastIndex'];

        }

        if (isset($_GET['__p']) && $_GET['__p'] == $this->data['lastIndex']) {
            __sp();
            exit;

        }

        $this->data['lastIndex']++;

    }

    function init($spacename, $key)

    {
        $this->data['init'][$spacename][$key]['mem'] = memory_get_usage();
        $this->data['init'][$spacename][$key]['time'] = microtime(TRUE);
        $this->data['init'][$spacename][$key]['ok'] = TRUE;
    }

    function end($spacename, $key, $ok = TRUE, $msg = FALSE)

    {
        $this->data['init'][$spacename][$key]['mem'] = round((memory_get_usage() - $this->data['init'][$spacename][$key]['mem']) / (1024 * 1024), 3) . ' Mb';
        $this->data['init'][$spacename][$key]['time'] = round(microtime(TRUE) - $this->data['init'][$spacename][$key]['time'], 3) . ' secs';
        $this->data['init'][$spacename][$key]['ok'] = $ok;
        if ($msg !== FALSE) $this->data['init'][$spacename][$key]['notes'] = $msg;
    }

    function getLog()

    {
        $ret = '';
        $spaces = "";
        if (is_array($this->data['info']))
            foreach ($this->data['info'] as $key => $value) {
                if (is_string($value) && strpos($value, '[endnote]') !== FALSE) $spaces = substr($spaces, 0, -2);

                $ret .= $spaces;
                $ret .= ((is_string($value)) ? $value : print_r($value, TRUE)) . "\n";
                if (is_string($value) && strpos($value, '[note]') !== FALSE) $spaces .= "  ";
                if (is_string($value) && strpos($value, '[endnote]') !== FALSE) $ret .= "\n";

            }
        $ret .= "\n\nTOTALS:\n";
        if (is_array($this->data['titles']))
            foreach ($this->data['titles'] as $key => $value) {

                $ret .= "[$key] : " . round($value['mem'], 3) . ' Mb / ' . round($value['time'], 3) . " secs.\n";
            }

        return $ret;
    }
}

// Performance Functions
$__p = Performance::getInstance();

function __sp($title = '', $top = "<!--\n", $bottom = "\n-->")
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{

    $__p = Performance::getInstance();
    $addhtml = '';

    if (isset($_GET['debug'])) {
        if (is_object($adnbp)) {
            $__p->data['info'][] = 'Object ADNBP';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $__p->data['info'][] = $adnbp;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        $__p->data['info'][] = '$_SERVER';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $__p->data['info'][] = $_SERVER;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
    echo $top;
    echo $title;
    $spaces = "";
    foreach ($__p->data['info'] as $key => $value) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if (is_string($value) && strpos($value, '[endnote]') !== FALSE) $spaces = substr($spaces, 0, -2);

        echo $spaces;
        echo ((is_string($value)) ? $value : print_r($value, TRUE)) . "\n";
        if (is_string($value) && strpos($value, '[note]') !== FALSE) $spaces .= "  ";
        if (is_string($value) && strpos($value, '[endnote]') !== FALSE) echo "\n";

    }
    echo "\n\nTOTALS:\n";
    foreach ($__p->data['titles'] as $key => $value) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        echo "[$key] : " . round($value['mem'], 3) . ' Mb / ' . round($value['time'], 3) . " secs.\n";
    }
    echo $addhtml;
    echo $bottom;
}

function __p($title = NULL, $file = NULL, $type = 'all')
{
    $__p = Performance::getInstance();
    if ($title === NULL && $file == NULL) return $__p->data;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    else $__p->add($title, $file, $type);
}

function __print($args)
{
    echo "<pre>";
    for ($i = 0, $tr = count($args); $i < $tr; $i++) {
        if ($args[$i] === "exit")
            exit;

        echo "\n<li>[$i]: ";
        if (is_array($args[$i]))
            echo print_r($args[$i], TRUE);
        else if (is_object($args[$i]))
            echo var_dump($args[$i]);

        else if (is_bool($args[$i]))
            echo ($args[$i]) ? 'true' : 'false';
        else if (is_null($args[$i]))
            echo 'NULL';
        else
            echo $args[$i];
    }
    echo "</pre>";
}

function _print()
{
    __print(func_get_args());
}

function _printe()
{
    __print(array_merge(func_get_args(), array('exit')));
}

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-19 08:47 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 8 and the first side effect is on line 109. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3		namespace CloudFramework\Tool;
4
5		use CloudFramework\CloudFrameworkApp;
6		use CloudFramework\Patterns\Singleton;
7
8		class Performance extends Singleton
9		{
10
11		var $data;
		0 ignored issues – show Coding Style introduced 2016-01-19 08:47 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$data`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
12
13	1	function __construct()
		0 ignored issues – show Best Practice introduced 2016-01-19 08:47 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style introduced 2016-01-19 08:47 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
14		{
15		// Performance Vars
16	1	$this->data['initMicrotime'] = microtime(TRUE);
17	1	$this->data['lastMicrotime'] = $this->data['initMicrotime'];
18	1	$this->data['initMemory'] = memory_get_usage() / (1024 * 1024);
19	1	$this->data['lastMemory'] = $this->data['initMemory'];
20	1	$this->data['lastIndex'] = 1;
21	1	$this->data['info'][] = 'File: ' . str_replace($_SERVER['DOCUMENT_ROOT'], '', __FILE__);
22	1	$this->data['info'][] = 'Init Memory Usage: ' . number_format(round($this->data['initMemory'], 4), 4) . 'Mb';
23	1	}
24
25		function add($title, $file = '', $type = 'all')
		0 ignored issues – show Best Practice introduced 2016-01-19 08:47 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style introduced 2016-01-19 08:47 UTC by Report Bug Copy Issue Report `add` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-01-19 08:47 UTC by Report Bug Copy Issue Report `add` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
26		{
27		// Hidding full path (security)
28		$file = str_replace($_SERVER['DOCUMENT_ROOT'], '', $file);
29
30
31		if ($type == 'note') $line = "[$type";
32		else $line = $this->data['lastIndex'] . ' [';
33
34		if (strlen($file)) $file = " ($file)";
35
36		$_mem = memory_get_usage() / (1024 * 1024) - $this->data['lastMemory'];

CloudFramework-io / CFCore

Push — master ( bd55da...3ee42d )

Performance A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like