Logstash::write() - Code Metrics - Inspection of "issue#11: Catch connection to Logstash exception" - ClearcodeHQ/SimpleBusElkBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

unknown

created 2016-01-26 16:36 UTC

Logstash::write() A

↳ Parent: Logstash

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	3
eloc	7
nc	3
nop	1

<?php

namespace Clearcode\SimpleBusElkBundle\Logstash;

use Clearcode\SimpleBusElkBundle\Converter\DataToConvertIsNotAnObject;
use Clearcode\SimpleBusElkBundle\Converter\ObjectToArrayConverterInterface;
use Psr\Log\LoggerInterface;

class Logstash
{
    /** @var LoggerInterface */
    private $logger;
    /** @var ObjectToArrayConverterInterface */
    private $converter;

    /**
     * @param LoggerInterface                 $logger
     * @param ObjectToArrayConverterInterface $converter
     */
    public function __construct(LoggerInterface $logger, ObjectToArrayConverterInterface $converter)
    {
        $this->logger = $logger;
        $this->converter = $converter;
    }

    /**
     * @param $object
     *
     * @throws CannotWriteToLogstash
     */
    public function write($object)
    {
        try {
            $this->logger->info('Event recorded', $this->converter->toArray($object));

        } catch (DataToConvertIsNotAnObject $e) {
            $this->handleError(sprintf('Data conversion problem during writing to logstash: %s', $e->getMessage()));
        } catch (\Exception $e) {
            $this->handleError(sprintf('Connection with logstash error: %s', $e->getMessage()));
        }
    }

    private function handleError($message)
    {
        throw new CannotWriteToLogstash($message);
    }
}


1			<?php
2
3			namespace Clearcode\SimpleBusElkBundle\Logstash;
4
5			use Clearcode\SimpleBusElkBundle\Converter\DataToConvertIsNotAnObject;
6			use Clearcode\SimpleBusElkBundle\Converter\ObjectToArrayConverterInterface;
7			use Psr\Log\LoggerInterface;
8
9			class Logstash
10			{
11			/** @var LoggerInterface */
12			private $logger;
13			/** @var ObjectToArrayConverterInterface */
14			private $converter;
15
16			/**
17			* @param LoggerInterface $logger
18			* @param ObjectToArrayConverterInterface $converter
19			*/
20			public function __construct(LoggerInterface $logger, ObjectToArrayConverterInterface $converter)
21			{
22			$this->logger = $logger;
23			$this->converter = $converter;
24			}
25
26			/**
27			* @param $object
28			*
29			* @throws CannotWriteToLogstash
30			*/
31			public function write($object)
32			{
33			try {
34			$this->logger->info('Event recorded', $this->converter->toArray($object));
35
36			} catch (DataToConvertIsNotAnObject $e) {
37			$this->handleError(sprintf('Data conversion problem during writing to logstash: %s', $e->getMessage()));
38			} catch (\Exception $e) {
39			$this->handleError(sprintf('Connection with logstash error: %s', $e->getMessage()));
40			}
41			}
42
43			private function handleError($message)
44			{
45			throw new CannotWriteToLogstash($message);
46			}
47			}
48

ClearcodeHQ / SimpleBusElkBundle

Pull Request — master (#14)

Logstash::write() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like