AJAX - Code Metrics - Inspection of "Add time support" - Chronyms/Qitsune - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e0afd3...2df211 )

by Caspar

created 2017-10-12 18:36 UTC

AJAX A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	23
Duplicated Lines	34.78 %

Importance

Changes	4
Bugs	2	Features	0

Metric	Value
dl	8
loc	23
rs	10
c	4
b	2
f	0
wmc	3

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setRank()	8	8	2
A	ranking()	0	11	1

How to fix Duplicated Code

<?php

namespace App\Http\Controllers;

use DB;

class AJAX extends Controller
{
    public function ranking()
    {
	    $this->setRank();

	    $rankObj = DB::select('SELECT * FROM users WHERE total_points > 0 ORDER BY total_points DESC,rank;');
	    $rankArray = json_decode(json_encode($rankObj), true);
	    $userRank = count($rankArray);

	    return view('leader.ranking', ['rankArray' => $rankArray, 'userRank' => $userRank]);

        return view('leader.ranking', ['rankArray' => $rankArray, 'userRank' => $userRank])->renderSections()['dynamicRanking'];
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

	private function setRank()

	{
		$totalPoints = CodeCount::getTotalPoints();
		$rankObj = DB::select('SELECT * FROM users WHERE total_points = '.$totalPoints.' ORDER BY TIMEDIFF(start, end) DESC;');

		for($i = 0; $i < count($rankObj); $i++){
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
			DB::table('users')->where('name_gen', $rankObj[$i]->name_gen)->update(['rank' => (++$i)]);
			$i--;
		}
	}
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use DB;
6
7		class AJAX extends Controller
8		{
9		public function ranking()
10		{
11		$this->setRank();
12
13		$rankObj = DB::select('SELECT * FROM users WHERE total_points > 0 ORDER BY total_points DESC,rank;');
14		$rankArray = json_decode(json_encode($rankObj), true);
15		$userRank = count($rankArray);
16
17		return view('leader.ranking', ['rankArray' => $rankArray, 'userRank' => $userRank]);
18
19		return view('leader.ranking', ['rankArray' => $rankArray, 'userRank' => $userRank])->renderSections()['dynamicRanking'];
		0 ignored issues – show Unused Code introduced 2017-10-12 18:40 UTC by Report Bug Copy Issue Report `return view('leader.rank...ons()['dynamicRanking']` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
20		}
21
22	View Code Duplication	private function setRank()
		0 ignored issues – show Duplication introduced 2017-10-12 18:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		$totalPoints = CodeCount::getTotalPoints();
25		$rankObj = DB::select('SELECT * FROM users WHERE total_points = '.$totalPoints.' ORDER BY TIMEDIFF(start, end) DESC;');
26
27		for($i = 0; $i < count($rankObj); $i++){
		0 ignored issues – show Performance Best Practice introduced 2017-10-12 18:40 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
28		DB::table('users')->where('name_gen', $rankObj[$i]->name_gen)->update(['rank' => (++$i)]);
29		$i--;
30		}
31		}
32		}
33

Chronyms / Qitsune

GitHub Access Token became invalid

Push — master ( e0afd3...2df211 )

AJAX A

Complexity

Size/Duplication

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like