CodeCount::setRank() - Code Metrics - Chronyms/Qitsune - Measure and Improve Code Quality continuously with Scrutinizer

CodeCount::setRank() A
last analyzed 2018-06-15 18:47 UTC

↳ Parent: CodeCount

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	0
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php
    /**
     * Created by PhpStorm.
     * User: caspa
     * Date: 31.05.2018
     * Time: 11:39.
     */

namespace App\Http\Controllers;

use Illuminate\Support\Facades\DB;

    class CodeCount extends Controller
    {
        /**
         * Anzahl codes in DB hinterlegen.
         *
         * @param $codeCount
         *
         * @return int
         */
        public static function setCodeCount($codeCount)
        {
            DB::table('game_admin')->insert(['code_count' => $codeCount, 'total_points' => $codeCount]);

            return intval($codeCount);
        }

        /**
         * Anzahl codes aus DB holen und ausgeben.
         *
         * @return mixed
         */
        public function getCodeCount()
        {
            $codeCount = DB::table('game_admin')->select('code_count')->first()->code_count;

            return $codeCount;
        }

        /**
         * Anzahl codes aus DB holen und ausgeben.
         *
         * @return mixed
         */
        public static function getTotalPoints()
        {
            return $totalPoints = DB::table('game_admin')->select('total_points')->first();

        }

        public static function setRank()
        {
            $totalPoints = self::getTotalPoints();
            $rankObj = DB::select("SELECT * FROM users WHERE total_points = $totalPoints ORDER BY TIMEDIFF(start, end) DESC;");

            for ($i = 0; $i < count($rankObj); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                DB::table('users')->where('name_gen', $rankObj[$i]->name_gen)->update(['rank' => (++$i)]);
                $i--;
            }
        }
    }


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: caspa
5			* Date: 31.05.2018
6			* Time: 11:39.
7			*/
8
9			namespace App\Http\Controllers;
10
11			use Illuminate\Support\Facades\DB;
12
13			class CodeCount extends Controller
14			{
15			/**
16			* Anzahl codes in DB hinterlegen.
17			*
18			* @param $codeCount
19			*
20			* @return int
21			*/
22			public static function setCodeCount($codeCount)
23			{
24			DB::table('game_admin')->insert(['code_count' => $codeCount, 'total_points' => $codeCount]);
25
26			return intval($codeCount);
27			}
28
29			/**
30			* Anzahl codes aus DB holen und ausgeben.
31			*
32			* @return mixed
33			*/
34			public function getCodeCount()
35			{
36			$codeCount = DB::table('game_admin')->select('code_count')->first()->code_count;
37
38			return $codeCount;
39			}
40
41			/**
42			* Anzahl codes aus DB holen und ausgeben.
43			*
44			* @return mixed
45			*/
46			public static function getTotalPoints()
47			{
48			return $totalPoints = DB::table('game_admin')->select('total_points')->first();
			0 ignored issues – show Unused Code introduced 2018-06-01 22:49 UTC by Report Bug Copy Issue Report The assignment to `$totalPoints` is dead and can be removed. Loading history...
49			}
50
51			public static function setRank()
52			{
53			$totalPoints = self::getTotalPoints();
54			$rankObj = DB::select("SELECT * FROM users WHERE total_points = $totalPoints ORDER BY TIMEDIFF(start, end) DESC;");
55
56			for ($i = 0; $i < count($rankObj); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2017-10-12 18:40 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
57			DB::table('users')->where('name_gen', $rankObj[$i]->name_gen)->update(['rank' => (++$i)]);
58			$i--;
59			}
60			}
61			}
62

Chronyms / Qitsune

GitHub Access Token became invalid

CodeCount::setRank() A last analyzed 2018-06-15 18:47 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CodeCount::setRank() A
last analyzed 2018-06-15 18:47 UTC