App\Http\Controllers\ScanController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getAllPointsPerUser()	0	5	1
B	calcTotalPoints()	0	21	5
A	showScan()	0	23	3
A	checkCodeExists()	0	3	1

<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\DB;

class ScanController extends Controller
{
    /**
     * @param $param
     *
     * @return $this|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function showScan($param)
    {
        $rawQR = DB::select('SELECT * FROM game_codes WHERE  game_code = ?', [$param]);
        $checkExists = $this->checkCodeExists($param, Auth::user()->name_gen);

Accessing name_gen on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $maxPoints = CodeCount::getTotalPoints();

        if (count($rawQR) > 0) {
            if (count($checkExists) < 1) {
                DB::table('users_codes')->insert(['fk_users' => Auth::user()->id, 'fk_game_codes' => $rawQR[0]->id]);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                $checkExists = DB::select('SELECT * FROM users RIGHT JOIN users_codes ON users.id = users_codes.fk_users RIGHT JOIN game_codes ON users_codes.fk_game_codes = game_codes.id WHERE name_gen = ? AND game_code = ?;', [Auth::user()->name_gen, $param]);
                $checkExists = json_decode(json_encode($checkExists));
                $view = view('user.scan', ['checkExists' => $checkExists, 'maxPoints' => $maxPoints, 'first' => 1]);
            } else {
                $checkExists = DB::select('SELECT * FROM users RIGHT JOIN users_codes ON users.id = users_codes.fk_users RIGHT JOIN game_codes ON users_codes.fk_game_codes = game_codes.id WHERE name_gen = ? AND game_code = ?;', [Auth::user()->name_gen, $param]);
                $checkExists = json_decode(json_encode($checkExists));
                $view = view('user.scan', ['checkExists' => $checkExists, 'maxPoints' => $maxPoints])->withErrors('Der Code wurde bereits gezählt.');

'Der Code wurde bereits gezählt.' of type string is incompatible with the type Illuminate\Contracts\Support\MessageProvider|array expected by parameter $provider of Illuminate\View\View::withErrors().

            }

            $this->calcTotalPoints(Auth::user()->name_gen);

            return $view;
        } else {
            abort(404);
        }
    }

    /**
     * @param $code
     * @param $name_gen
     *
     * @return array
     */
    private function checkCodeExists($code, $name_gen)
    {
        return DB::select('SELECT * FROM users RIGHT JOIN users_codes ON users.id = users_codes.fk_users RIGHT JOIN game_codes ON users_codes.fk_game_codes = game_codes.id WHERE name_gen = ? AND game_code = ?;', [$name_gen, $code]);
    }

    /**
     * @param $name_gen
     */
    private function calcTotalPoints($name_gen)
    {
        $allPoints = $this->getAllPointsPerUser($name_gen);

        $totalPoints = 0;
        foreach ($allPoints as $point) {
            $totalPoints += $point['points'];
        }

        if ($totalPoints > 0) {
            DB::update('UPDATE users SET total_points = ? WHERE name_gen = ?;', [$totalPoints, $name_gen]);
        }

        if (count($allPoints) == 1) {
            DB::table('users')->where('id', Auth::User()->id)->limit(1)->update(['start' => Carbon::now()->toDateTimeString()]);

The type App\Http\Controllers\Carbon was not found. Maybe you did not declare it correctly or list all dependencies?

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        $codeCount = $this->getCodeCount();

The method getCodeCount() does not exist on App\Http\Controllers\ScanController. Since you implemented __call, consider adding a @method annotation.

        if (count($allPoints) == $codeCount) {
            DB::table('users')->where('id', Auth::User()->id)->update(['end' => Carbon::now()->toDateTimeString()]);
        }
    }

    /**
     * @param $name_gen
     *
     * @return mixed
     */
    private function getAllPointsPerUser($name_gen)
    {
        $pointsPerUser = DB::select('SELECT points,name_gen FROM users LEFT JOIN users_codes ON users.id = users_codes.fk_users LEFT JOIN game_codes ON users_codes.fk_game_codes = game_codes.id WHERE users.name_gen = ?;', [$name_gen]);

        return $pointsPerUserArray = json_decode(json_encode($pointsPerUser), true);

The assignment to $pointsPerUserArray is dead and can be removed.

    }
}