Chp\TextContent\BlogController

Complexity

Total Complexity

20

Size/Duplication

Total Lines	179
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

36.84%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	4	1
A	indexAction()	0	13	3
A	tagAction()	0	13	4
B	readAction()	0	32	3
A	getBlogContent()	0	6	2
B	preparePost()	0	33	4
A	postsToView()	0	17	3

<?php
namespace Chp\TextContent;

/**
 * A blog controller
 * Made by Rasmus Berg (c) 2014-2017
 *
 * @Property  Object  $this->di         Anax-MVC class handler
 * @Property  Object  $this->response   Anax-MVC Php Header class
 * @Property  Object  $this->url        Anax-MVC url-handler class
 * @Property  Object  $this->theme      Anax-MVC theme-handler class
 * @Property  Object  $this->views      Anax-MVC views-handler class
 * @Property  Object  $this->textFilter Anax-MVC textformat-handler class
 */
class BlogController implements \Anax\DI\IInjectionAware
{
  use \Anax\DI\TInjectable;
	
  /**
	 * Properties
	 */
  private $content = null;
  private $postsPerPage = null;
  private $urlPrefix = "content.php/";
  
  /**
   * Initialize the controller
   *
   * @Return    Void
   */
  public function initialize(){
    $this->content = new \Chp\TextContent\Content();
    $this->content->setDI($this->di);

It seems like $this->di can also be of type array or null; however, Anax\DI\IInjectionAware::setDI() does only seem to accept object<Anax\DI\class>, maybe add an additional type check?

  }
  
   /**
   * Index action - uses tagAction whitout tag
   *
   * @Return   Void
   */
  public function indexAction($page = null){
    $posts = $this->getBlogContent($page);
    
    if(count($posts) > 0){
      foreach($posts AS $key => $post){
        // Prepare blog post for show in view
        $posts[$key] = $this->preparePost($post);
      }
    }
    
    // Show blog posts in view
    $this->postsToView($posts, null);

$posts is of type object, but the function expects a array.

  }
  
  /**
   * Get blog posts by tag
   *
   * @Param   String    $tag    Blog-tag
   * @Param   Integer   $page   Page on paging
   * @Return  Void
   */
  public function tagAction($tag = null, $page = null){    
    $posts = $this->getBlogContent($page, $tag);
    
    if(count($posts) == 0 && !is_null($tag))
      $this->response->redirect($this->url->create($this->urlPrefix . 'blog/'));

The property response does not exist on object<Chp\TextContent\BlogController>. Since you implemented __get, maybe consider adding a @property annotation.

The property url does not exist on object<Chp\TextContent\BlogController>. Since you implemented __get, maybe consider adding a @property annotation.

    foreach($posts AS $key => $post){
      // Prepare blog post for show in view
      $posts[$key] = $this->preparePost($post, $tag);

The call to BlogController::preparePost() has too many arguments starting with $tag.

    }
    
    $this->postsToView($posts, $tag);

$posts is of type object, but the function expects a array.

  }
  
  /**
   * Get blog post by slug
   *
   * @Param   String    $slug    Blog-tag
   * @Return  Void
   */
  public function readAction($slug = null){
    
    if(is_null($slug)){
      $this->response->redirect($this->url->create($this->urlPrefix . 'blog/'));
    }
    
    $post = $this->content->getContentBySlug($slug, 'blog-post');
    
    if(empty($post)){
      $this->response->redirect($this->url->create($this->urlPrefix . 'blog/'));
    }
    
    // Prepare blog post for show in view
    $post = $this->preparePost($post);

$post is of type object, but the function expects a array|null.

    
    $title = "Blog -  {$post->title}";
    
    $this->theme->setTitle($title);
    $this->views->add('text-content/blog-post', 
      [
        'title'         => $title,
        'post' 	        => $post,
        'blogIndexUrl'  => $this->url->create($this->urlPrefix . 'blog/')
      ]
    );
    
    /*$this->dispatcher->forward([
      'controller' => 'comment',
      'action'     => 'view',
      'params'	   =>	["blog/read/{$post->slug}"]
    ]);*/
  }
  
  /**
   * Get blog posts by tag or type
   *
   * @Param   Int     $page    Page asked for
   * @Param   String  $tag     Tag-slug to search for
   * @Return  Array   $posts   A array with post objects
   */
  public function getBlogContent($page = null, $tag = null){
    if(!is_null($tag))
      return $this->content->getAllContentOfTag($tag, 'blog-post', $page, $this->postsPerPage);
    else
      return $this->content->getAllContentOfType('blog-post', $page, $this->postsPerPage);
  }
  
  /**
   * Prepare blog post to show in view 
   *
   * @Param   Array   $post   Blog post object
   * @Return  Object  $result Prepared blog post object
   */
  public function preparePost($post = null){    
    $result = null;
    
    if(!is_null($post)){
      $result = (object)[];
      
      foreach($post as $key => $value){
        $result->{$key} = $value;
      }
      
      $result->title        = htmlspecialchars($post->title, ENT_QUOTES);
      $result->ingress      = htmlspecialchars($post->ingress, ENT_QUOTES);
      $result->text         = $this->textFilter->doFilter(htmlspecialchars($post->text, ENT_QUOTES), $post->filters);

The property textFilter does not exist on object<Chp\TextContent\BlogController>. Since you implemented __get, maybe consider adding a @property annotation.

      $result->editUrl      = $this->url->create("content/edit/{$post->id}");

The property url does not exist on object<Chp\TextContent\BlogController>. Since you implemented __get, maybe consider adding a @property annotation.

      $result->showUrl      = $this->url->create("blog/read/" . $post->slug);

The property url does not exist on object<Chp\TextContent\BlogController>. Since you implemented __get, maybe consider adding a @property annotation.

      //$result->authorId     = $post->author;
      //$result->authorName   = htmlspecialchars($post->name, ENT_QUOTES);
      //$result->authorUrl    = $this->url->create('users/id/' . $post->author);
      
      //unset($result->author);
      
      $tags = $this->content->getTagsForContent($post->id);
      
      foreach($tags AS $item_key => $item){
        $tags[$item_key]->tag  = htmlspecialchars($item->tag, ENT_QUOTES);
        $tags[$item_key]->url  = $this->url->create($this->urlPrefix . "blog/tag/{$item->slug}");
      }
      
      $result->tags = $tags;
    }

    return $result;
  }
  
  /**
   * Show blog posts in view
   *
   * @Param   Array   $posts   Array of blog post objects
   * @Param   String  $tag     Tag-slug which has give this result
   * @Return  Void
   */
  private function postsToView($posts = array(), $tag = null){
    $tag_title = null;
    
    if(!is_null($tag))
      $tag_title = $this->content->getTagBySlug($tag);
    
    $title = "Blog" . ((!is_null($tag_title)) ? " - tag: {$tag_title}" : NULL);
  
    $this->theme->setTitle($title);
    $this->views->add('text-content/blog-index', 
      [
        'title'     => $title,
        'posts' 	  => $posts,
        'tag'       => $tag_title
      ]
    );
  }
}