RestoreHandlerTrait - Code Metrics - Inspection of "tests: aliases" - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c4b87...207d41 )

by Yaro

created 2020-01-05 13:22 UTC

RestoreHandlerTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	5
dl	46
loc	46
ccs	17
cts	17
cp	1
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	handleRestore()	29	29	6
	init()	1	1	?
	bound()	1	1	?
	crud()	1	1	?
	can()	1	1	?

How to fix Duplicated Code

<?php

namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;

use Illuminate\Http\Request;
use Spatie\Permission\Exceptions\UnauthorizedException;
use Yaro\Jarboe\Exceptions\PermissionDenied;
use Yaro\Jarboe\Table\CRUD;

trait RestoreHandlerTrait

{
    /**
     * Restore record by its id.
     *
     * @param $id
     * @param Request $request
     * @return \Illuminate\Http\JsonResponse
     * @throws PermissionDenied
     * @throws UnauthorizedException
     */
    public function handleRestore(Request $request, $id)
    {
        $this->init();
        $this->bound();

        if (!$this->crud()->isSoftDeleteEnabled()) {
            throw new PermissionDenied();
        }

        if (!$this->can('restore')) {
            throw UnauthorizedException::forPermissions(['restore']);
        }

        $model = $this->crud()->repo()->find($id);
        if (!$this->crud()->actions()->isAllowed('restore', $model)) {
            throw new PermissionDenied();
        }

        $this->idEntity = $model->getKey();
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if (!$this->crud()->repo()->restore($id) || $model->trashed()) {
            return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                'message' => __('jarboe::common.list.restore_failed_message', ['id' => $id]),
            ], 422);
        }
        return response()->json([
            'message' => __('jarboe::common.list.restore_success_message', ['id' => $id]),
        ]);
    }

    abstract protected function init();

    abstract protected function bound();

    abstract protected function crud(): CRUD;
    abstract protected function can($action): bool;
}


1			<?php
2
3			namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;
4
5			use Illuminate\Http\Request;
6			use Spatie\Permission\Exceptions\UnauthorizedException;
7			use Yaro\Jarboe\Exceptions\PermissionDenied;
8			use Yaro\Jarboe\Table\CRUD;
9
10		View Code Duplication	trait RestoreHandlerTrait
			0 ignored issues – show Duplication introduced 2019-10-24 14:58 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11			{
12			/**
13			* Restore record by its id.
14			*
15			* @param $id
16			* @param Request $request
17			* @return \Illuminate\Http\JsonResponse
18			* @throws PermissionDenied
19			* @throws UnauthorizedException
20			*/
21	6		public function handleRestore(Request $request, $id)
22			{
23	6		$this->init();
24	6		$this->bound();
25
26	6		if (!$this->crud()->isSoftDeleteEnabled()) {
27	1		throw new PermissionDenied();
28			}
29
30	5		if (!$this->can('restore')) {
31	2		throw UnauthorizedException::forPermissions(['restore']);
32			}
33
34	3		$model = $this->crud()->repo()->find($id);
35	3		if (!$this->crud()->actions()->isAllowed('restore', $model)) {
36	1		throw new PermissionDenied();
37			}
38
39	2		$this->idEntity = $model->getKey();
			0 ignored issues – show Bug introduced 2019-10-24 14:58 UTC by Report Bug Copy Issue Report The property `idEntity` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40
41	2		if (!$this->crud()->repo()->restore($id) \|\| $model->trashed()) {
42	1		return response()->json([
			0 ignored issues – show Bug introduced 2019-09-03 10:29 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
43	1		'message' => __('jarboe::common.list.restore_failed_message', ['id' => $id]),
44	1		], 422);
45			}
46	1		return response()->json([
47	1		'message' => __('jarboe::common.list.restore_success_message', ['id' => $id]),
48			]);
49			}
50
51			abstract protected function init();
			0 ignored issues – show Documentation introduced 2019-10-24 14:58 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
52			abstract protected function bound();
			0 ignored issues – show Documentation introduced 2019-10-24 14:58 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
53			abstract protected function crud(): CRUD;
54			abstract protected function can($action): bool;
55			}
56

Cherry-Pie / Jarboe

Push — master ( 5c4b87...207d41 )

RestoreHandlerTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like