Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Image |
||
9 | { |
||
10 | private $data; |
||
11 | |||
12 | 2 | public function __construct($data) |
|
16 | |||
17 | 2 | public function exist(): bool |
|
21 | |||
22 | 2 | public function hasCropped(): bool |
|
26 | |||
27 | 2 | public function croppedOrOriginalSourceUrl($default = null) |
|
40 | |||
41 | 2 | View Code Duplication | public function originalSourceUrl($default = null) |
51 | |||
52 | 2 | public function originalSource($default = null) |
|
56 | |||
57 | 2 | View Code Duplication | public function croppedSourceUrl($default = null) |
67 | |||
68 | 2 | public function croppedSource($default = null) |
|
72 | |||
73 | 2 | public function isEncoded(): bool |
|
83 | |||
84 | 2 | public function getDisk() |
|
88 | |||
89 | 2 | public function cropWidth() |
|
93 | |||
94 | 2 | public function cropHeight() |
|
98 | |||
99 | 2 | public function cropX() |
|
103 | |||
104 | 2 | public function cropY() |
|
108 | |||
109 | 2 | public function cropRotate() |
|
113 | |||
114 | 2 | public function cropRotateBackground() |
|
118 | } |
||
119 |