DeleteAction::render() - Code Metrics - Inspection of "Merge branch 'travici'" - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 194cbe...2ee496 )

by Yaro

created 2019-09-18 14:14 UTC

DeleteAction::render() A

↳ Parent: DeleteAction

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
ccs	0
cts	6
cp	0
cc	2
nc	2
nop	1
crap	6

<?php

namespace Yaro\Jarboe\Table\Actions;

class DeleteAction extends AbstractAction
{
    protected $ident = 'delete';

    public function render($model = null)
    {
        $crud = $this->crud();
        $isVisible = parent::shouldRender($model);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        if ($crud->isSoftDeleteEnabled()) {
            $isVisible = !$model->trashed();
        }

        return view('jarboe::crud.actions.delete', compact('crud', 'model', 'isVisible'));
    }

    public function isAllowed($model = null)
    {
        $isAllowed = parent::isAllowed($model);
        if ($this->crud()->isSoftDeleteEnabled()) {
            return $isAllowed && !$model->trashed();
        }

        return $isAllowed;
    }

    public function shouldRender($model = null)
    {
        if ($this->crud()->isSoftDeleteEnabled()) {
            return true;
        }

        return parent::shouldRender($model);
    }
}


1		<?php
2
3		namespace Yaro\Jarboe\Table\Actions;
4
5		class DeleteAction extends AbstractAction
6		{
7		protected $ident = 'delete';
8
9		public function render($model = null)
10		{
11		$crud = $this->crud();
12		$isVisible = parent::shouldRender($model);
		1 ignored issue – show Comprehensibility Bug introduced 2019-08-09 05:40 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`shouldRender()` instead of `render()`). Are you sure this is correct? If so, you might want to change this to `$this->shouldRender()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
13		if ($crud->isSoftDeleteEnabled()) {
14		$isVisible = !$model->trashed();
15		}
16
17		return view('jarboe::crud.actions.delete', compact('crud', 'model', 'isVisible'));
18		}
19
20	1	public function isAllowed($model = null)
21		{
22	1	$isAllowed = parent::isAllowed($model);
23	1	if ($this->crud()->isSoftDeleteEnabled()) {
24	1	return $isAllowed && !$model->trashed();
25		}
26
27		return $isAllowed;
28		}
29
30		public function shouldRender($model = null)
31		{
32		if ($this->crud()->isSoftDeleteEnabled()) {
33		return true;
34		}
35
36		return parent::shouldRender($model);
37		}
38		}
39

Cherry-Pie / Jarboe

Push — master ( 194cbe...2ee496 )

DeleteAction::render() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like