Yaro\Jarboe\Table\Actions\AbstractAction

Complexity

Total Complexity

13

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Test Coverage

Coverage

57.69%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	make()	0	4	1
A	setCrud()	0	4	1
A	crud()	0	4	1
A	identifier()	0	4	2
A	check()	0	6	1
A	isAllowed()	0	6	2
A	renderCheck()	0	6	1
A	shouldRender()	0	9	3

<?php

namespace Yaro\Jarboe\Table\Actions;

use Yaro\Jarboe\Table\CRUD;

abstract class AbstractAction implements ActionInterface
{
    protected $ident;
    protected $checkClosure;
    protected $renderClosure = false;
    private $crud;

    public function __construct()
    {
        $this->checkClosure = function() {
            return true;
        };
    }

    public static function make()
    {
        return new static();
    }

    public function setCrud(CRUD $crud)
    {
        $this->crud = $crud;
    }

    public function crud(): CRUD
    {
        return $this->crud;
    }

    public function identifier()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->ident ?: static::class;
    }

    public function check(\Closure $closure = null)
    {
        $this->checkClosure = $closure;

        return $this;
    }

    public function isAllowed($model = null)
    {
        $closure = $this->checkClosure;

        return is_callable($closure) ? call_user_func_array($closure, [$model]) : false;
    }

    public function renderCheck(\Closure $closure = null)
    {
        $this->renderClosure = $closure;

It seems like $closure can also be of type object<Closure>. However, the property $renderClosure is declared as type boolean. Maybe add an additional type check?

        return $this;
    }

    public function shouldRender($model = null)
    {
        $closure = $this->renderClosure;
        if ($closure === false) {
            return $this->isAllowed($model);
        }

        return is_callable($closure) ? call_user_func_array($closure, [$model]) : false;
    }
}