Yaro\Jarboe\Http\Controllers\Traits\Handlers\UpdateHandlerTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

81.82%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	handleUpdate()	0	19	3
	init()	0	1	?
	bound()	0	1	?
	crud()	0	1	?
	can()	0	1	?

<?php

namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;

use Illuminate\Http\Request;
use Spatie\Permission\Exceptions\UnauthorizedException;
use Yaro\Jarboe\Exceptions\PermissionDenied;
use Yaro\Jarboe\Table\CRUD;

trait UpdateHandlerTrait
{
    /**
     * Handle update action.
     *
     * @param Request $request
     * @param $id
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     * @throws PermissionDenied
     * @throws UnauthorizedException
     */
    public function handleUpdate(Request $request, $id)
    {
        $this->init();
        $this->bound();

        $model = $this->crud()->repo()->find($id);
        if (!$this->crud()->actions()->isAllowed('edit', $model)) {
            throw new PermissionDenied();
        }

        if (!$this->can('update')) {
            throw UnauthorizedException::forPermissions(['update']);
        }

        $this->crud()->repo()->update($id, $request);
        $this->idEntity = $model->getKey();

The property idEntity does not exist. Did you maybe forget to declare it?

        return redirect($this->crud()->listUrl());
    }

    abstract protected function init();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract protected function bound();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract protected function crud(): CRUD;
    abstract protected function can($action): bool;
}