Yaro\Jarboe\Http\Controllers\Traits\Handlers\ListHandlerTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	51
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

92.86%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	handleList()	16	16	2
A	getListViewsAbove()	4	4	1
A	getListViewsBelow()	4	4	1
	init()	1	1	?
	bound()	1	1	?
	crud()	1	1	?
	can()	1	1	?

<?php

namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;

use Illuminate\Http\Request;
use Spatie\Permission\Exceptions\UnauthorizedException;
use Yaro\Jarboe\Table\CRUD;

trait ListHandlerTrait

This class seems to be duplicated in your project.

{
    /**
     * Show table list page.
     *
     * @param Request $request
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     * @throws UnauthorizedException
     */
    public function handleList(Request $request)
    {
        $this->init();
        $this->bound();

        if (!$this->can('list')) {
            throw UnauthorizedException::forPermissions(['list']);
        }

        return view($this->viewCrudList, [

The property viewCrudList does not exist. Did you maybe forget to declare it?

            'crud' => $this->crud(),
            'items' => $this->crud()->repo()->get(),
            'viewsAbove' => $this->getListViewsAbove(),
            'viewsBelow' => $this->getListViewsBelow(),
        ]);
    }

    /**
     * Get array of view's objects, that should be rendered above content of `list` view.
     *
     * @return array
     */
    protected function getListViewsAbove(): array
    {
        return [];
    }

    /**
     * Get array of view's objects, that should be rendered below content of `list` view.
     *
     * @return array
     */
    protected function getListViewsBelow(): array
    {
        return [];
    }

    abstract protected function init();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract protected function bound();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract protected function crud(): CRUD;
    abstract protected function can($action): bool;
}