HistoryHandlerTrait::handleHistory() - Code Metrics - Inspection of "Apply fixes from StyleCI" - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#19)

by Yaro

created 2020-07-21 09:20 UTC

HistoryHandlerTrait::handleHistory() A

↳ Parent: HistoryHandlerTrait

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	9.584
c	0
b	0
f	0
cc	3
nc	3
nop	2

<?php

namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;

use Illuminate\Http\Request;
use Spatie\Permission\Exceptions\UnauthorizedException;
use Yaro\Jarboe\Exceptions\PermissionDenied;
use Yaro\Jarboe\Table\CRUD;

trait HistoryHandlerTrait
{
    protected $historyCrudHistory = 'jarboe::crud.history';

    /**
     * Show history page.
     *
     * @param Request $request
     * @param $id
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     * @throws PermissionDenied
     * @throws UnauthorizedException
     */
    public function handleHistory(Request $request, $id)
    {
        $this->beforeInit();
        $this->init();
        $this->bound();

        if (!$this->can('history')) {
            throw UnauthorizedException::forPermissions(['history']);
        }

        $model = $this->crud()->repo()->find($id);
        if (!$this->crud()->actions()->isAllowed('history', $model)) {
            throw new PermissionDenied();
        }

        return view($this->historyCrudHistory, [
            'crud' => $this->crud(),
            'item' => $model,
            'versions' => $model->versions()->latest()->paginate(8),
        ]);
    }

    abstract protected function beforeInit();

    abstract protected function init();

    abstract protected function bound();

    abstract protected function crud(): CRUD;
    abstract protected function can($action): bool;
}


1			<?php
2
3			namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;
4
5			use Illuminate\Http\Request;
6			use Spatie\Permission\Exceptions\UnauthorizedException;
7			use Yaro\Jarboe\Exceptions\PermissionDenied;
8			use Yaro\Jarboe\Table\CRUD;
9
10			trait HistoryHandlerTrait
11			{
12			protected $historyCrudHistory = 'jarboe::crud.history';
13
14			/**
15			* Show history page.
16			*
17			* @param Request $request
18			* @param $id
19			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
20			* @throws PermissionDenied
21			* @throws UnauthorizedException
22			*/
23			public function handleHistory(Request $request, $id)
24			{
25			$this->beforeInit();
26			$this->init();
27			$this->bound();
28
29			if (!$this->can('history')) {
30			throw UnauthorizedException::forPermissions(['history']);
31			}
32
33			$model = $this->crud()->repo()->find($id);
34			if (!$this->crud()->actions()->isAllowed('history', $model)) {
35			throw new PermissionDenied();
36			}
37
38			return view($this->historyCrudHistory, [
39			'crud' => $this->crud(),
40			'item' => $model,
41			'versions' => $model->versions()->latest()->paginate(8),
42			]);
43			}
44
45			abstract protected function beforeInit();
			0 ignored issues – show Documentation introduced 2020-07-21 09:30 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
46			abstract protected function init();
			0 ignored issues – show Documentation introduced 2020-07-21 09:30 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
47			abstract protected function bound();
			0 ignored issues – show Documentation introduced 2020-07-21 09:30 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
48			abstract protected function crud(): CRUD;
49			abstract protected function can($action): bool;
50			}
51

Cherry-Pie / Jarboe

Pull Request — master (#19)

HistoryHandlerTrait::handleHistory() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like