Password::getEditFormValue() - Code Metrics - Inspection of "Update pragmarx/google2fa requirement from ^6.1 to..." - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

unknown

created 2020-04-26 10:04 UTC

Password::getEditFormValue() A

↳ Parent: Password

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	5
cts	5
cp	1
rs	9.9666
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php

namespace Yaro\Jarboe\Table\Fields;

use Closure;
use Illuminate\Http\Request;
use Yaro\Jarboe\Table\Fields\Traits\Nullable;
use Yaro\Jarboe\Table\Fields\Traits\Orderable;
use Yaro\Jarboe\Table\Fields\Traits\Placeholder;
use Yaro\Jarboe\Table\Fields\Traits\Tooltip;

class Password extends AbstractField
{
    use Orderable;
    use Nullable;
    use Tooltip;
    use Placeholder;

    /** @var string|Closure */
    protected $hash = 'bcrypt';

    public function hash($hash)
    {
        if (is_object($hash) && is_a($hash, Closure::class)) {
            $this->hash = $hash;
            return $this;
        }

        if (is_string($hash) && function_exists($hash)) {
            $this->hash = $hash;
            return $this;
        }

        // dummy
        if (is_null($hash)) {
            $this->hash = function ($value) {
                return $value;
            };
            return $this;
        }

        throw new \RuntimeException('Hash for Password field must be valid function name or Closure');
    }

    public function value(Request $request)

    {
        $hash = $this->hash;

        return $hash(parent::value($request));
    }

    public function shouldSkip(Request $request)
    {
        return !$request->get($this->name());
    }

    public function getListView($model)
    {
        return view('jarboe::crud.fields.password.list', [
            'model' => $model,
            'field' => $this,
        ]);
    }

    public function getEditFormView($model)
    {
        $template = $this->isReadonly() ? 'readonly' : 'edit';

        return view('jarboe::crud.fields.password.'. $template, [
            'model' => $model,
            'field' => $this,
        ]);
    }

    public function getCreateFormView()
    {
        return view('jarboe::crud.fields.password.create', [
            'field' => $this,
        ]);
    }
}


1		<?php
2
3		namespace Yaro\Jarboe\Table\Fields;
4
5		use Closure;
6		use Illuminate\Http\Request;
7		use Yaro\Jarboe\Table\Fields\Traits\Nullable;
8		use Yaro\Jarboe\Table\Fields\Traits\Orderable;
9		use Yaro\Jarboe\Table\Fields\Traits\Placeholder;
10		use Yaro\Jarboe\Table\Fields\Traits\Tooltip;
11
12		class Password extends AbstractField
13		{
14		use Orderable;
15		use Nullable;
16		use Tooltip;
17		use Placeholder;
18
19		/** @var string\|Closure */
20		protected $hash = 'bcrypt';
21
22	4	public function hash($hash)
23		{
24	4	if (is_object($hash) && is_a($hash, Closure::class)) {
25	1	$this->hash = $hash;
26	1	return $this;
27		}
28
29	3	if (is_string($hash) && function_exists($hash)) {
30	1	$this->hash = $hash;
31	1	return $this;
32		}
33
34		// dummy
35	2	if (is_null($hash)) {
36		$this->hash = function ($value) {
37	1	return $value;
38		};
39	1	return $this;
40		}
41
42	1	throw new \RuntimeException('Hash for Password field must be valid function name or Closure');
43		}
44
45	4	public function value(Request $request)
		0 ignored issues – show Documentation introduced 2019-08-31 12:57 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
46		{
47	4	$hash = $this->hash;
48
49	4	return $hash(parent::value($request));
50		}
51
52	2	public function shouldSkip(Request $request)
53		{
54	2	return !$request->get($this->name());
55		}
56
57	1	public function getListView($model)
58		{
59	1	return view('jarboe::crud.fields.password.list', [
60	1	'model' => $model,
61	1	'field' => $this,
62		]);
63		}
64
65	1	public function getEditFormView($model)
66		{
67	1	$template = $this->isReadonly() ? 'readonly' : 'edit';
68
69	1	return view('jarboe::crud.fields.password.'. $template, [
70	1	'model' => $model,
71	1	'field' => $this,
72		]);
73		}
74
75	1	public function getCreateFormView()
76		{
77	1	return view('jarboe::crud.fields.password.create', [
78	1	'field' => $this,
79		]);
80		}
81		}
82

Cherry-Pie / Jarboe

Pull Request — master (#14)

Password::getEditFormValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like