RenderRepeaterItemHandlerTrait::handleRenderRepeaterItem() - Code Metrics - Inspection of "Update pragmarx/google2fa requirement from ^6.1 to..." - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

unknown

created 2020-04-26 10:04 UTC

handleRenderRepeaterItem() A

↳ Parent: RenderRepeaterItemHandlerTrait

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	0
cts	11
cp	0
rs	9.6333
c	0
b	0
f	0
cc	2
nc	1
nop	2
crap	6

<?php

namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;

use Illuminate\Support\MessageBag;
use Illuminate\Support\ViewErrorBag;
use Throwable;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Yaro\Jarboe\Table\CRUD;
use Yaro\Jarboe\Table\Fields\Repeater;

trait RenderRepeaterItemHandlerTrait
{
    /**
     * Handle system render repeater's item action.
     *
     * @param Request $request
     * @return JsonResponse
     * @throws Throwable
     */
    public function handleRenderRepeaterItem($request, $fieldName)
    {
        $this->init();
        $this->bound();

        $errorMessages = new MessageBag($request->get('errors', []));
        view()->share(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'errors', $errorMessages ?: new ViewErrorBag()
        );

        /** @var Repeater $repeater */
        $repeater = $this->crud()->getFieldByName($fieldName);

        return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'view' => $repeater->getRepeaterItemFormView(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                $request->get('data')
            )->render(),
        ]);
    }

    abstract protected function init();

    abstract protected function bound();

    abstract protected function crud(): CRUD;
}


Pull Request — master (#14)

handleRenderRepeaterItem() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;
4
5			use Illuminate\Support\MessageBag;
6			use Illuminate\Support\ViewErrorBag;
7			use Throwable;
8			use Illuminate\Http\JsonResponse;
9			use Illuminate\Http\Request;
10			use Yaro\Jarboe\Table\CRUD;
11			use Yaro\Jarboe\Table\Fields\Repeater;
12
13			trait RenderRepeaterItemHandlerTrait
14			{
15			/**
16			* Handle system render repeater's item action.
17			*
18			* @param Request $request
19			* @return JsonResponse
20			* @throws Throwable
21			*/
22			public function handleRenderRepeaterItem($request, $fieldName)
23			{
24			$this->init();
25			$this->bound();
26
27			$errorMessages = new MessageBag($request->get('errors', []));
28			view()->share(
			0 ignored issues – show Bug introduced 2020-04-26 10:12 UTC by Report Bug Copy Issue Report The method `share` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
29			'errors', $errorMessages ?: new ViewErrorBag()
30			);
31
32			/** @var Repeater $repeater */
33			$repeater = $this->crud()->getFieldByName($fieldName);
34
35			return response()->json([
			0 ignored issues – show Bug introduced 2020-04-26 10:12 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
36			'view' => $repeater->getRepeaterItemFormView(
			0 ignored issues – show Bug introduced 2020-04-26 10:12 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37			$request->get('data')
38			)->render(),
39			]);
40			}
41
42			abstract protected function init();
			0 ignored issues – show Documentation introduced 2020-04-26 10:12 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
43			abstract protected function bound();
			0 ignored issues – show Documentation introduced 2019-10-24 14:58 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
44			abstract protected function crud(): CRUD;
45			}
46

Cherry-Pie / Jarboe

Pull Request — master (#14)

handleRenderRepeaterItem() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like