CommonController::refreshSystemValues() - Code Metrics - Inspection of "changelog typo" - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 91b1a6...82674e )

by Yaro

created 2020-09-21 20:33 UTC

CommonController::refreshSystemValues() A

↳ Parent: CommonController

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	29
rs	9.456
c	0
b	0
f	0
cc	3
nc	4
nop	0

<?php

namespace Yaro\Jarboe\Http\Controllers;

use Illuminate\Routing\Controller;
use Yaro\Jarboe\Helpers\System;
use Yaro\Jarboe\Table\CRUD;

class CommonController extends Controller
{
    public function resetPanelSettings()
    {
        setcookie('body_class', null, -1, '/');

        /** @var CRUD $crud */
        $crud = app(CRUD::class);
        $crud->preferences()->resetAll();

        return redirect()->back();
    }

    public function refreshSystemValues()

    {
        $system = new System();

        $swapExplanation = 'NA';
        if (!is_null($system->swapTotal())) {
            $swapExplanation = $system->readableSize($system->swapUsed()) .' / '. $system->readableSize($system->swapTotal());
        }

        $memoryExplanation = 'NA';
        if (!is_null($system->memoryTotal())) {
            $memoryExplanation = $system->readableSize($system->memoryUsed()) .' / '. $system->readableSize($system->memoryTotal());
        }

        return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'swap' => [
                'explanation' => $swapExplanation,
                'percentage' => $system->swapPercentage(),
            ],
            'memory' => [
                'explanation' => $memoryExplanation,
                'percentage' => $system->memoryPercentage(),
            ],
            'load_average' => [
                'explanation' => implode(' ', $system->systemLoadSamples()),
                'percentages' => $system->systemLoadSamplesInPercentages(),
            ],
        ]);
    }

    public function notFoundPage()

    {
        return response()->view('jarboe::errors.404')->setStatusCode(404);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


Push — master ( 91b1a6...82674e )

CommonController::refreshSystemValues() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace Yaro\Jarboe\Http\Controllers;
4
5			use Illuminate\Routing\Controller;
6			use Yaro\Jarboe\Helpers\System;
7			use Yaro\Jarboe\Table\CRUD;
8
9			class CommonController extends Controller
10			{
11			public function resetPanelSettings()
12			{
13			setcookie('body_class', null, -1, '/');
14
15			/** @var CRUD $crud */
16			$crud = app(CRUD::class);
17			$crud->preferences()->resetAll();
18
19			return redirect()->back();
20			}
21
22			public function refreshSystemValues()
			0 ignored issues – show Documentation introduced 2020-05-26 17:28 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
23			{
24			$system = new System();
25
26			$swapExplanation = 'NA';
27			if (!is_null($system->swapTotal())) {
28			$swapExplanation = $system->readableSize($system->swapUsed()) .' / '. $system->readableSize($system->swapTotal());
29			}
30
31			$memoryExplanation = 'NA';
32			if (!is_null($system->memoryTotal())) {
33			$memoryExplanation = $system->readableSize($system->memoryUsed()) .' / '. $system->readableSize($system->memoryTotal());
34			}
35
36			return response()->json([
			0 ignored issues – show Bug introduced 2020-05-26 17:28 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37			'swap' => [
38			'explanation' => $swapExplanation,
39			'percentage' => $system->swapPercentage(),
40			],
41			'memory' => [
42			'explanation' => $memoryExplanation,
43			'percentage' => $system->memoryPercentage(),
44			],
45			'load_average' => [
46			'explanation' => implode(' ', $system->systemLoadSamples()),
47			'percentages' => $system->systemLoadSamplesInPercentages(),
48			],
49			]);
50			}
51
52			public function notFoundPage()
			0 ignored issues – show Documentation introduced 2020-09-21 20:52 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
53			{
54			return response()->view('jarboe::errors.404')->setStatusCode(404);
			0 ignored issues – show Bug introduced 2019-09-03 10:29 UTC by Report Bug Copy Issue Report The method `view` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
55			}
56			}
57

Cherry-Pie / Jarboe

Push — master ( 91b1a6...82674e )

CommonController::refreshSystemValues() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like