ShowHideColumnsTool::render() - Code Metrics - Inspection of "Revert "speed up coverage"" - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 798e92...ea2dad )

by Yaro

created 2020-02-06 14:12 UTC

ShowHideColumnsTool::render() A

↳ Parent: ShowHideColumnsTool

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
rs	10
c	0
b	0
f	0
ccs	0
cts	4
cp	0
cc	1
nc	1
nop	0
crap	2

<?php

namespace Yaro\Jarboe\Table\Toolbar;

use Illuminate\Http\Request;

class ShowHideColumnsTool extends AbstractTool
{
    /**
     * Position where should tool be placed.
     */
    public function position()
    {
        return self::POSITION_HEADER;
    }

    /**
     * Unique tool identifier.
     */
    public function identifier(): string
    {
        return 'show_hide_columns';
    }

    /**
     * Tool's view.
     */
    public function render()

    {
        return view('jarboe::crud.toolbar.show_hide_columns', [
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'tool' => $this,
        ])->render();
    }

    /**
     * Handle tool execution.
     * @param Request $request
     */
    public function handle(Request $request)
    {
        // dummy
    }

    /**
     * Check allowance to show and process tool.
     */
    public function check(): bool
    {
        return true;
    }
}


1		<?php
2
3		namespace Yaro\Jarboe\Table\Toolbar;
4
5		use Illuminate\Http\Request;
6
7		class ShowHideColumnsTool extends AbstractTool
8		{
9		/**
10		* Position where should tool be placed.
11		*/
12		public function position()
13		{
14		return self::POSITION_HEADER;
15		}
16
17		/**
18		* Unique tool identifier.
19		*/
20	2	public function identifier(): string
21		{
22	2	return 'show_hide_columns';
23		}
24
25		/**
26		* Tool's view.
27		*/
28		public function render()
		0 ignored issues – show Documentation introduced 2019-08-31 12:57 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
29		{
30		return view('jarboe::crud.toolbar.show_hide_columns', [
		0 ignored issues – show Bug introduced 2019-09-03 10:29 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
31		'tool' => $this,
32		])->render();
33		}
34
35		/**
36		* Handle tool execution.
37		* @param Request $request
38		*/
39		public function handle(Request $request)
40		{
41		// dummy
42		}
43
44		/**
45		* Check allowance to show and process tool.
46		*/
47		public function check(): bool
48		{
49		return true;
50		}
51		}
52

Cherry-Pie / Jarboe

Push — master ( 798e92...ea2dad )

ShowHideColumnsTool::render() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like