MassDeleteTool::handle() - Code Metrics - Inspection of "Revert "speed up coverage"" - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 798e92...ea2dad )

by Yaro

created 2020-02-06 14:12 UTC

MassDeleteTool::handle() A

↳ Parent: MassDeleteTool

Complexity

Conditions	5
Paths	10

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
dl	0
loc	28
rs	9.1608
c	0
b	0
f	0
ccs	0
cts	17
cp	0
cc	5
nc	10
nop	1
crap	30

<?php

namespace Yaro\Jarboe\Table\Toolbar;

use Illuminate\Http\Request;
use Yaro\Jarboe\Table\CRUD;

class MassDeleteTool extends AbstractTool
{
    /**
     * Set CRUD object.
     *
     * @param CRUD $crud
     */
    public function setCrud(CRUD $crud)
    {
        parent::setCrud($crud);

        if ($this->check()) {
            $this->crud()->enableBatchCheckboxes(true);
        }
    }

    /**
     * Position where should tool be placed.
     */
    public function position()
    {
        return self::POSITION_BODY_TOP;
    }

    /**
     * Unique tool identifier.
     */
    public function identifier(): string
    {
        return 'mass-delete';
    }

    /**
     * Tool's view.
     */
    public function render()
    {
        return view('jarboe::crud.toolbar.mass_delete', [
            'tool' => $this,
            'crud' => $this->crud(),
        ]);
    }

    /**
     * Handle tool execution.
     *
     * @param Request $request
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function handle(Request $request)
    {
        $errors = [];
        $hidden = [];
        $removed = [];
        foreach ($request->get('ids') as $id) {
            try {
                if (!$this->crud()->repo()->delete($id)) {
                    throw new \Exception(__('jarboe::toolbar.mass_delete.delete_event_failed'));
                }

                try {
                    $this->crud()->repo()->find($id);
                    $hidden[] = $id;
                } catch (\Exception $e) {
                    $removed[] = $id;
                }
            } catch (\Exception $e) {
                $errors[$id] = $e->getMessage();
            }
        }

        return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'errors' => $errors,
            'hidden' => $hidden,
            'removed' => $removed,
        ]);
    }

    /**
     * Check allowance to show and process tool.
     */
    public function check(): bool
    {
        return true;
    }
}


1		<?php
2
3		namespace Yaro\Jarboe\Table\Toolbar;
4
5		use Illuminate\Http\Request;
6		use Yaro\Jarboe\Table\CRUD;
7
8		class MassDeleteTool extends AbstractTool
9		{
10		/**
11		* Set CRUD object.
12		*
13		* @param CRUD $crud
14		*/
15	1	public function setCrud(CRUD $crud)
16		{
17	1	parent::setCrud($crud);
18
19	1	if ($this->check()) {
20	1	$this->crud()->enableBatchCheckboxes(true);
21		}
22	1	}
23
24		/**
25		* Position where should tool be placed.
26		*/
27		public function position()
28		{
29		return self::POSITION_BODY_TOP;
30		}
31
32		/**
33		* Unique tool identifier.
34		*/
35	1	public function identifier(): string
36		{
37	1	return 'mass-delete';
38		}
39
40		/**
41		* Tool's view.
42		*/
43		public function render()
44		{
45		return view('jarboe::crud.toolbar.mass_delete', [
46		'tool' => $this,
47		'crud' => $this->crud(),
48		]);
49		}
50
51		/**
52		* Handle tool execution.
53		*
54		* @param Request $request
55		*
56		* @return \Illuminate\Http\JsonResponse
57		*/
58		public function handle(Request $request)
59		{
60		$errors = [];
61		$hidden = [];
62		$removed = [];
63		foreach ($request->get('ids') as $id) {
64		try {
65		if (!$this->crud()->repo()->delete($id)) {
66		throw new \Exception(__('jarboe::toolbar.mass_delete.delete_event_failed'));
67		}
68
69		try {
70		$this->crud()->repo()->find($id);
71		$hidden[] = $id;
72		} catch (\Exception $e) {
73		$removed[] = $id;
74		}
75		} catch (\Exception $e) {
76		$errors[$id] = $e->getMessage();
77		}
78		}
79
80		return response()->json([
		0 ignored issues – show Bug introduced 2019-09-03 10:29 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
81		'errors' => $errors,
82		'hidden' => $hidden,
83		'removed' => $removed,
84		]);
85		}
86
87		/**
88		* Check allowance to show and process tool.
89		*/
90	1	public function check(): bool
91		{
92	1	return true;
93		}
94		}
95

Cherry-Pie / Jarboe

Push — master ( 798e92...ea2dad )

MassDeleteTool::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like