OldAndAttribute::oldOrAttribute() - Code Metrics - Inspection of "tests for field's old and attributes methods" - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b43387...8f2a89 )

by Yaro

created 2020-06-20 10:41 UTC

OldAndAttribute::oldOrAttribute() A

↳ Parent: OldAndAttribute

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	13
Ratio	100 %

Code Coverage

Tests	6
CRAP Score	3.0261

Importance

Changes

Metric	Value
dl	13
loc	13
ccs	6
cts	7
cp	0.8571
rs	9.8333
c	0
b	0
f	0
cc	3
nc	4
nop	2
crap	3.0261

<?php

namespace Yaro\Jarboe\Table\Fields\Traits;

trait OldAndAttribute
{
    public function old($name = null)
    {
        if (is_null($name)) {
            $name = $this->name();
        }

        return old($name);
    }

    public function hasOld($name = null)
    {
        return !is_null($this->old($name));
    }

    public function oldOrDefault($locale = null)
    {
        $name = $this->name();
        if ($locale) {
            $name .= '.'. $locale;
        }

        if ($this->hasOld($name)) {
            return $this->old($name);
        }

        return $this->getDefault();
    }

    public function oldOrAttribute($model, $locale = null)
    {
        $name = $this->name();
        if ($locale) {
            $name .= '.'. $locale;
        }

        if ($this->hasOld($name)) {
            return $this->old($name);
        }

        return $this->getAttribute($model, $locale);
    }

    public function getAttribute($model, $locale = null)

    {
        if ($locale && $this->isTranslatable()) {
            return $model->getTranslation($this->name(), $locale, false);
        }

        return $model->{$this->name()};
    }

    abstract public function getDefault();

    abstract public function name(string $name = null);

    abstract public function isTranslatable();

}


1			<?php
2
3			namespace Yaro\Jarboe\Table\Fields\Traits;
4
5			trait OldAndAttribute
6			{
7	86		public function old($name = null)
8			{
9	86		if (is_null($name)) {
10	17		$name = $this->name();
11			}
12
13	86		return old($name);
14			}
15
16	69		public function hasOld($name = null)
17			{
18	69		return !is_null($this->old($name));
19			}
20
21	17	View Code Duplication	public function oldOrDefault($locale = null)
22			{
23	17		$name = $this->name();
24	17		if ($locale) {
25			$name .= '.'. $locale;
26			}
27
28	17		if ($this->hasOld($name)) {
29	17		return $this->old($name);
30			}
31
32	17		return $this->getDefault();
33			}
34
35	18	View Code Duplication	public function oldOrAttribute($model, $locale = null)
36			{
37	18		$name = $this->name();
38	18		if ($locale) {
39			$name .= '.'. $locale;
40			}
41
42	18		if ($this->hasOld($name)) {
43	17		return $this->old($name);
44			}
45
46	1		return $this->getAttribute($model, $locale);
47			}
48
49	35		public function getAttribute($model, $locale = null)
			0 ignored issues – show Documentation introduced 2019-08-31 12:57 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
50			{
51	35		if ($locale && $this->isTranslatable()) {
52			return $model->getTranslation($this->name(), $locale, false);
53			}
54
55	35		return $model->{$this->name()};
56			}
57
58			abstract public function getDefault();
			0 ignored issues – show Documentation introduced 2019-10-25 12:48 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
59			abstract public function name(string $name = null);
			0 ignored issues – show Documentation introduced 2019-10-25 12:48 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
60			abstract public function isTranslatable();
			0 ignored issues – show Documentation introduced 2019-10-25 12:48 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
61			}
62

Cherry-Pie / Jarboe

Push — master ( b43387...8f2a89 )

OldAndAttribute::oldOrAttribute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like