AbstractTableController - Code Metrics - Inspection of "Merge pull request #19 from Cherry-Pie/analysis-1b..." - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (49dc1a)

by Yaro

created 2020-07-21 16:21 UTC

AbstractTableController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	258
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	37

Test Coverage

Coverage

86.87%

Importance

Changes

Metric	Value
wmc	39
lcom	2
cbo	37
dl	0
loc	258
ccs	86
cts	99
cp	0.8687
rs	9.28
c	0
b	0
f	0

9 Methods

Rating	Name	Size	Complexity
A	can()	17	5
A	onException()	4	1
A	__construct()	14	1
A	crud()	4	1
F	__call()	72	22
A	beforeInit()	4	1
A	bound()	18	4
A	createUnauthorizedResponse()	10	2
A	model()	8	2

<?php

namespace Yaro\Jarboe\Http\Controllers;

use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Request as RequestFacade;
use Illuminate\Validation\ValidationException;
use Spatie\Permission\Exceptions\UnauthorizedException;
use Yaro\Jarboe\Http\Controllers\Traits\AliasesTrait;
use Yaro\Jarboe\Http\Controllers\Traits\BreadcrumbsTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\CreateHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\DeleteHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\EditHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\ForceDeleteHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\HistoryHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\RevertHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\InlineHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\ListHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\OrderByHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\PerPageHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\RenderRepeaterItemHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\RestoreHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\SearchHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\SearchRelationHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\SortableHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\StoreHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\ToolbarHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\Handlers\UpdateHandlerTrait;
use Yaro\Jarboe\Http\Controllers\Traits\NotifyTrait;
use Yaro\Jarboe\Table\Actions\CreateAction;
use Yaro\Jarboe\Table\Actions\DeleteAction;
use Yaro\Jarboe\Table\Actions\EditAction;
use Yaro\Jarboe\Table\Actions\ForceDeleteAction;
use Yaro\Jarboe\Table\Actions\RestoreAction;
use Yaro\Jarboe\Table\CRUD;
use Yaro\Jarboe\Table\Fields\AbstractField;
use Yaro\Jarboe\Table\Toolbar\TranslationLocalesSelectorTool;
use Yaro\Jarboe\ViewComponents\Breadcrumbs\BreadcrumbsInterface;

/**
 * @method mixed list(Request $request)
 * @method mixed search(Request $request)
 * @method mixed create(Request $request)
 * @method mixed store(Request $request)
 * @method mixed edit(Request $request, $id)
 * @method mixed update(Request $request, $id)
 * @method mixed delete(Request $request, $id)
 * @method mixed restore(Request $request, $id)
 * @method mixed forceDelete(Request $request, $id)
 * @method mixed inline(Request $request)
 * @method mixed history(Request $request, $id)
 * @method mixed revert(Request $request, $id)
 */
abstract class AbstractTableController
{
    use ValidatesRequests;
    use NotifyTrait;
    use AliasesTrait;
    use DeleteHandlerTrait;
    use ToolbarHandlerTrait;
    use InlineHandlerTrait;
    use ForceDeleteHandlerTrait;
    use RestoreHandlerTrait;
    use UpdateHandlerTrait;
    use StoreHandlerTrait;
    use ListHandlerTrait;
    use EditHandlerTrait;
    use CreateHandlerTrait;
    use OrderByHandlerTrait;
    use PerPageHandlerTrait;
    use SortableHandlerTrait;
    use SearchRelationHandlerTrait;
    use SearchHandlerTrait;
    use BreadcrumbsTrait;
    use RenderRepeaterItemHandlerTrait;
    use HistoryHandlerTrait;
    use RevertHandlerTrait;

    /**
     * Permission group name.
     *
     * @var string|array
     * array(
     *     'list'        => 'permission:list',
     *     'search'      => 'permission:search',
     *     'create'      => 'permission:create',
     *     'store'       => 'permission:store',
     *     'edit'        => 'permission:edit',
     *     'update'      => 'permission:update',
     *     'inline'      => 'permission:inline',
     *     'delete'      => 'permission:delete',
     *     'restore'     => 'permission:restore',
     *     'forceDelete' => 'permission:force-delete',
     *     'history'     => 'permission:history',
     *     'revert'      => 'permission:revert',
     * )
     */
    protected $permissions = '';

    /**
     * @var CRUD
     */
    protected $crud;

    /**
     * ID of manipulated model.
     *
     * @var mixed
     */
    protected $idEntity;

    public function __construct()
    {
        $this->crud = app(CRUD::class);
        $this->crud()->tableIdentifier(crc32(static::class));
        $this->crud()->formClass(config('jarboe.crud.form_class'));
        $this->crud()->actions()->set([
            CreateAction::make(),
            EditAction::make(),
            RestoreAction::make(),
            DeleteAction::make(),
            ForceDeleteAction::make(),
        ]);
        $this->breadcrumbs = app(BreadcrumbsInterface::class);
    }

    protected function crud(): CRUD
    {
        return $this->crud;
    }

    /**
     * Check if user has permission for the action.
     *
     * @param $action
     * @return bool
     */
    protected function can($action): bool
    {
        if (!$this->permissions) {
            return true;
        }
        if (is_array($this->permissions) && !array_key_exists($action, $this->permissions)) {
            return true;
        }

        if (is_array($this->permissions)) {
            $permission = $this->permissions[$action];
        } else {
            $permission = sprintf('%s:%s', $this->permissions, $action);
        }

        return $this->admin()->can($permission);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function __call($name, $arguments)

    {
        /** @var Request $request */
        $request = RequestFacade::instance();

        $id = null;
        if (isset($arguments[0])) {
            $id = $arguments[1] ?? $arguments[0];
        }

        try {
            switch ($name) {
                case 'list':
                    return $this->handleList($request);
                case 'search':
                    return $this->handleSearch($request);
                case 'create':
                    return $this->handleCreate($request);
                case 'store':
                    return $this->handleStore($request);
                case 'edit':
                    return $this->handleEdit($request, $id);
                case 'update':
                    return $this->handleUpdate($request, $id);
                case 'delete':
                    return $this->handleDelete($request, $id);
                case 'restore':
                    return $this->handleRestore($request, $id);
                case 'forceDelete':
                    return $this->handleForceDelete($request, $id);
                case 'inline':
                    return $this->handleInline($request);
                case 'renderRepeaterItem':
                    $fieldName = $id;
                    return $this->handleRenderRepeaterItem($request, $fieldName);
                case 'history':
                    return $this->handleHistory($request, $id);
                case 'revert':
                    return $this->handleRevert($request, $id);

                default:
                    throw new \RuntimeException('Invalid method ' . $name);
            }
        } catch (ValidationException $e) {
            throw $e;
        } catch (UnauthorizedException $e) {
            return $this->createUnauthorizedResponse($request, $e);
        } catch (\Throwable $e) {
            $response = $this->onException($e);
            if (!is_null($response)) {
                return $response;
            }

            // TODO: response objects
            if ($request->isXmlHttpRequest() || $request->wantsJson()) {
                return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                    'title' => get_class($e),
                    'description' => $e->getMessage(),
                ], 406);
            }

            $this->notifyBigDanger(get_class($e), $e->getMessage(), 0);

            /** @var RedirectResponse $redirect */
            $redirect = redirect()->back();
            if ($redirect->getTargetUrl() == $request->url()) {
                $redirect->setTargetUrl(admin_url());
            }

            return $redirect->withInput($request->input());
        }
    }

    /**
     * Event for processing exceptions before forming error response.
     * Non-null return value will be processed as response.
     *
     * @param \Throwable $exception
     *
     * @return mixed|void
     */
    protected function onException(\Throwable $exception)
    {
        // dummy
    }

    /**
     * Method for overriding to define basic/common init() settings.
     *
     * @return void
     */
    protected function beforeInit()
    {
        // dummy
    }

    /**
     * Bound fields/tools/etc with global data.
     */
    protected function bound()
    {
        /** @var AbstractField $field */
        foreach ($this->crud()->getAllFieldObjects() as $field) {
            $field->prepare($this->crud);
        }

        /** @var AbstractField $field */
        foreach ($this->crud()->getFieldsWithoutMarkup() as $field) {
            if ($field->isTranslatable()) {
                $this->addTool(new TranslationLocalesSelectorTool());
                break;
            }
        }

        $this->crud()->actions()->setCrud($this->crud());
        $this->initBreadcrumbs();
    }

    /**
     * Create response for unauthorized request.
     *
     * @param Request $request
     * @param UnauthorizedException $exception
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    protected function createUnauthorizedResponse(Request $request, UnauthorizedException $exception)
    {
        if ($request->wantsJson()) {
            return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                'message' => $exception->getMessage()
            ], 401);
        }

        return view('jarboe::errors.401');
    }

    /**
     * Get model for current request.
     *
     * @return string
     * @throws \RuntimeException
     */
    protected function model()
    {
        if (!$this->idEntity) {
            throw new \RuntimeException('Trying to access to non-existed entity');
        }

        return $this->crud()->repo()->find($this->idEntity);
    }

    /**
     * @return void
     */
    abstract protected function init();
}


Branch — master (49dc1a)

AbstractTableController A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Yaro\Jarboe\Http\Controllers;
4
5		use Illuminate\Foundation\Validation\ValidatesRequests;
6		use Illuminate\Http\RedirectResponse;
7		use Illuminate\Http\Request;
8		use Illuminate\Support\Facades\Request as RequestFacade;
9		use Illuminate\Validation\ValidationException;
10		use Spatie\Permission\Exceptions\UnauthorizedException;
11		use Yaro\Jarboe\Http\Controllers\Traits\AliasesTrait;
12		use Yaro\Jarboe\Http\Controllers\Traits\BreadcrumbsTrait;
13		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\CreateHandlerTrait;
14		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\DeleteHandlerTrait;
15		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\EditHandlerTrait;
16		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\ForceDeleteHandlerTrait;
17		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\HistoryHandlerTrait;
18		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\RevertHandlerTrait;
19		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\InlineHandlerTrait;
20		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\ListHandlerTrait;
21		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\OrderByHandlerTrait;
22		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\PerPageHandlerTrait;
23		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\RenderRepeaterItemHandlerTrait;
24		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\RestoreHandlerTrait;
25		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\SearchHandlerTrait;
26		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\SearchRelationHandlerTrait;
27		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\SortableHandlerTrait;
28		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\StoreHandlerTrait;
29		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\ToolbarHandlerTrait;
30		use Yaro\Jarboe\Http\Controllers\Traits\Handlers\UpdateHandlerTrait;
31		use Yaro\Jarboe\Http\Controllers\Traits\NotifyTrait;
32		use Yaro\Jarboe\Table\Actions\CreateAction;
33		use Yaro\Jarboe\Table\Actions\DeleteAction;
34		use Yaro\Jarboe\Table\Actions\EditAction;
35		use Yaro\Jarboe\Table\Actions\ForceDeleteAction;
36		use Yaro\Jarboe\Table\Actions\RestoreAction;
37		use Yaro\Jarboe\Table\CRUD;
38		use Yaro\Jarboe\Table\Fields\AbstractField;
39		use Yaro\Jarboe\Table\Toolbar\TranslationLocalesSelectorTool;
40		use Yaro\Jarboe\ViewComponents\Breadcrumbs\BreadcrumbsInterface;
41
42		/**
43		* @method mixed list(Request $request)
44		* @method mixed search(Request $request)
45		* @method mixed create(Request $request)
46		* @method mixed store(Request $request)
47		* @method mixed edit(Request $request, $id)
48		* @method mixed update(Request $request, $id)
49		* @method mixed delete(Request $request, $id)
50		* @method mixed restore(Request $request, $id)
51		* @method mixed forceDelete(Request $request, $id)
52		* @method mixed inline(Request $request)
53		* @method mixed history(Request $request, $id)
54		* @method mixed revert(Request $request, $id)
55		*/
56		abstract class AbstractTableController
57		{
58		use ValidatesRequests;
59		use NotifyTrait;
60		use AliasesTrait;
61		use DeleteHandlerTrait;
62		use ToolbarHandlerTrait;
63		use InlineHandlerTrait;
64		use ForceDeleteHandlerTrait;
65		use RestoreHandlerTrait;
66		use UpdateHandlerTrait;
67		use StoreHandlerTrait;
68		use ListHandlerTrait;
69		use EditHandlerTrait;
70		use CreateHandlerTrait;
71		use OrderByHandlerTrait;
72		use PerPageHandlerTrait;
73		use SortableHandlerTrait;
74		use SearchRelationHandlerTrait;
75		use SearchHandlerTrait;
76		use BreadcrumbsTrait;
77		use RenderRepeaterItemHandlerTrait;
78		use HistoryHandlerTrait;
79		use RevertHandlerTrait;
80
81		/**
82		* Permission group name.
83		*
84		* @var string\|array
85		* array(
86		* 'list' => 'permission:list',
87		* 'search' => 'permission:search',
88		* 'create' => 'permission:create',
89		* 'store' => 'permission:store',
90		* 'edit' => 'permission:edit',
91		* 'update' => 'permission:update',
92		* 'inline' => 'permission:inline',
93		* 'delete' => 'permission:delete',
94		* 'restore' => 'permission:restore',
95		* 'forceDelete' => 'permission:force-delete',
96		* 'history' => 'permission:history',
97		* 'revert' => 'permission:revert',
98		* )
99		*/
100		protected $permissions = '';
101
102		/**
103		* @var CRUD
104		*/
105		protected $crud;
106
107		/**
108		* ID of manipulated model.
109		*
110		* @var mixed
111		*/
112		protected $idEntity;
113
114	79	public function __construct()
115		{
116	79	$this->crud = app(CRUD::class);
117	79	$this->crud()->tableIdentifier(crc32(static::class));
118	79	$this->crud()->formClass(config('jarboe.crud.form_class'));
119	79	$this->crud()->actions()->set([
120	79	CreateAction::make(),
121	79	EditAction::make(),
122	79	RestoreAction::make(),
123	79	DeleteAction::make(),
124	79	ForceDeleteAction::make(),
125		]);
126	79	$this->breadcrumbs = app(BreadcrumbsInterface::class);
127	79	}
128
129	79	protected function crud(): CRUD
130		{
131	79	return $this->crud;
132		}
133
134		/**
135		* Check if user has permission for the action.
136		*
137		* @param $action
138		* @return bool
139		*/
140	44	protected function can($action): bool
141		{
142	44	if (!$this->permissions) {
143	21	return true;
144		}
145	24	if (is_array($this->permissions) && !array_key_exists($action, $this->permissions)) {
146	1	return true;
147		}
148
149	24	if (is_array($this->permissions)) {
150	1	$permission = $this->permissions[$action];
151		} else {
152	24	$permission = sprintf('%s:%s', $this->permissions, $action);
153		}
154
155	24	return $this->admin()->can($permission);
		0 ignored issues – show Bug introduced 2019-10-24 14:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Authenticatable` as the method `can()` does only exist in the following implementations of said interface: `Illuminate\Foundation\Auth\User`, `Yaro\Jarboe\Models\Admin`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
156		}
157
158	27	public function __call($name, $arguments)
		0 ignored issues – show Documentation introduced 2019-08-31 12:57 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
159		{
160		/** @var Request $request */
161	27	$request = RequestFacade::instance();
162
163	27	$id = null;
164	27	if (isset($arguments[0])) {
165	26	$id = $arguments[1] ?? $arguments[0];
166		}
167
168		try {
169	27	switch ($name) {
170	27	case 'list':
171	4	return $this->handleList($request);
172	23	case 'search':
173	2	return $this->handleSearch($request);
174	21	case 'create':
175	2	return $this->handleCreate($request);
176	19	case 'store':
177	2	return $this->handleStore($request);
178	17	case 'edit':
179	2	return $this->handleEdit($request, $id);
180	15	case 'update':
181	2	return $this->handleUpdate($request, $id);
182	13	case 'delete':
183	2	return $this->handleDelete($request, $id);
184	11	case 'restore':
185	3	return $this->handleRestore($request, $id);
186	8	case 'forceDelete':
187	2	return $this->handleForceDelete($request, $id);
188	6	case 'inline':
189	2	return $this->handleInline($request);
190	4	case 'renderRepeaterItem':
191		$fieldName = $id;
192		return $this->handleRenderRepeaterItem($request, $fieldName);
193	4	case 'history':
194	2	return $this->handleHistory($request, $id);
195	2	case 'revert':
196	1	return $this->handleRevert($request, $id);
197
198		default:
199	1	throw new \RuntimeException('Invalid method ' . $name);
200		}
201	13	} catch (ValidationException $e) {
202	1	throw $e;
203	12	} catch (UnauthorizedException $e) {
204	11	return $this->createUnauthorizedResponse($request, $e);
205	1	} catch (\Throwable $e) {
206	1	$response = $this->onException($e);
207	1	if (!is_null($response)) {
208		return $response;
209		}
210
211		// TODO: response objects
212	1	if ($request->isXmlHttpRequest() \|\| $request->wantsJson()) {
213		return response()->json([
		0 ignored issues – show Bug introduced 2020-01-10 20:13 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
214		'title' => get_class($e),
215		'description' => $e->getMessage(),
216		], 406);
217		}
218
219	1	$this->notifyBigDanger(get_class($e), $e->getMessage(), 0);
220
221		/** @var RedirectResponse $redirect */
222	1	$redirect = redirect()->back();
223	1	if ($redirect->getTargetUrl() == $request->url()) {
224	1	$redirect->setTargetUrl(admin_url());
225		}
226
227	1	return $redirect->withInput($request->input());
228		}
229		}
230
231		/**
232		* Event for processing exceptions before forming error response.
233		* Non-null return value will be processed as response.
234		*
235		* @param \Throwable $exception
236		*
237		* @return mixed\|void
238		*/
239	1	protected function onException(\Throwable $exception)
240		{
241		// dummy
242	1	}
243
244		/**
245		* Method for overriding to define basic/common init() settings.
246		*
247		* @return void
248		*/
249	51	protected function beforeInit()
250		{
251		// dummy
252	51	}
253
254		/**
255		* Bound fields/tools/etc with global data.
256		*/
257	59	protected function bound()
258		{
259		/** @var AbstractField $field */
260	59	foreach ($this->crud()->getAllFieldObjects() as $field) {
261	58	$field->prepare($this->crud);
262		}
263
264		/** @var AbstractField $field */
265	59	foreach ($this->crud()->getFieldsWithoutMarkup() as $field) {
266	58	if ($field->isTranslatable()) {
267		$this->addTool(new TranslationLocalesSelectorTool());
268		break;
269		}
270		}
271
272	59	$this->crud()->actions()->setCrud($this->crud());
273	59	$this->initBreadcrumbs();
274	59	}
275
276		/**
277		* Create response for unauthorized request.
278		*
279		* @param Request $request
280		* @param UnauthorizedException $exception
281		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\Http\JsonResponse\|\Illuminate\View\View
282		*/
283	12	protected function createUnauthorizedResponse(Request $request, UnauthorizedException $exception)
284		{
285	12	if ($request->wantsJson()) {
286	1	return response()->json([
		0 ignored issues – show Bug introduced 2019-09-03 10:29 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
287	1	'message' => $exception->getMessage()
288	1	], 401);
289		}
290
291	12	return view('jarboe::errors.401');
292		}
293
294		/**
295		* Get model for current request.
296		*
297		* @return string
298		* @throws \RuntimeException
299		*/
300		protected function model()
301		{
302		if (!$this->idEntity) {
303		throw new \RuntimeException('Trying to access to non-existed entity');
304		}
305
306		return $this->crud()->repo()->find($this->idEntity);
307		}
308
309		/**
310		* @return void
311		*/
312		abstract protected function init();
313		}
314

Cherry-Pie / Jarboe

Branch — master (49dc1a)

AbstractTableController A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like