Complex classes like CRUD often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CRUD, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class CRUD |
||
| 14 | { |
||
| 15 | const BASE_URL_DELIMITER = '/~/'; |
||
| 16 | |||
| 17 | private $fields = []; |
||
| 18 | private $actions; |
||
| 19 | private $model = ''; |
||
| 20 | private $repo; |
||
| 21 | private $preferences; |
||
| 22 | private $tableIdentifier; |
||
| 23 | private $rawPerPage; |
||
| 24 | private $columns = []; |
||
| 25 | private $formClass = 'col-sm-12 col-md-12 col-lg-12'; |
||
| 26 | private $toolbar = []; |
||
| 27 | private $locales = []; |
||
| 28 | private $batchCheckboxesEnabled = false; |
||
| 29 | private $sortableWeightField = null; |
||
| 30 | private $softDeleteEnabled = false; |
||
| 31 | |||
| 32 | 18 | public function __construct(ModelRepository $repo, PreferencesRepository $preferences, ActionsContainer $actions) |
|
| 38 | |||
| 39 | 17 | public function formClass(string $class = null) |
|
| 47 | |||
| 48 | public function getRawPerPage() |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @param string|AbstractField $column |
||
| 55 | */ |
||
| 56 | public function addColumn($column) |
||
| 60 | |||
| 61 | 13 | public function getColumns() |
|
| 65 | |||
| 66 | /** |
||
| 67 | * Get columns as field objects, or fields if there are no columns. |
||
| 68 | * |
||
| 69 | * @return array |
||
| 70 | */ |
||
| 71 | public function getColumnsAsFields() |
||
| 86 | |||
| 87 | /** |
||
| 88 | * Get list of columns that initialized as field object. |
||
| 89 | * |
||
| 90 | * @return array |
||
| 91 | */ |
||
| 92 | 13 | public function getColumnsWithoutRelatedField() |
|
| 103 | |||
| 104 | 13 | public function getAllFieldObjects() |
|
| 113 | |||
| 114 | /** |
||
| 115 | * @param $name |
||
| 116 | * @return null|AbstractField |
||
| 117 | */ |
||
| 118 | 1 | public function getFieldByName($name) |
|
| 129 | |||
| 130 | 13 | public function addField(AbstractField $field) |
|
| 134 | |||
| 135 | 13 | public function getFields() |
|
| 139 | |||
| 140 | 13 | public function getFieldsWithoutMarkup(): array |
|
| 149 | |||
| 150 | 13 | private function extractField(AbstractField $field, &$fields) |
|
| 161 | |||
| 162 | public function getTabs($skipHiddenType = null) |
||
| 176 | |||
| 177 | private function moveDefaultTabToEnd(&$tabs) |
||
| 188 | |||
| 189 | 13 | public function setModel($model) |
|
| 195 | |||
| 196 | 13 | public function repo() |
|
| 202 | |||
| 203 | 4 | public function preferences() |
|
| 207 | |||
| 208 | /** |
||
| 209 | * @param int|array $perPage |
||
| 210 | */ |
||
| 211 | public function paginate($perPage) |
||
| 227 | |||
| 228 | public function order(string $column, string $direction) |
||
| 234 | |||
| 235 | 13 | public function filter(\Closure $callback) |
|
| 241 | |||
| 242 | 13 | public function getModel() |
|
| 246 | |||
| 247 | public function hasAnyFieldFilter() |
||
| 257 | |||
| 258 | public function editUrl($id) |
||
| 262 | |||
| 263 | public function createUrl() |
||
| 267 | |||
| 268 | public function deleteUrl($id) |
||
| 272 | |||
| 273 | public function restoreUrl($id) |
||
| 277 | |||
| 278 | public function forceDeleteUrl($id) |
||
| 282 | |||
| 283 | public function toolbarUrl($identifier) |
||
| 287 | |||
| 288 | 5 | public function listUrl() |
|
| 292 | |||
| 293 | public function perPageUrl($perPage) |
||
| 297 | |||
| 298 | public function searchUrl() |
||
| 302 | |||
| 303 | public function relationSearchUrl() |
||
| 307 | |||
| 308 | 13 | public function inlineUrl() |
|
| 312 | |||
| 313 | public function orderUrl($column, $direction) |
||
| 317 | |||
| 318 | public function reorderUrl() |
||
| 322 | |||
| 323 | public function reorderMoveItemUrl($id) |
||
| 327 | |||
| 328 | 14 | public function baseUrl() |
|
| 334 | |||
| 335 | /** |
||
| 336 | * @param null $ident |
||
| 337 | * @return mixed|void |
||
| 338 | */ |
||
| 339 | 17 | public function tableIdentifier($ident = null) |
|
| 347 | |||
| 348 | 1 | public function saveSearchFilterParams(array $params) |
|
| 352 | |||
| 353 | 1 | public function getOrderFilterParam($column) |
|
| 357 | |||
| 358 | 1 | public function saveOrderFilterParam($column, $direction) |
|
| 362 | |||
| 363 | 1 | public function getPerPageParam() |
|
| 367 | |||
| 368 | 1 | public function setPerPageParam($perPage) |
|
| 372 | |||
| 373 | public function getCurrentLocale() |
||
| 377 | |||
| 378 | public function saveCurrentLocale($locale) |
||
| 382 | |||
| 383 | /** |
||
| 384 | * @param $ident |
||
| 385 | * @throws \RuntimeException |
||
| 386 | * @return AbstractTool |
||
| 387 | */ |
||
| 388 | 2 | public function getTool($ident) |
|
| 396 | |||
| 397 | 2 | public function addTool(ToolInterface $tool) |
|
| 401 | |||
| 402 | 2 | public function getTools() |
|
| 406 | |||
| 407 | public function getActiveHeaderToolbarTools() |
||
| 419 | |||
| 420 | public function getActiveBodyToolbarToolsOnTop() |
||
| 424 | |||
| 425 | public function getActiveBodyToolbarToolsOnBottom() |
||
| 429 | |||
| 430 | public function getActiveBodyToolbarTools($position) |
||
| 443 | |||
| 444 | public function getTabErrorsCount($tabTitle, $errors) |
||
| 456 | |||
| 457 | public function locales(array $locales) |
||
| 464 | |||
| 465 | public function getLocales() |
||
| 469 | |||
| 470 | // TODO: move helper to trait or smth |
||
| 471 | private function isAssociativeArray(array $array) |
||
| 479 | |||
| 480 | private function normalizeLocales(array &$locales) |
||
| 489 | |||
| 490 | 17 | public function actions() |
|
| 494 | |||
| 495 | 1 | public function enableBatchCheckboxes(bool $enabled = true) |
|
| 499 | |||
| 500 | public function isBatchCheckboxesEnabled() |
||
| 504 | |||
| 505 | public function enableSortableByWeight(string $field) |
||
| 509 | |||
| 510 | public function isSortableByWeight() |
||
| 514 | |||
| 515 | 1 | public function isSortableByWeightActive() |
|
| 519 | |||
| 520 | public function getSortableWeightFieldName() |
||
| 524 | |||
| 525 | public function setSortableOrderState(bool $active) |
||
| 529 | |||
| 530 | 13 | public function enableSoftDelete(bool $enabled = true) |
|
| 534 | |||
| 535 | 3 | public function isSoftDeleteEnabled(): bool |
|
| 539 | |||
| 540 | private function makeDefaultColumnField($column) |
||
| 544 | } |
||
| 545 |
Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a
@returnannotation as described here.