Password::hash() - Code Metrics - Inspection of "remove php70 from travisci builds" - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 51084e...d852c9 )

by Yaro

created 2019-09-01 13:46 UTC

Password::hash() B

↳ Parent: Password

Complexity

Conditions	6
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	6.2163

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	9
cts	11
cp	0.8182
rs	8.9457
c	0
b	0
f	0
cc	6
nc	4
nop	1
crap	6.2163

<?php

namespace Yaro\Jarboe\Table\Fields;

use Illuminate\Http\Request;
use Yaro\Jarboe\Table\Fields\Traits\Nullable;
use Yaro\Jarboe\Table\Fields\Traits\Orderable;
use Yaro\Jarboe\Table\Fields\Traits\Placeholder;
use Yaro\Jarboe\Table\Fields\Traits\Tooltip;

class Password extends AbstractField
{
    use Orderable;
    use Nullable;
    use Tooltip;
    use Placeholder;

    protected $hash = 'bcrypt';

    public function hash($hash)
    {
        if (is_object($hash) && is_a($hash, \Closure::class)) {
            $this->hash = $hash;

            return $this;
        }

        if (is_string($hash) && function_exists($hash)) {
            $this->hash = $hash;
            return $this;
        }

        // dummy
        if (is_null($hash)) {
            $this->hash = function($value) {

                return $value;
            };
            return $this;
        }

        throw new \RuntimeException('Hash for PasswordField must be valid function name or closure');
    }

    public function value(Request $request)

    {
        $hash = $this->hash;

        return $hash(parent::value($request));
    }

    public function shouldSkip(Request $request)
    {
        return !$request->get($this->name());
    }

    public function getListValue($model)

    {
        return view('jarboe::crud.fields.password.list', [
            'model' => $model,
            'field' => $this,
        ])->render();
    }

    public function getEditFormValue($model)

    {
        $template = $this->isReadonly() ? 'readonly' : 'edit';

        return view('jarboe::crud.fields.password.'. $template, [
            'model' => $model,
            'field' => $this,
        ])->render();
    }

    public function getCreateFormValue()

    {
        return view('jarboe::crud.fields.password.create', [
            'field' => $this,
        ])->render();
    }
}


1		<?php
2
3		namespace Yaro\Jarboe\Table\Fields;
4
5		use Illuminate\Http\Request;
6		use Yaro\Jarboe\Table\Fields\Traits\Nullable;
7		use Yaro\Jarboe\Table\Fields\Traits\Orderable;
8		use Yaro\Jarboe\Table\Fields\Traits\Placeholder;
9		use Yaro\Jarboe\Table\Fields\Traits\Tooltip;
10
11		class Password extends AbstractField
12		{
13		use Orderable;
14		use Nullable;
15		use Tooltip;
16		use Placeholder;
17
18		protected $hash = 'bcrypt';
19
20	3	public function hash($hash)
21		{
22	3	if (is_object($hash) && is_a($hash, \Closure::class)) {
23	1	$this->hash = $hash;
		0 ignored issues – show Documentation Bug introduced 2019-08-09 05:40 UTC by Report Bug Copy Issue Report It seems like `$hash` of type `object` is incompatible with the declared type `string` of property `$hash`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
24	1	return $this;
25		}
26
27	2	if (is_string($hash) && function_exists($hash)) {
28	1	$this->hash = $hash;
29	1	return $this;
30		}
31
32		// dummy
33	1	if (is_null($hash)) {
34		$this->hash = function($value) {
		0 ignored issues – show Documentation Bug introduced 2019-08-09 05:40 UTC by Report Bug Copy Issue Report It seems like `function ($value) { return $value; }` of type `object<Closure>` is incompatible with the declared type `string` of property `$hash`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
35		return $value;
36		};
37		return $this;
38		}
39
40	1	throw new \RuntimeException('Hash for PasswordField must be valid function name or closure');
41		}
42
43	3	public function value(Request $request)
		0 ignored issues – show Documentation introduced 2019-08-31 12:57 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
44		{
45	3	$hash = $this->hash;
46
47	3	return $hash(parent::value($request));
48		}
49
50	2	public function shouldSkip(Request $request)
51		{
52	2	return !$request->get($this->name());
53		}
54
55		public function getListValue($model)
		0 ignored issues – show Documentation introduced 2019-08-31 12:57 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
56		{
57		return view('jarboe::crud.fields.password.list', [
58		'model' => $model,
59		'field' => $this,
60		])->render();
61		}
62
63		public function getEditFormValue($model)
		0 ignored issues – show Documentation introduced 2019-08-31 12:57 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
64		{
65		$template = $this->isReadonly() ? 'readonly' : 'edit';
66
67		return view('jarboe::crud.fields.password.'. $template, [
68		'model' => $model,
69		'field' => $this,
70		])->render();
71		}
72
73		public function getCreateFormValue()
		0 ignored issues – show Documentation introduced 2019-08-31 12:57 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
74		{
75		return view('jarboe::crud.fields.password.create', [
76		'field' => $this,
77		])->render();
78		}
79		}
80

Cherry-Pie / Jarboe

Push — master ( 51084e...d852c9 )

Password::hash() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like