RevertHandlerTrait::handleRevert() - Code Metrics - Inspection of "Merge pull request #19 from Cherry-Pie/analysis-1b..." - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 665333...49dc1a )

by Yaro

created 2020-07-21 09:21 UTC

RevertHandlerTrait::handleRevert() A

↳ Parent: RevertHandlerTrait

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	31
rs	9.424
c	0
b	0
f	0
cc	4
nc	4
nop	2

<?php

namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;

use Illuminate\Http\Request;
use RuntimeException;
use Spatie\Permission\Exceptions\UnauthorizedException;
use Yaro\Jarboe\Exceptions\PermissionDenied;
use Yaro\Jarboe\Table\CRUD;

trait RevertHandlerTrait
{
    /**
     * Revert model to specific version.
     *
     * @param Request $request
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     * @throws PermissionDenied
     * @throws UnauthorizedException
     */
    public function handleRevert(Request $request, $id)
    {
        $this->beforeInit();
        $this->init();
        $this->bound();

        if (!$this->can('revert')) {
            throw UnauthorizedException::forPermissions(['revert']);
        }

        $model = $this->crud()->repo()->find($id);
        if (!$this->crud()->actions()->isAllowed('history', $model)) {
            throw new PermissionDenied();
        }

        $version = $model->versions()->find($request->get('version'));
        if (is_null($version)) {
            throw new RuntimeException('Version does not exist');
        }

        $version->revert();

        return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'ok' => true,
            'timeline' => view('jarboe::crud.inc.history.timeline', [
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                'crud' => $this->crud(),
                'item' => $model,
                'versions' => $model->versions()->latest()->paginate(8),
            ])->render(),
        ]);
    }

    abstract protected function beforeInit();

    abstract protected function init();

    abstract protected function bound();

    abstract protected function crud(): CRUD;
    abstract protected function can($action): bool;
}


Push — master ( 665333...49dc1a )

RevertHandlerTrait::handleRevert() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace Yaro\Jarboe\Http\Controllers\Traits\Handlers;
4
5			use Illuminate\Http\Request;
6			use RuntimeException;
7			use Spatie\Permission\Exceptions\UnauthorizedException;
8			use Yaro\Jarboe\Exceptions\PermissionDenied;
9			use Yaro\Jarboe\Table\CRUD;
10
11			trait RevertHandlerTrait
12			{
13			/**
14			* Revert model to specific version.
15			*
16			* @param Request $request
17			* @param $id
18			* @return \Illuminate\Http\JsonResponse
19			* @throws PermissionDenied
20			* @throws UnauthorizedException
21			*/
22			public function handleRevert(Request $request, $id)
23			{
24			$this->beforeInit();
25			$this->init();
26			$this->bound();
27
28			if (!$this->can('revert')) {
29			throw UnauthorizedException::forPermissions(['revert']);
30			}
31
32			$model = $this->crud()->repo()->find($id);
33			if (!$this->crud()->actions()->isAllowed('history', $model)) {
34			throw new PermissionDenied();
35			}
36
37			$version = $model->versions()->find($request->get('version'));
38			if (is_null($version)) {
39			throw new RuntimeException('Version does not exist');
40			}
41
42			$version->revert();
43
44			return response()->json([
			0 ignored issues – show Bug introduced 2019-09-03 10:29 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
45			'ok' => true,
46			'timeline' => view('jarboe::crud.inc.history.timeline', [
			0 ignored issues – show Bug introduced 2020-07-21 09:30 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
47			'crud' => $this->crud(),
48			'item' => $model,
49			'versions' => $model->versions()->latest()->paginate(8),
50			])->render(),
51			]);
52			}
53
54			abstract protected function beforeInit();
			0 ignored issues – show Documentation introduced 2020-07-21 09:30 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
55			abstract protected function init();
			0 ignored issues – show Documentation introduced 2020-07-21 09:30 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
56			abstract protected function bound();
			0 ignored issues – show Documentation introduced 2020-07-21 09:30 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
57			abstract protected function crud(): CRUD;
58			abstract protected function can($action): bool;
59			}
60

Cherry-Pie / Jarboe

Push — master ( 665333...49dc1a )

RevertHandlerTrait::handleRevert() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like