TabsTrait::getTabs() - Code Metrics - Inspection of "new dependencies version" - Cherry-Pie/Jarboe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ad2c0d...49711d )

by Yaro

created 2019-10-28 16:20 UTC

TabsTrait::getTabs() A

↳ Parent: TabsTrait

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	0
cts	8
cp	0
rs	9.7998
c	0
b	0
f	0
cc	4
nc	3
nop	1
crap	20

<?php

namespace Yaro\Jarboe\Table\CrudTraits;

use Yaro\Jarboe\Table\Fields\AbstractField;

trait TabsTrait
{
    public function getTabErrorsCount($tabTitle, $errors)
    {
        $count = 0;
        $tabs = $this->getTabs();
        $fields = $tabs[$tabTitle];

        foreach ($fields as $field) {
            $count += count($errors->get($field->name()));
        }

        return $count;
    }

    public function getTabs($skipHiddenType = null)

    {
        $tabs = [];
        foreach ($this->getFields() as $field) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            if ($skipHiddenType && $field->hidden($skipHiddenType)) {
                continue;
            }
            $tabs[$field->getTab()][] = $field;
        }

        $this->moveDefaultTabToEnd($tabs);

        return $tabs;
    }

    private function moveDefaultTabToEnd(&$tabs)
    {
        $defaultTab = AbstractField::DEFAULT_TAB_IDENT;
        if (!array_key_exists($defaultTab, $tabs)) {
            return;
        }

        $defaultTabFields = $tabs[$defaultTab];
        unset($tabs[$defaultTab]);
        $tabs[$defaultTab] = $defaultTabFields;
    }
}


1			<?php
2
3			namespace Yaro\Jarboe\Table\CrudTraits;
4
5			use Yaro\Jarboe\Table\Fields\AbstractField;
6
7			trait TabsTrait
8			{
9			public function getTabErrorsCount($tabTitle, $errors)
10			{
11			$count = 0;
12			$tabs = $this->getTabs();
13			$fields = $tabs[$tabTitle];
14
15			foreach ($fields as $field) {
16			$count += count($errors->get($field->name()));
17			}
18
19			return $count;
20			}
21
22			public function getTabs($skipHiddenType = null)
			0 ignored issues – show Documentation introduced 2019-10-28 16:30 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
23			{
24			$tabs = [];
25			foreach ($this->getFields() as $field) {
			0 ignored issues – show Bug introduced 2019-10-28 16:30 UTC by Report Bug Copy Issue Report It seems like `getFields()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26			if ($skipHiddenType && $field->hidden($skipHiddenType)) {
27			continue;
28			}
29			$tabs[$field->getTab()][] = $field;
30			}
31
32			$this->moveDefaultTabToEnd($tabs);
33
34			return $tabs;
35			}
36
37			private function moveDefaultTabToEnd(&$tabs)
38			{
39			$defaultTab = AbstractField::DEFAULT_TAB_IDENT;
40			if (!array_key_exists($defaultTab, $tabs)) {
41			return;
42			}
43
44			$defaultTabFields = $tabs[$defaultTab];
45			unset($tabs[$defaultTab]);
46			$tabs[$defaultTab] = $defaultTabFields;
47			}
48			}
49

Cherry-Pie / Jarboe

Push — master ( ad2c0d...49711d )

TabsTrait::getTabs() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like