Yaro\Jarboe\Http\Controllers\Traits\Handlers\DeleteHandlerTrait::handleDelete()

Complexity

Conditions	5
Paths	5

Size

Total Lines	34
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	5.3374

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function handleDelete(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $this->beforeInit();
        $this->init();
        $this->bound();

        $model = $this->crud()->repo()->find($id);
        if (!$this->crud()->actions()->isAllowed('delete', $model)) {
            throw new PermissionDenied();
        }

        if (!$this->can('delete')) {
            throw UnauthorizedException::forPermissions(['delete']);
        }

        $this->idEntity = $model->getKey();

The property idEntity does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        if ($this->crud()->repo()->delete($id)) {
            $type = 'hidden';
            try {
                $this->crud()->repo()->find($id);
            } catch (\Exception $e) {
                $type = 'removed';
            }

            return response()->json([
                'type' => $type,
                'message' => __('jarboe::common.list.delete_success_message', ['id' => $id]),
            ]);
        }

        return response()->json([
            'message' => __('jarboe::common.list.delete_failed_message', ['id' => $id]),
        ], 422);
    }