OlderWasFound::findLatestDateTimeFromNews() - Code Metrics - Inspection of "Adding unit tests" - Chemaclass/stock-ticker - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#4)

by Chema

created 2020-12-16 19:17 UTC

OlderWasFound::findLatestDateTimeFromNews() A

↳ Parent: OlderWasFound

Complexity

Conditions	3
Paths	1

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	9
nc	1
nop	1
dl	0
loc	16
ccs	11
cts	11
cp	1
crap	3
rs	9.9666
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Chemaclass\StockTicker\Domain\Notifier\Policy\Condition;

use Chemaclass\StockTicker\Domain\Notifier\Policy\PolicyConditionInterface;
use Chemaclass\StockTicker\Domain\ReadModel\Company;

final class OlderWasFound implements PolicyConditionInterface
{
    /**
     * @var array<string,string>
     * For example ['TickerSymbol' => 'datetime']
     */
    private static array $cacheOldestBySymbol = [];

    private string $companyKey;

    private string $keyToCompare;

    public function __construct(string $companyKey, string $keyToCompare = 'datetime')
    {
        $this->companyKey = $companyKey;
        $this->keyToCompare = $keyToCompare;
    }

    public function __invoke(Company $company): bool
    {
        $current = $this->findLatestDateTimeFromNews($company);
        $previous = self::$cacheOldestBySymbol[$company->symbol()->toString()] ?? '';

        self::$cacheOldestBySymbol[$company->symbol()->toString()] = $current;

        return $current > $previous;
    }

    private function findLatestDateTimeFromNews(Company $company): string
    {
        $reduced = array_reduce(
            (array) $company->info($this->companyKey),
            function (?array $carry, array $current): array {
                if (null === $carry) {

                    return $current;
                }

                return $carry[$this->keyToCompare] > $current[$this->keyToCompare]
                    ? $carry
                    : $current;
            }
        );

        return $reduced[$this->keyToCompare];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Chemaclass\StockTicker\Domain\Notifier\Policy\Condition;
6
7		use Chemaclass\StockTicker\Domain\Notifier\Policy\PolicyConditionInterface;
8		use Chemaclass\StockTicker\Domain\ReadModel\Company;
9
10		final class OlderWasFound implements PolicyConditionInterface
11		{
12		/**
13		* @var array<string,string>
14		* For example ['TickerSymbol' => 'datetime']
15		*/
16		private static array $cacheOldestBySymbol = [];
17
18		private string $companyKey;
19
20		private string $keyToCompare;
21
22	1	public function __construct(string $companyKey, string $keyToCompare = 'datetime')
23		{
24	1	$this->companyKey = $companyKey;
25	1	$this->keyToCompare = $keyToCompare;
26	1	}
27
28	1	public function __invoke(Company $company): bool
29		{
30	1	$current = $this->findLatestDateTimeFromNews($company);
31	1	$previous = self::$cacheOldestBySymbol[$company->symbol()->toString()] ?? '';
32
33	1	self::$cacheOldestBySymbol[$company->symbol()->toString()] = $current;
34
35	1	return $current > $previous;
36		}
37
38	1	private function findLatestDateTimeFromNews(Company $company): string
39		{
40	1	$reduced = array_reduce(
41	1	(array) $company->info($this->companyKey),
42	1	function (?array $carry, array $current): array {
43	1	if (null === $carry) {
		0 ignored issues – show introduced 2020-12-15 16:58 UTC by Report Bug Copy Issue Report The condition `null === $carry` is always `false`. Loading history...
44	1	return $current;
45		}
46
47	1	return $carry[$this->keyToCompare] > $current[$this->keyToCompare]
48	1	? $carry
49	1	: $current;
50	1	}
51		);
52
53	1	return $reduced[$this->keyToCompare];
54		}
55		}
56

Chemaclass / stock-ticker

Pull Request — master (#4)

OlderWasFound::findLatestDateTimeFromNews() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like