RecentNewsWasFound::__invoke() - Code Metrics - Inspection of "Fix typo" - Chemaclass/stock-ticker - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c0f32c...e879f4 )

by Chema

created 2020-12-27 22:58 UTC

RecentNewsWasFound::__invoke() A

↳ Parent: RecentNewsWasFound

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes

Metric	Value
eloc	6
c	0
b	0
f	0
dl	0
loc	12
ccs	7
cts	7
cp	1
rs	10
cc	2
nc	2
nop	1
crap	2

<?php

declare(strict_types=1);

namespace Chemaclass\StockTicker\Domain\Notifier\Policy\Condition;

use Chemaclass\StockTicker\Domain\Notifier\Policy\PolicyConditionInterface;
use Chemaclass\StockTicker\Domain\WriteModel\News;
use Chemaclass\StockTicker\Domain\WriteModel\Quote;

final class RecentNewsWasFound implements PolicyConditionInterface
{
    /**
     * @var array<string,string>
     * For example ['Symbol' => 'datetime']
     */
    private static array $cacheOldestBySymbol = [];

    public function __invoke(Quote $quote): bool
    {
        if (null === $quote->getSymbol()) {
            return false;
        }

        $current = $this->findLatestDateTimeFromNews($quote);
        $previous = self::$cacheOldestBySymbol[$quote->getSymbol()] ?? '';

        self::$cacheOldestBySymbol[$quote->getSymbol()] = $current;

        return $current > $previous;
    }

    private function findLatestDateTimeFromNews(Quote $quote): string
    {
        $reduced = array_reduce(
            $quote->getLatestNews(),
            static function (?News $carry, News $current): News {
                if (null === $carry) {
                    return $current;
                }

                return $carry->getDatetime() > $current->getDatetime()
                    ? $carry
                    : $current;
            }
        );

        return $reduced->getDatetime() ?? '';
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Chemaclass\StockTicker\Domain\Notifier\Policy\Condition;
6
7		use Chemaclass\StockTicker\Domain\Notifier\Policy\PolicyConditionInterface;
8		use Chemaclass\StockTicker\Domain\WriteModel\News;
9		use Chemaclass\StockTicker\Domain\WriteModel\Quote;
10
11		final class RecentNewsWasFound implements PolicyConditionInterface
12		{
13		/**
14		* @var array<string,string>
15		* For example ['Symbol' => 'datetime']
16		*/
17		private static array $cacheOldestBySymbol = [];
18
19	3	public function __invoke(Quote $quote): bool
20		{
21	3	if (null === $quote->getSymbol()) {
22	2	return false;
23		}
24
25	2	$current = $this->findLatestDateTimeFromNews($quote);
26	2	$previous = self::$cacheOldestBySymbol[$quote->getSymbol()] ?? '';
27
28	2	self::$cacheOldestBySymbol[$quote->getSymbol()] = $current;
29
30	2	return $current > $previous;
31		}
32
33	2	private function findLatestDateTimeFromNews(Quote $quote): string
34		{
35	2	$reduced = array_reduce(
36	2	$quote->getLatestNews(),
37	2	static function (?News $carry, News $current): News {
38	2	if (null === $carry) {
39	2	return $current;
40		}
41
42	2	return $carry->getDatetime() > $current->getDatetime()
43	1	? $carry
44	2	: $current;
45	2	}
46		);
47
48	2	return $reduced->getDatetime() ?? '';
49		}
50		}
51

Chemaclass / stock-ticker

Push — master ( c0f32c...e879f4 )

RecentNewsWasFound::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like