SegmentFactory::__construct() - Code Metrics - Inspection of "Introduce CustomSegmentFactory" - Chemaclass/EdifactParser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8f83e8...e4d779 )

by Chema

created 2019-11-09 15:40 UTC

SegmentFactory::__construct() A

↳ Parent: SegmentFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0
ccs	2
cts	2
cp	1
crap	1

<?php

declare(strict_types=1);

namespace EdifactParser\Segments;

final class SegmentFactory
{
    /** @var CustomSegmentFactoryInterface|null */
    private $customSegmentsFactory;

    public function __construct(?CustomSegmentFactoryInterface $customSegmentsFactory)
    {
        $this->customSegmentsFactory = $customSegmentsFactory;
    }

    public function segmentFromArray(array $rawArray): SegmentInterface
    {
        $customSegment = $this->customSegment($rawArray);

        if ($customSegment) {
            return $customSegment;
        }

        $name = $rawArray[0];

        switch ($name) {
            case 'UNH':
                return new UNHMessageHeader($rawArray);
            case 'DTM':
                return new DTMDateTimePeriod($rawArray);
            case 'NAD':
                return new NADNameAddress($rawArray);
            case 'MEA':
                return new MEADimensions($rawArray);
            case 'CNT':
                return new CNTControl($rawArray);
            case 'PCI':
                return new PCIPackageId($rawArray);
            case 'BGM':
                return new BGMBeginningOfMessage($rawArray);
            case 'UNT':
                return new UNTMessageFooter($rawArray);
        }

        return new UnknownSegment($rawArray);
    }

    private function customSegment(array $rawArray): ?SegmentInterface
    {
        if ($this->customSegmentsFactory) {
            $segment = $this->customSegmentsFactory->segmentFromArray($rawArray);
            if ($segment) {
                return $segment;
            }
        }

        return null;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace EdifactParser\Segments;
6
7		final class SegmentFactory
8		{
9		/** @var CustomSegmentFactoryInterface\|null */
10		private $customSegmentsFactory;
11
12	7	public function __construct(?CustomSegmentFactoryInterface $customSegmentsFactory)
13		{
14	7	$this->customSegmentsFactory = $customSegmentsFactory;
15	7	}
16
17	7	public function segmentFromArray(array $rawArray): SegmentInterface
18		{
19	7	$customSegment = $this->customSegment($rawArray);
20
21	7	if ($customSegment) {
22	1	return $customSegment;
23		}
24
25	7	$name = $rawArray[0];
26
27	7	switch ($name) {
28	7	case 'UNH':
29	7	return new UNHMessageHeader($rawArray);
30	6	case 'DTM':
31		return new DTMDateTimePeriod($rawArray);
32	6	case 'NAD':
33		return new NADNameAddress($rawArray);
34	6	case 'MEA':
35		return new MEADimensions($rawArray);
36	6	case 'CNT':
37	3	return new CNTControl($rawArray);
38	6	case 'PCI':
39		return new PCIPackageId($rawArray);
40	6	case 'BGM':
41		return new BGMBeginningOfMessage($rawArray);
42	6	case 'UNT':
43	6	return new UNTMessageFooter($rawArray);
44		}
45
46	5	return new UnknownSegment($rawArray);
47		}
48
49	7	private function customSegment(array $rawArray): ?SegmentInterface
50		{
51	7	if ($this->customSegmentsFactory) {
52	1	$segment = $this->customSegmentsFactory->segmentFromArray($rawArray);
53	1	if ($segment) {
54	1	return $segment;
55		}
56		}
57
58	7	return null;
59		}
60		}
61

Chemaclass / EdifactParser

Push — master ( 8f83e8...e4d779 )

SegmentFactory::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like