EdifactParser\EdifactParser

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	parse()	0	12	2

<?php

declare(strict_types=1);

namespace EdifactParser;

use EDI\Parser;
use EdifactParser\Exception\InvalidFile;
use EdifactParser\Segments\CustomSegmentFactoryInterface;

final class EdifactParser
{
    /** @var CustomSegmentFactoryInterface|null */
    private $customSegmentsFactory;

    public function __construct(?CustomSegmentFactoryInterface $customSegmentsFactory = null)
    {
        $this->customSegmentsFactory = $customSegmentsFactory;
    }

    public function parse(string $fileContent): TransactionResult
    {
        $parser = new Parser($fileContent);
        $errors = $parser->errors();

        if ($errors) {

The expression $errors of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            throw InvalidFile::withErrors($errors);
        }

        $segmentedValues = SegmentedValues::fromRaw($parser->get(), $this->customSegmentsFactory);

        return TransactionResult::fromSegmentedValues($segmentedValues);
    }
}